Re: [virt-tools-list] virt-install should copy libvirt storage pool auth element and all source hosts to domain xml

2018-01-26 Thread Cole Robinson
On 01/26/2018 05:29 AM, Rauno Väli wrote: > virt-install should copy libvirt storage pool auth element and all > source hosts to domain xml > Thanks for the patch! Can you give me an example pool config and matching disk config it generates? So I can add a test case for this patch. Changing the a

Re: [virt-tools-list] [PATCH] virtinst: Add NUMA distance support

2018-01-26 Thread Cole Robinson
ageman (crobinso: rework cli format, drop some validation, drop man changes) Signed-off-by: Cole Robinson --- .../compare/virt-install-singleton-config-2.xml| 28 ++ tests/clitest.py | 9 ++- virtinst/cli.py

Re: [virt-tools-list] [PATCH] virtinst: Add NUMA distance support

2018-01-30 Thread Cole Robinson
On 01/29/2018 06:23 AM, Menno Lageman wrote: > On 26-01-18 20:50, Cole Robinson wrote: >> I've attached an updated patch that applies to master. Has the updated >> cli format, drops the validation stuff, and the man page bits too since >> I intended that to just be an exa

Re: [virt-tools-list] virt-install should copy libvirt storage pool auth element and all source hosts to domain xml

2018-01-30 Thread Cole Robinson
On 01/29/2018 01:37 AM, Rauno Väli wrote: > libvirt pool dumpxml: > >   rbd.test >   57e55e10-63c9-4166-861c-f330d868260c >   36792725520384 >   760411510361 >   34510461812736 >   >     >     >     >     rbd.test >     >       >     >   > > > with this patch i get correct disk definitio

Re: [virt-tools-list] startup_policy not documented

2018-02-05 Thread Cole Robinson
On 02/05/2018 06:43 PM, Digimer wrote: > Hi all, > > The 'virt-install' man page says; > > > STORAGE OPTIONS > > ... > > startup_policy >It defines what to do with the disk if the source file >is not accessible. See possible values in >

Re: [virt-tools-list] [PATCH] virtinst: add vcpupin support

2018-02-06 Thread Cole Robinson
On 02/06/2018 06:56 AM, Menno Lageman wrote: > From: Wim ten Have > > Add vcpupin support to virt-install so that it can create guest > domains with statically allocated vcpu pinning towards a given cpuset. > > Syntax: to pin vcpu=0 to cpuset="1,3" and vcpu=1 to cpuset=2 > > --cputune > vcpu

[virt-tools-list] ANNOUNCE: virt-manager 1.5.0 released

2018-02-06 Thread Cole Robinson
I'm happy to announce the release of virt-manager 1.5.0! virt-manager is a desktop application for managing KVM, Xen, and LXC virtualization via libvirt. The release can be downloaded from: http://virt-manager.org/download/ This release includes: - python3 prep work (Radostin Stoyanov,

[virt-tools-list] virt-manager py3 port now in master

2018-02-06 Thread Cole Robinson
Hi all, I've merged the python3 port into virt-manager git master now. The next major release will be 2.0 and contain this work. python2 compat is not maintained, it's strictly python3. I haven't figured out a minimum supported python3 version yet The url, ui, initrd inject, and standard test sui

Re: [virt-tools-list] [virt-manager PATCH] pylint: fix logging-too-few-args issue

2018-02-13 Thread Cole Robinson
On 02/13/2018 03:46 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > pylint complain: > Not enough arguments for logging format string (logging-too-few-args) > > Signed-off-by: Chen Hanxiao > --- > tests/uitests/utils.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [virt-tools-list] [virt-manager] [PATCH] Italian translation update

2018-02-21 Thread Cole Robinson
SCRIPTIVE TITLE. > # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER > # This file is distributed under the same license as the PACKAGE package. > # > # Translators: > -# Cole Robinson , 2011 > -# gscrivano , 2013-2014 > -# Guido Grazioli , 2011 > -# Massimiliano Trope

Re: [virt-tools-list] [PATCH] virtinst: add feature support

2018-02-21 Thread Cole Robinson
On 02/20/2018 02:30 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The feature allows a guest to provide debug details when > producing dump. It's useful in particular for Linux guests with KASLR > enabled, as otherwise the dump are difficult to analyze. > Thanks for the

Re: [virt-tools-list] [PATCH] virtinst: add feature support

2018-02-22 Thread Cole Robinson
On 02/21/2018 11:31 AM, Marc-André Lureau wrote: > Hi > > On Wed, Feb 21, 2018 at 4:08 PM, Cole Robinson wrote: >> On 02/20/2018 02:30 PM, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> The feature allows a guest to provide d

Re: [virt-tools-list] [PATCH v2 0/6] virtinst: add feature support

2018-02-22 Thread Cole Robinson
On 02/22/2018 06:34 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > The feature allows a guest to provide debug details when > producing dump. It's useful in particular for Linux guests with KASLR > enabled, as otherwise the dump are difficult to analyze. > > This

Re: [virt-tools-list] Crash in libxml python callback running tests

2018-02-23 Thread Cole Robinson
On 02/23/2018 08:48 AM, Daniel P. Berrangé wrote: > I built libvirt using --prefix=/usr/local, and then did *not* run > 'make install'. > > I then tried to run virt-manager tests > > ../libvirt/run python3 setup.py test > > It crashed & burned. Initially the problem is that the > virConnectGet

Re: [virt-tools-list] [virt-manager PATCH] Allow installation of i686 guests on x86_64 machines

2018-03-03 Thread Cole Robinson
On 03/01/2018 03:52 AM, Martin Kletzander wrote: > Do that by changing the code that was disabling it into code that just warns > in > such case. > > Signed-off-by: Martin Kletzander > --- > virtManager/create.py | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git

Re: [virt-tools-list] [virt-manager] [PATCH 0/5] Use pylint/pycodestyle modules

2018-03-03 Thread Cole Robinson
On 03/02/2018 03:01 AM, Radostin Stoyanov wrote: > Radostin Stoyanov (5): > pylint: Use pylint.lint module > pylint: Silence inconsistent-return-statements > pylint: Resolve logging-not-lazy > pylint: Resolve consider-using-enumerate > pycodestyle: Use module instead of executable > > s

Re: [virt-tools-list] [virt-manager PATCH] Allow installation of i686 guests on x86_64 machines

2018-03-03 Thread Cole Robinson
On 03/03/2018 04:03 PM, Martin Kletzander wrote: > On Sat, Mar 03, 2018 at 03:53:59PM -0500, Cole Robinson wrote: >> On 03/01/2018 03:52 AM, Martin Kletzander wrote: >>> Do that by changing the code that was disabling it into code that >>> just warns in >>> such

Re: [virt-tools-list] [virt-manager] [PATCH] virtinst: progress: Simplify if-statement

2018-03-03 Thread Cole Robinson
On 03/02/2018 03:12 AM, Radostin Stoyanov wrote: > Signed-off-by: Radostin Stoyanov > --- > virtinst/progress.py | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/virtinst/progress.py b/virtinst/progress.py > index 29bff358..4284f854 100644 > --- a/virtinst/pr

Re: [virt-tools-list] [PATCH 0/2] Show IP address in virt-manager

2018-03-03 Thread Cole Robinson
On 03/02/2018 01:27 AM, Dylan Stephano-Shachter wrote: > I have added a feature to show a VM's first IP address next to the VM state > (Running, etc.). This feature can be toggled in the preferences menu and is > disabled by default. It uses the qemu-guest agent to query the IP address. > > Dyla

Re: [virt-tools-list] Change UUID

2018-03-19 Thread Cole Robinson
On 03/19/2018 12:05 PM, Toan Pham wrote: > > > > > > Which management tool in particular, and which UUID ? > > The UUIDs present in pretty much all the libvirt XML schemas are > autofilled > with a random value when libvirt parsers it, if the mgmt tool hasn't > already >

Re: [virt-tools-list] [PATCH] [RFC] CPU model capabilities vs domcapabilities

2018-03-26 Thread Cole Robinson
On 03/23/2018 04:35 PM, Charles Arnold wrote: > The issue is when the host has been updated with microcode for Spectre > but qemu has _not_ been updated. In this scenario (as an example), > 'virsh capabilities' shows the host cpu model as IvyBridge-IBRS, which is > correct. However, 'virsh domcapab

Re: [virt-tools-list] [PATCH v2] CPU model capabilities vs domcapabilities

2018-03-28 Thread Cole Robinson
On 03/26/2018 05:08 PM, Charles Arnold wrote: > The issue is when the host has been updated with microcode for Spectre > but qemu has _not_ been updated. In this scenario (as an example), > 'virsh capabilities' shows the host cpu model as IvyBridge-IBRS, which is > correct. However, 'virsh domcapab

Re: [virt-tools-list] [PATCH v3 1/2] virtinst: read CPU model from domain capabilities

2018-04-03 Thread Cole Robinson
On 03/28/2018 03:45 PM, Charles Arnold wrote: > Add functionality to acquire the CPU model from the > libvirt domain capabilities. This is used to compare > with the host CPU model. > > --- > virtinst/domcapabilities.py | 30 ++ > 1 file changed, 30 insertions(+) > >

Re: [virt-tools-list] [PATCH v3 2/2] virtinst: compare host and domain cpu models

2018-04-03 Thread Cole Robinson
On 03/28/2018 03:45 PM, Charles Arnold wrote: > Lookup the domain capabilities CPU model and compare with > the host capabilities CPU model and if they are not equal > set the guest's CPU model to None. > > --- > virtinst/guest.py | 9 + > 1 file changed, 9 insertions(+) > > diff --git a

Re: [virt-tools-list] Fw: [PATCH] support username and password in prepareLocation

2018-04-03 Thread Cole Robinson
On 04/01/2018 09:36 AM, Mark Hamzy wrote: > If --location is an ftp url with a username and password > then virt-install fails to install with an error: > ERROR Error validating install location: Opening URL u failed: 530 Login > incorrect.. > --- > virtinst/urlfetcher.py | 8 +++- > 1 file chan

Re: [virt-tools-list] [PATCH] virtinst: Trivial spelling fix

2018-04-04 Thread Cole Robinson
On 04/03/2018 04:56 PM, Charles Arnold wrote: > Trivial spelling fix. > > Signed-off-by: Charles Arnold > > diff --git a/virtinst/guest.py b/virtinst/guest.py > index 563203b4..db354896 100644 > --- a/virtinst/guest.py > +++ b/virtinst/guest.py > @@ -870,7 +870,7 @@ class Guest(XMLBuilder): >

Re: [virt-tools-list] libvirt ssh

2018-04-04 Thread Cole Robinson
On 04/04/2018 04:53 PM, Alberto Sosa wrote: > Hi! > My name is Alberto and I'm computer science student. I'm doing my final > degree project that consist on a web interface for vm management using > libvirt, python and flask. > I'm stuck on making connections via SSH: I tried to get username and

Re: [virt-tools-list] [PATCH 3/3] Redesign OS distro selection UI to be faster to use

2018-04-04 Thread Cole Robinson
I pushed patch #1 and #2, thanks On 04/04/2018 09:35 AM, Daniel P. Berrangé wrote: > The current OS distro selection UI is fairly cumbersome to use. First > you need to decide on a variant, then decide a distro and then look for > the version you want. The list is filtered by default so only a sub

Re: [virt-tools-list] [virt-manager][PATCH] setup.py: Distribute virtinst/ subdirectories

2018-04-16 Thread Cole Robinson
On 04/11/2018 07:09 AM, Michal Privoznik wrote: > On 04/11/2018 12:43 PM, Radostin Stoyanov wrote: >> Hi Michal, >> >> This commit was also created as a pull request by @z3ntu on github >> https://github.com/virt-manager/virt-manager/pull/29 > > Ah, haven't noticed because we don't use github pull

Re: [virt-tools-list] [PATCH] virtinst: Update SUSE media detection

2018-04-24 Thread Cole Robinson
On 04/10/2018 05:48 PM, Charles Arnold wrote: > Add the ability to detect a .treeinfo file found on newer > SUSE distro media. Specifically, SLE15, openSUSE Leap 15 > (newer than pre-release build 191), and Tumbleweed > beginning with build 20180407 which all contain a > .treeinfo file on the media

Re: [virt-tools-list] [virt-manager] [PATCH] tests: uriparse: Test for @ symbol in username

2018-04-24 Thread Cole Robinson
On 04/18/2018 02:31 AM, Radostin Stoyanov wrote: > Add test case for URI that contains the @ symbol in username. > > Signed-off-by: Radostin Stoyanov > --- > tests/uriparse.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tests/uriparse.py b/tests/uriparse.py > index 5f733820..e2

Re: [virt-tools-list] [virt-manager] [PATCHv2] urlfetcher: Add support for FTP authentication

2018-04-24 Thread Cole Robinson
On 04/18/2018 09:23 AM, Radostin Stoyanov wrote: > From: Mark Hamzy > > If --location is an ftp url with a username and password > then virt-install fails to install with an error: > ERROR Error validating install location: Opening URL u failed: 530 Login > incorrect.. > --- > This is a tweaked v

Re: [virt-tools-list] PATCH: Allow using sysctl for some systems, starting with OpenBSD

2018-04-26 Thread Cole Robinson
CCing rjones since this is a virt-what patch but it's not obvious from the subject - Cole On 04/25/2018 10:45 AM, j...@jasper.la wrote: > Hi, > > OpenBSD lacks /proc, so some of the detection mechanisms in virt-what > don't work there. However sysctl is available and could be used instead > in t

Re: [virt-tools-list] [virt-manager PATCH 2/2] cli: stop forking into the background

2018-04-30 Thread Cole Robinson
On 04/30/2018 08:33 AM, Daniel P. Berrangé wrote: > The behaviour whereby virt-manager forks into the background was added > way back in: > > commit 99c92b9471a6a55859307071aa4a0e712991f158 > Author: Daniel P. Berrange > Date: Mon Sep 10 20:10:20 2007 -0400 > > Refactor startup to dr

Re: [virt-tools-list] [virt-manager PATCH 1/2] cli: remove unused --spice-disable-auto-usbredir arg

2018-04-30 Thread Cole Robinson
On 04/30/2018 08:33 AM, Daniel P. Berrangé wrote: > This functionality was removed in: > > commit c9b2ec163f15f41fe5010b7b1c215f6c204d93a6 > Author: Cole Robinson > Date: Fri Mar 16 14:38:22 2018 -0400 > > preferences: Add UI for disabling spice usb autored

Re: [virt-tools-list] [virt-manager PATCH 2/2] cli: stop forking into the background

2018-04-30 Thread Cole Robinson
On 04/30/2018 12:19 PM, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 12:12:08PM -0400, Cole Robinson wrote: >> On 04/30/2018 08:33 AM, Daniel P. Berrangé wrote: >>> The behaviour whereby virt-manager forks into the background was added >>> wa

Re: [virt-tools-list] [PATCH] Chagne most URIs to use https:// instead of http://

2018-04-30 Thread Cole Robinson
On 04/30/2018 08:56 AM, Daniel P. Berrangé wrote: > All URLs were checked to see if they supported https://, those which did > were converted. > > Signed-off-by: Daniel P. Berrangé > --- > HACKING.md | 4 +- > README.md| 6 +-- > data/virt-manage

Re: [virt-tools-list] [virt-manager PATCH] git: add a git publish configuration file

2018-04-30 Thread Cole Robinson
On 04/24/2018 02:11 PM, Daniel P. Berrangé wrote: > Provide a config file for git-publish that sets the right mailing list > and patch subject prefix. > > Signed-off-by: Daniel P. Berrangé > --- > .gitpublish | 4 > 1 file changed, 4 insertions(+) > create mode 100644 .gitpublish > > diff

Re: [virt-tools-list] [virt-manager PATCH 2/2] cli: stop forking into the background

2018-05-01 Thread Cole Robinson
On 05/01/2018 04:01 AM, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 12:47:38PM -0400, Cole Robinson wrote: >> On 04/30/2018 12:19 PM, Daniel P. Berrangé wrote: >>> On Mon, Apr 30, 2018 at 12:12:08PM -0400, Cole Robinson wrote: >>>> On 04/30/2018 08:3

Re: [virt-tools-list] [virt-manager PATCH 2/2] cli: stop forking into the background

2018-05-01 Thread Cole Robinson
On 05/01/2018 09:23 AM, Daniel P. Berrangé wrote: > On Tue, May 01, 2018 at 09:05:49AM -0400, Cole Robinson wrote: >> On 05/01/2018 04:01 AM, Daniel P. Berrangé wrote: >>> On Mon, Apr 30, 2018 at 12:47:38PM -0400, Cole Robinson wrote: >>>> On 04/30/2018 12:19 PM, Dani

Re: [virt-tools-list] [virt-manager PATCH v4] Redesign OS distro selection UI to be faster to use

2018-05-01 Thread Cole Robinson
On 05/01/2018 07:51 AM, Daniel P. Berrangé wrote: > The current OS distro selection UI is fairly cumbersome to use. First > you need to decide on a variant, then decide a distro and then look for > the version you want. The list is filtered by default so only a subset > of OS are displayed. So for

[virt-tools-list] dropping some uncommon features from virt-manager/virt-install

2018-05-01 Thread Cole Robinson
Hi all, I'd like to drop some uncommonly used features from virt-manager/virt-install. Comments welcome * non-virDomainOpenConsole serial console in virtManager/serialcon.py. qemu, libxl, bhyve, lxc all support this API, qemu since libvirt 0.8.6 in Nov 2010. Directly connecting to /dev/ptsX only

Re: [virt-tools-list] Eideticom NVMe devices not showing in virt-manager

2018-05-15 Thread Cole Robinson
On 05/15/2018 08:53 AM, Stephen Bates wrote: > Hi All > > We are testing our NVMe devices in virtualized environments and noticed that > the vendor name and device id (as decoded by pci-ids) is not showing up in > virt-manager in the add hardware list. We are running Bionic Beaver on the > host

Re: [virt-tools-list] Eideticom NVMe devices not showing in virt-manager

2018-05-16 Thread Cole Robinson
On 05/16/2018 12:42 PM, Stephen Bates wrote: > Hi Cole > > Thanks for the response! > >>virt-manager/libvirt asks libpciaccess for this info, > > Do you have a pointer to the code for this? > libvirt.git src/node_device/node_device_udev.c, search for pci_get_strings, but you'll probably w

Re: [virt-tools-list] [PATCH 0/4] virtinst: Update SUSE media detection

2018-05-16 Thread Cole Robinson
On 05/07/2018 05:39 PM, Charles Arnold wrote: > Fixes and adjustments for detecting SUSE media. > > Charles Arnold (4): > Create shared function _split_version from _split_rhel_version > Use split_version method to get version and update > Use wildcard to detect 'openSUSE Leap'. > Make Sus

Re: [virt-tools-list] [Patch] Missing translation in de.po for the "Kernel Options:" string

2018-06-05 Thread Cole Robinson
On 05/31/2018 01:39 PM, Charles Arnold wrote: >>From 56a94827f4f82b35646063dd68ec74cce3266e80 Mon Sep 17 00:00:00 2001 > From: Charles Arnold > Date: Thu, 31 May 2018 11:25:46 -0600 > Subject: [PATCH 1/1] Missing translation for the "Kernel Options:" string > > --- > po/de.po | 2 +- > 1 file ch

Re: [virt-tools-list] [virt-manager PATCH] numatune: fix validate_cpuset regexp

2018-06-05 Thread Cole Robinson
On 05/22/2018 01:07 PM, Pavel Hrdina wrote: > Character '-' needs to be escaped in a set of characters. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1566818 > > Signed-off-by: Pavel Hrdina > --- > > Pushed under trivial rule. > > virtinst/domain/numatune.py | 2 +- > 1 file chang

Re: [virt-tools-list] [virt-manager] [PATCH 0/2] Integrate codespell_dict

2018-06-05 Thread Cole Robinson
On 05/21/2018 03:42 PM, Radostin Stoyanov wrote: > This patch series extends the pull request from Stefan [1] by fixing > a few more spelling mistakes in the comments, and integrate codespell > to setup.py > > [1] https://github.com/virt-manager/virt-manager/pull/31 > > Radostin Stoyanov (1): >

Re: [virt-tools-list] [PATCH virt-manager] cli: Add --network mtu.size=X option

2018-06-06 Thread Cole Robinson
On 06/05/2018 04:56 PM, Anya Harter wrote: > This maps to interface XML like: > > > > > > Signed-off-by: Anya Harter Thanks for the patch! One comment in line below > --- > tests/cli-test-xml/compare/virt-install-many-devices.xml | 1 + > tests/clitest.py

Re: [virt-tools-list] [PATCH v2 virt-manager] cli: Add --network mtu.size=X option

2018-06-06 Thread Cole Robinson
One minor bit: when adding a v2, typical format is [PATCH virt-manager v2] ... Doesn't impact the patch content though. On 06/06/2018 10:07 AM, Anya Harter wrote: > This maps to interface XML like: > > > > > > Signed-off-by: Anya Harter > --- > tests/cli-test-xml/compare/vir

Re: [virt-tools-list] [PATCH v2 6/6] details: show TPM device model and allow updating it

2018-06-11 Thread Cole Robinson
On 06/08/2018 05:42 PM, Stefan Berger wrote: > Show the TPM device model and allow updating it. If a TPM 1.2 has been > chosen, we only allow the TIS interface to be selected. In case of a > TPM 2.0 we also enable the choice of the CRB interface. > Patches look good, thanks. One question here tho

Re: [virt-tools-list] [PATCH virt-manager] cli: Add --disk driver.copy_on_read=on option

2018-06-11 Thread Cole Robinson
On 06/07/2018 10:45 AM, Anya Harter wrote: > This maps to disk XML like: > > > > > > Signed-off-by: Anya Harter > --- > tests/cli-test-xml/compare/virt-install-many-devices.xml | 1 + > tests/clitest.py | 2 +- > virtinst/cli.py

Re: [virt-tools-list] [PATCH virt-manager] cli: Add --disk geometry attribute options

2018-06-11 Thread Cole Robinson
On 06/07/2018 11:29 AM, Anya Harter wrote: > Attribute options are: > - geometry.cyls=W > - geometry.heads=X > - geometry.secs=Y > - geometry.trans=Z > > This maps to disk XML like: > > > > > > Signed-off-by: Anya Harter Thanks, pushed now - Cole

Re: [virt-tools-list] [PATCH virt-manager] cli: add codec support

2018-06-11 Thread Cole Robinson
Thanks, I pushed with the following changes: - Add --sound to the title to make it more clear On 06/11/2018 11:48 AM, Anya Harter wrote: > Add codec support to virt-install so that it can accommodate > multiple instances of codec configuration. > > The commandline argument: > > --sound codec0

Re: [virt-tools-list] [PATCH v2 6/6] details: show TPM device model and allow updating it

2018-06-11 Thread Cole Robinson
On 06/11/2018 12:00 PM, Stefan Berger wrote: > On 06/11/2018 11:54 AM, Cole Robinson wrote: >> On 06/08/2018 05:42 PM, Stefan Berger wrote: >>> Show the TPM device model and allow updating it. If a TPM 1.2 has been >>> chosen, we only allow the TIS interface to be sel

Re: [virt-tools-list] [PATCH] tpm: allow hotplug operation so error is reported by libvirt

2018-06-12 Thread Cole Robinson
On 06/12/2018 08:52 AM, Stefan Berger wrote: > Perform a hotplug operation so that we get the error notification > about unsupported TPM hotplug operation and we can alert the user > that the change will only take effect upon domain shutdown. > > Signed-off-by: Stefan Berger > --- > virtManager/

Re: [virt-tools-list] [PATCH 1/3] virtinst: allow adding host network devices to LXC containers

2018-06-19 Thread Cole Robinson
On 06/15/2018 05:29 AM, Lubomir Rintel wrote: > Signed-off-by: Lubomir Rintel > --- > man/virt-install.pod | 4 > tests/xmlparse-xml/change-hostdevs-in.xml | 5 + > tests/xmlparse-xml/change-hostdevs-out.xml | 5 + > tests/xmlparse.py |

Re: [virt-tools-list] [virt-manager] [PATCH 1/4] libvirtenummap: Map state vals of agent event to libvirt enum names

2018-06-26 Thread Cole Robinson
On 06/24/2018 11:46 PM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > virtManager/libvirtenummap.py | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/virtManager/libvirtenummap.py b/virtManager/libvirtenummap.py > index eaad0374..71e4a5eb 100644 > --- a/virtM

Re: [virt-tools-list] [virt-manager] [PATCH 3/4] ui: details: Add ui for showing the state of channel in next patch

2018-06-26 Thread Cole Robinson
On 06/24/2018 11:46 PM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > ui/details.ui | 25 + > virtManager/details.py | 1 + > 2 files changed, 26 insertions(+) > > diff --git a/ui/details.ui b/ui/details.ui > index 3018354b..13b71aeb 100644 > --- a/ui/details.ui

Re: [virt-tools-list] [virt-manager] [PATCH 2/4] Output the qemu guest agent lifecycle events in debug mode

2018-06-26 Thread Cole Robinson
On 06/24/2018 11:46 PM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > virtManager/connection.py | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/virtManager/connection.py b/virtManager/connection.py > index 76e78c49..0b83bccf 100644 > --- a/virtManager/connection.py > +++ b/v

Re: [virt-tools-list] [virt-manager PATCH] virtinst: Remove only auto-generated channel source path

2018-06-28 Thread Cole Robinson
On 06/28/2018 10:58 AM, Pavel Hrdina wrote: > In attempt to fix https://bugzilla.redhat.com/show_bug.cgi?id=1270696 > this code was introduced but it removes the path for all channel > devices. We need to limit it only to the devices that have > auto-generated source path. > > Resolves: https://b

Re: [virt-tools-list] [virt-manager] [PATCH 2/4] Output the qemu guest agent lifecycle events in debug mode

2018-07-03 Thread Cole Robinson
On 06/30/2018 01:41 AM, Lin Ma wrote: > > > On 06/27/2018 05:39 AM, Cole Robinson wrote: >> On 06/24/2018 11:46 PM, Lin Ma wrote: >>> Signed-off-by: Lin Ma >>> --- >>>   virtManager/connection.py | 10 ++ >>>   1 file changed

Re: [virt-tools-list] libvirt profiles (a.k.a. virtuned) design ideas draft

2018-07-03 Thread Cole Robinson
Nice work on the document! I'll duplicate the docs here and comment in-line, might help to get more eyeballs. On 06/20/2018 09:15 AM, Martin Kletzander wrote: > After some discussion with people from various management apps we > decided to try and create something that would help with common, > d

Re: [virt-tools-list] [virt-manager] [PATCH v2 0/4] Track the state of virtio channels

2018-07-12 Thread Cole Robinson
On 07/04/2018 04:10 AM, Lin Ma wrote: > v1->v2: > * new patch 1/4 for adding callback parameter to _add_domain_xml_event. > * combine original patch 3/4 and patch 4/4 to new patch 4/4. > * avoid pylint warn. > * Register agent events through _add_domain_xml_event. > > Lin Ma (4): > connection: A

Re: [virt-tools-list] [virt-manager PATCH 1/5] details: Show attached disk info in sata, ide and floppy controller page

2018-07-31 Thread Cole Robinson
On 07/18/2018 06:00 AM, Lin Ma wrote: Reflect controllers <-> disks mapping relationship for not only scsi, But other storage controllers. As a bonus, These controllers are not allowed to be removed if there are disks attached to them. Signed-off-by: Lin Ma --- virtManager/details.py | 2 +-

Re: [virt-tools-list] [virt-manager PATCH 3/5] details: Disallow removing virtio-serial controller if devices attach to it

2018-07-31 Thread Cole Robinson
On 07/18/2018 06:00 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- virtManager/details.py | 13 + 1 file changed, 13 insertions(+) diff --git a/virtManager/details.py b/virtManager/details.py index e3edbe86..00e18949 100644 --- a/virtManager/details.py +++ b/virtManager/details.py @

[virt-tools-list] [PATCH virt-viewer] spec: Remove outdated bits

2018-07-31 Thread Cole Robinson
Group, buildroot cleanup, and defattr are not needed on RHEL6 and later Signed-off-by: Cole Robinson --- mingw-virt-viewer.spec.in | 10 -- virt-viewer.spec.in | 2 -- 2 files changed, 12 deletions(-) diff --git a/mingw-virt-viewer.spec.in b/mingw-virt-viewer.spec.in index

Re: [virt-tools-list] [virt-manager PATCH 4/5] details: Fix the tooltip error on config-remove

2018-08-05 Thread Cole Robinson
isor does not support to removing this device" Thanks for the bug report, but anytime you are duplicating the same line of code in 17 different places should be a hint that it can likely be centralized. I'm pushing this instead. Thanks, Cole commit 5212ab992e49faa4f8e9cdce0062d918f2

Re: [virt-tools-list] [virt-manager PATCH 5/5] details: Set tooltip on config-remove while it's not available

2018-08-05 Thread Cole Robinson
break +if can_remove is False: +tooltip = _("Channels or Consoles are attaching to it") Same as above self.widget("config-remove").set_sensitive(can_remove) self.widget("config-remove").set_tooltip_text(too

Re: [virt-tools-list] Virt-manager cuts off bottom of vm console

2018-08-07 Thread Cole Robinson
On 08/01/2018 01:48 AM, Eric Fort wrote: I ssh into a physical machine running Ubuntu 18.04 to manage vm’s running under kvm. To access the console on these machines or to build new machines from an install iso I use the console of whichever vm I’m working with. Myself and my team find this di

Re: [virt-tools-list] [virt-manager] [RFC] About showing domain interfaces's ip address in details page

2018-08-08 Thread Cole Robinson
On 08/06/2018 08:10 AM, Lin Ma wrote: Hi all, I want to write patches to show ip addresses in virt-manager, I post the idea here to get some suggestions and ideas. The below are my thoughts. I'd like to define a function in class vmmDomain in virtManager/domain.py. The function name is 'interfa

Re: [virt-tools-list] [virt-manager PATCH v2] details: Use _disable_device_remove helper to set the remove tooltip

2018-08-08 Thread Cole Robinson
On 08/05/2018 05:37 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- virtManager/details.py | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) Thanks, pushed now - Cole ___ virt-tools-list mailing list virt-tools-list@redh

Re: [virt-tools-list] [PATCH] details: ADD checkbox to plug/unplug network interface

2018-08-21 Thread Cole Robinson
On 08/17/2018 04:53 AM, Pavel Hrdina wrote: On Thu, Aug 16, 2018 at 05:30:31PM +0200, Simon Kobyda wrote: Hardware Details -> NIC of every VM should now contain checkbox for interface's link state. This checkbox edits domain's XML by changing . If XML doesn't contain this tag, virt manager assum

Re: [virt-tools-list] how did you guys calculate cpu and memory consumtion in virt-mangaer

2018-08-28 Thread Cole Robinson
On 08/27/2018 08:14 AM, Bahram Aghaei wrote: Hello I was wonder how did you calculate cpu and memory consumption in virt-manager? is it by using virsh ? since it just gives actual memory and RSS. That would be nice you send me any documentation or any other typo of guide. It's basically a co

Re: [virt-tools-list] [PATCH 0/2] Add support for disk discard and detect zeroes options

2018-09-04 Thread Cole Robinson
On 08/23/2018 07:35 PM, Povilas Kanapickas wrote: This patch series exposes the disk/driver/@discard and disk/driver/@detect_zeroes attributes which were previously missing. Povilas Kanapickas (2): details: Add support for disk discard option details: Add support for disk detect zeroes opt

Re: [virt-tools-list] [PATCH 01/10] uitests: Improve error message caused by another virt-manager being open

2018-09-04 Thread Cole Robinson
iewing the rest of your patches commit 40461c58efbdd3435102d299da025ecf46089c6a (HEAD -> master) Author: Cole Robinson Date: Tue Sep 4 12:36:50 2018 -0400 tests: uitests: Fail if virt-manager is already running Thanks, Cole ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH 03/10] uitests: Don't fail when running on older libvirt versions

2018-09-04 Thread Cole Robinson
83a9e613e9fa7d7c7d9ac9b227a8a535618cadb3 Author: Cole Robinson Date: Fri Aug 31 16:47:10 2018 -0400 tests: uitests: Fix breakage Signed-off-by: Povilas Kanapickas --- tests/uitests/addhardware.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/uitests/addhardware.py b/tests/uitests

Re: [virt-tools-list] [PATCH 00/10] Improve and fix UI tests

2018-09-04 Thread Cole Robinson
On 09/01/2018 06:15 PM, Povilas Kanapickas wrote: The following patch series fixes a bunch of small issues in UI tests that made them a little more brittle than needed or possibly outright broken. I'm a new contributor, likely missed something and my environment is probably different than what th

Re: [virt-tools-list] [PATCH 03/10] uitests: Don't fail when running on older libvirt versions

2018-09-05 Thread Cole Robinson
On 09/04/2018 07:26 PM, Povilas Kanapickas wrote: On 04/09/2018 20:21, Cole Robinson wrote: On 09/01/2018 06:21 PM, Povilas Kanapickas wrote: Instead of completely failing test when older libvirt is used, we can verify the error message instead. Actually this is fixed in git already, I

Re: [virt-tools-list] [virt-manager PATCH 0/2] Add support for disk discard option disk detect zeroes option while adding disk

2018-09-05 Thread Cole Robinson
On 09/05/2018 04:15 AM, Lin Ma wrote: Lin Ma (2): addhardware: Add support for disk discard option addhardware: Add support for disk detect zeroes option virtManager/addhardware.py | 10 ++ 1 file changed, 10 insertions(+) Pushed with some minor whitespace changes, thanks BT

Re: [virt-tools-list] [virt-manager PATCH 0/2] show ip in details page of domain interface

2018-09-05 Thread Cole Robinson
ove a few things: tweak the UI, handle errors, cache results better, and open it up to work on more hypervisor drivers. Please give it a try and make sure it still meets your usecases: commit b4b7c7b5203dac9c5583b130bb8808d7a0b528fd (HEAD -> ip) Author: Cole Robinson Date: Tue Sep 4 19:02

Re: [virt-tools-list] [virt-manager PATCH 0/2] Add support for disk io mode option while adding disks

2018-09-06 Thread Cole Robinson
On 09/06/2018 03:49 AM, Lin Ma wrote: Lin Ma (2): addhardware: Use consistent combo init for disk io mode option addhardware: Add support for disk io mode option ui/addhardware.ui | 32 virtManager/addhardware.py | 12 virtManager/

Re: [virt-tools-list] [virt-manager PATCH 3/3] Try to get ip of vm's nic only when the vm is active

2018-09-06 Thread Cole Robinson
On 09/06/2018 03:46 AM, Lin Ma wrote: Signed-off-by: Lin Ma --- virtManager/details.py | 15 +-- virtManager/domain.py | 4 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/virtManager/details.py b/virtManager/details.py index 0d02805f..64bed185 100644 --- a

Re: [virt-tools-list] [virt-manager PATCH 0/2] show ip in details page of domain interface

2018-09-06 Thread Cole Robinson
On 09/06/2018 03:07 AM, Lin Ma wrote: On 09/06/2018 03:13 AM, Cole Robinson wrote: On 08/31/2018 06:37 AM, Lin Ma wrote: Uses lease, agent and arp to try to get ipv4 and ipv6 address of given interface Lin Ma (2):    domain: Add function interface_addresses to return ipv4 and ipv6

Re: [virt-tools-list] virt-install: Add warn if 'single-use' options are defined multiple times?

2018-10-01 Thread Cole Robinson
5eb5e1a50ae136511c43dc2e0ae50786bdc169c.1538414182.git.crobi...@redhat.com> From: Cole Robinson Date: Mon, 1 Oct 2018 13:14:43 -0400 Subject: [PATCH virt-manager] cli: Merge multiple instances of single use opts So --memory 123,maxmem=456 --memory 555 is equivalent to --memory 555,maxmem=45 S

Re: [virt-tools-list] [PATCH] cli: add memory backing access_mode & source_type

2018-10-01 Thread Cole Robinson
On 09/17/2018 06:59 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Allow to set some memory backing options, ex: --memorybacking access_mode=shared,source_type=anonymous Signed-off-by: Marc-André Lureau --- .../cli-test-xml/compare/virt-install-singleton-config-2.xml | 4 ++

Re: [virt-tools-list] Nested virtualization

2018-10-01 Thread Cole Robinson
On 09/28/2018 12:34 PM, na...@secmail.pro wrote: Hello. Nested virtualization lags and it have many errors for me. I have a Host (L0) with libvirt(virt-manager) I have there a VM (L1) and I want to run in L1 a Virtual Box machine (L2). But I get errors while installing Windows in L2. Windows inst

Re: [virt-tools-list] Virt-manager: Restricted networks

2018-10-02 Thread Cole Robinson
On 10/02/2018 08:50 AM, Olivier Léobal wrote: Hello, 'Isolated' networks created in VMM (I’m running 1.4.3) still connect to the host (as gateway). Is it possible to avoid this? It is my understanding that QEMU provides a 'restrict' option for that, but I don't understand it well, and can’t f

Re: [virt-tools-list] [virt-manager gui feature request] check box for "locked" memory backing

2018-10-02 Thread Cole Robinson
On 09/19/2018 05:57 AM, Joachim Wagner wrote: While various cli options for memory backing have been introduced in 2014, the virt-manager GUI doesn't offer any memory options other than current and maximum allocation under open -> view -> details -> memory. The "locked" memory backing option is p

Re: [virt-tools-list] [ [PATCH 1/3] cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support

2018-10-02 Thread Cole Robinson
On 09/25/2018 05:12 AM, Lin Ma wrote: Enable the managed or unmanaged PR configuration to enable SCSI persistent reservation for LUN Passthrough. Signed-off-by: Lin Ma --- man/virt-install.pod| 13 + .../compare/virt-install-many-devices.xml

Re: [virt-tools-list] [ [PATCH 0/3] Add SCSI persistent reservation support for LUN Passthrough

2018-10-02 Thread Cole Robinson
On 09/26/2018 08:36 AM, Michal Privoznik wrote: On 09/25/2018 11:12 AM, Lin Ma wrote: Lin Ma (3): cli: disk: add pr.managed=, pr.type=, pr.path= and pr.mode= support details: Add disk pr.managed and pr.path options to support SCSI PR addhardware: Add disk pr.managed and pr.path options

Re: [virt-tools-list] [PATCH] cli: add memory backing access_mode & source_type

2018-10-02 Thread Cole Robinson
On 10/01/2018 02:53 PM, Marc-André Lureau wrote: Hi On Mon, Oct 1, 2018 at 9:20 PM Cole Robinson wrote: On 09/17/2018 06:59 AM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Allow to set some memory backing options, ex: --memorybacking access_mode=shared,source_type=anonymous

Re: [virt-tools-list] [virt-manager PATCH] osinfo: warn when using deprecated osinfo IDs

2018-10-02 Thread Cole Robinson
On 10/02/2018 07:53 AM, Pino Toscano wrote: At some point in the future it could be a good idea to drop the _aliases mapping altogether; it will be hard to do so, in case the users are not informed that they are using a deprecated ID. I had a similar thought just a few days ago! Signed-off-b

Re: [virt-tools-list] [libvirt] question about syntax of storage volume element

2018-10-02 Thread Cole Robinson
On 10/02/2018 10:53 AM, Jim Fehlig wrote: On 10/2/18 5:13 AM, Pavel Hrdina wrote: On Mon, Oct 01, 2018 at 02:28:09PM -0400, Cole Robinson wrote: On 09/28/2018 12:54 AM, Jim Fehlig wrote: I've attempted to use virt-manager to create a new VM that uses a volume from an rbd-based network

[virt-tools-list] RFC: virt-manager: removing interface object UI

2018-10-03 Thread Cole Robinson
Hi all, I'd like to remove the object UI from virt-manager. This is Edit->Connection Details->Interfaces, the bits that allow starting/stopping/deleting/creating host network interface configurations like bridges, bonds, vlans, and ethernet/wifi configs https://imgur.com/a/iyYXawV https://i

Re: [virt-tools-list] virt-install: Add warn if 'single-use' options are defined multiple times?

2018-10-04 Thread Cole Robinson
On 10/04/2018 12:29 PM, Mark Kanda wrote: On 10/1/2018 12:16 PM, Cole Robinson wrote: On 09/14/2018 04:28 PM, Mark Kanda wrote: Hi all, I recently discovered, for 'single-use' command line options, virt-install silently ignores all but the last definition. For example, if the co

Re: [virt-tools-list] Recommendation for improvement/feature request of virt-manager

2018-10-05 Thread Cole Robinson
On 10/03/2018 07:03 PM, sc...@mailbox.org wrote: Hello together, in first - thanks to all of you for your great work! I have just a small feature request for virt-manager: Unfortunately it is not possible yet to block guests public internet access in the guest machine settings (= NIC settings

Re: [virt-tools-list] virt-install: Add warn if 'single-use' options are defined multiple times?

2018-10-05 Thread Cole Robinson
On 10/04/2018 04:41 PM, Mark Kanda wrote: On 10/4/2018 11:55 AM, Cole Robinson wrote: On 10/04/2018 12:29 PM, Mark Kanda wrote: On 10/1/2018 12:16 PM, Cole Robinson wrote: On 09/14/2018 04:28 PM, Mark Kanda wrote: Hi all, I recently discovered, for 'single-use' command line opti

Re: [virt-tools-list] [libvirt] question about syntax of storage volume element

2018-10-05 Thread Cole Robinson
On 10/02/2018 01:09 PM, Jim Fehlig wrote: On 10/2/18 9:27 AM, Cole Robinson wrote: On 10/02/2018 10:53 AM, Jim Fehlig wrote: On 10/2/18 5:13 AM, Pavel Hrdina wrote: On Mon, Oct 01, 2018 at 02:28:09PM -0400, Cole Robinson wrote: On 09/28/2018 12:54 AM, Jim Fehlig wrote: I've attempted t

Re: [virt-tools-list] RFC: virt-manager: removing interface object UI

2018-10-05 Thread Cole Robinson
On 10/05/2018 11:13 AM, Laine Stump wrote: On 10/03/2018 04:23 PM, Cole Robinson wrote: Hi all, I'd like to remove the object UI from virt-manager. This is Edit->Connection Details->Interfaces, the bits that allow starting/stopping/deleting/creating host network interface configur

<    1   2   3   4   5   6   7   8   9   10   >