Re: [virt-tools-list] [libvirt] Usability Enhancement: Import/Export VMs GUI

2016-03-10 Thread Cole Robinson
On 03/10/2016 02:29 AM, Martin Kletzander wrote: > On Fri, Mar 04, 2016 at 04:23:18PM +, ban...@openmailbox.org wrote: >> The single most important usability feature missed by our less technical >> users who migrate from VirtualBox is a one click import/export of VMs >> and their config settin

Re: [virt-tools-list] [PATCH v2 5/5] virt-manager: add opengl graphics option

2016-03-10 Thread Cole Robinson
On 03/10/2016 12:10 PM, Marc-André Lureau wrote: > Hi Cole > > - Original Message - >> On 03/04/2016 06:31 AM, Marc-André Lureau wrote: >>> From: Marc-André Lureau >>> >>> Add a OpenGl checkbox to the Spice graphics option. >>> >>> Signed-off-by: Marc-André Lureau >>> --- >>> ui/gfxdeta

Re: [virt-tools-list] [PATCH] test: Add missing test item to cover the code adding by f11eb00

2016-03-11 Thread Cole Robinson
On 03/11/2016 04:31 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > tests/virtconvtest.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/virtconvtest.py b/tests/virtconvtest.py > index 1acfccc..b1d7f9f 100644 > --- a/tests/virtconvtest.py > +++ b/tests/virtconvtest.py > @@ -9

Re: [virt-tools-list] [virt-manager PATCH] virt-install: concatenate all extra-args argument

2016-03-19 Thread Cole Robinson
On 03/18/2016 04:08 AM, Pavel Hrdina wrote: > So far we used only the last --extra-args argument from virt-install > command line, but it makes more sense to use all occurrences of > --extra-args and pass them to kernel. > > Signed-off-by: Pavel Hrdina > --- > tests/cli-test-xml/compare/virt-ins

Re: [virt-tools-list] enable issues here: https://github.com/virt-manager/virt-manager

2016-03-20 Thread Cole Robinson
On 03/20/2016 05:20 PM, Ivan Brewis wrote: > Hi > Hi Ivan > Tool looks great! But Ubuntu install is version 0.9.5, Git looks like version > 1.3.2 is almost ready. > > Please enable issues in Github to move this project forward. The readme and > other areas could use some help which others may

Re: [virt-tools-list] Virtual machine manager

2016-03-22 Thread Cole Robinson
On 03/22/2016 08:19 AM, Imi8eos 24 wrote: > Hello! > > I am trying to make a cluster with vmm, but I cannot figure out how I can make > a vm to boot another vm. > For example with WOL or some other way. > > Could you assist me please? > No idea if/how wake-on-lan works with qemu, but googling

Re: [virt-tools-list] Which virt-install option is needed to include usb-tablet?

2016-03-24 Thread Cole Robinson
On 03/24/2016 08:03 AM, P.A.M. van Dam (Pascal) wrote: > Goodmorning all, > > I am looking for the virt-install option to include the usb-tablet option > when creating a new graphics based VM. This to prevent the mouse from going > jerky. > > (E.g. resulting in the -device usb-tablet for qemu-k

Re: [virt-tools-list] virt-install console keys

2016-03-24 Thread Cole Robinson
On 03/24/2016 03:17 PM, Richard W.M. Jones wrote: > > I think this may be a question about virsh or libvirt, but anyway .. > > When I do a command like: > > virt-install \ > --name=$tmpname \ > --ram=1024 \ > --os-type=linux --os-variant=$osvariant \ > --arch ppc64le --machine ps

Re: [virt-tools-list] virt-install console keys

2016-03-24 Thread Cole Robinson
On 03/24/2016 03:20 PM, Cole Robinson wrote: > On 03/24/2016 03:17 PM, Richard W.M. Jones wrote: >> >> I think this may be a question about virsh or libvirt, but anyway .. >> >> When I do a command like: >> >> virt-install \ >> --name=$tmpname \ &g

Re: [virt-tools-list] [PATCH] virt-manager: Fix VNC connection on hypervisor without GraphicsFD

2016-04-01 Thread Cole Robinson
I've been on vacation since the 25th, I'll test and review thist on Monday Thanks, Cole On 03/29/2016 06:20 AM, Mikhail Feoktistov wrote: > Hello Cole! > Can you look at this patch? What do you think? > > On 26.03.2016 13:02, Mikhail Feoktistov wrote: >> Function virDomainOpenGraphicsFD() from l

Re: [virt-tools-list] Question about Virt-manager

2016-04-01 Thread Cole Robinson
Hi, questions regarding virt-manager should go to virt-tools-list@redhat.com On 03/27/2016 08:51 AM, Programmingkid wrote: > Hi, I was wondering if it would be possible to start an official port of > Virt-Manager to Mac OS X. If someone did provide the patches needed to run > Virt-Manager on Mac

Re: [virt-tools-list] [PATCH] virt-manager: Fix VNC connection on hypervisor without GraphicsFD

2016-04-07 Thread Cole Robinson
On 03/26/2016 06:02 AM, Mikhail Feoktistov wrote: > Function virDomainOpenGraphicsFD() from libvirt can return -1 > But in this case libvirt-python will raise an exception. > We should handle this case and return -1 as invalid FD. > In commit 5c451b64 Viewer._open() there is a code to open > graphi

Re: [virt-tools-list] virt-clone and a .img file?

2016-04-07 Thread Cole Robinson
On 03/25/2016 04:23 PM, James Okken wrote: > Hi list! > > > > virt-clone’s documentation shows a user should use .img for the > --file parameter for the vHD name of the cloned machine > > > > What format does this file get created in? The original vHD is a .qcow2 file. > > > > Should I

Re: [virt-tools-list] [PATCH] virtinst: Use virtio bus type for disks on pSeries machines

2016-04-09 Thread Cole Robinson
On 04/09/2016 03:46 AM, Shivaprasad G Bhat wrote: > pSeries doesn't support ide and so the default bus type was changed to use the > scsi before. It is now verified that virtio works better on pSeries with > better > performance outcomes. So, change the default to virtio for disks. > > Signed-off

Re: [virt-tools-list] [PATCH 0/2] Virtuozzo hypervisor basic support

2016-04-14 Thread Cole Robinson
On 04/14/2016 04:54 AM, Mikhail Feoktistov wrote: > This patch introduces virtuozzo hypervisor support. > Here we implemented only basic functionality. > User can create/start/stop/delete containers and virtual machies. > Also we allow to change hardware configuration (basic devices) > and connect

Re: [virt-tools-list] Fwd: locked out after preseed install

2016-04-15 Thread Cole Robinson
There's a lot of things that might be going wrong here, and it's unlikely to be virt-install. virbr0 comes from the libvirt default virtual network. Maybe your host IP tables messed with it. do sudo virsh net-destroy default ; sudo virsh net-start default, or try a host reboot. THe VM isn't even

Re: [virt-tools-list] Fwd: locked out after preseed install

2016-04-18 Thread Cole Robinson
On 04/15/2016 08:43 PM, Mario Gummies wrote: > > Hi Cole, hi all, > could login via ssh from the host without preseeding. Thanks, now I know how > the result, I am after, looks like. > Well, then thinking about it. If my preseeding script seems the culprit: > 1) Who should I ask? (guess the d-i,

Re: [virt-tools-list] Fwd: locked out after preseed install

2016-04-18 Thread Cole Robinson
On 04/18/2016 09:53 AM, Mario Gummies wrote: > Hi Cole, hi all, > > > 18.04.2016, 14:00, "Cole Robinson" : >> On 04/15/2016 08:43 PM, Mario Gummies wrote: >>> Hi Cole, hi all, >>> could login via ssh from the host without preseeding. Thanks, n

Re: [virt-tools-list] How to add NVMe device by virt-manager

2016-04-20 Thread Cole Robinson
On 04/19/2016 11:03 PM, Wang Sheng-Hui wrote: > Hello, > > I know that qemu can specify NVMe emulation by "-device nvme". > > I wonder how can I add a NVMe device by virt-manager? Any guides avaiable? > Libvirt doesn't even support it explicitly yet, so no virt-manager support either. You'll ne

Re: [virt-tools-list] [PATCH v2] virtinst: Use virtio bus type for disks on pSeries machines

2016-04-21 Thread Cole Robinson
On 04/21/2016 04:00 AM, Shivaprasad G Bhat wrote: > pSeries doesn't support ide and so was changed to use the scsi. virtio works > better on pSeries with better performance outcomes. Change the default to > virtio for disks > > Signed-off-by: Shivaprasad G Bhat > --- > .../compare/virt-install-p

Re: [virt-tools-list] [PATCH] urlfetcher: Enable Ubuntu 16.04 s390x detection

2016-04-25 Thread Cole Robinson
On 04/25/2016 03:13 AM, Leno Hou wrote: > Signed-off-by: Leno Hou > CC: Kevin Zhao < kevin.zhaosh...@gmail.com> > --- > virtinst/urlfetcher.py | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/virtinst/urlfetcher.py b/virtinst/urlfetcher.py > index 7f9da64..5d3f94e 100644 > --- a

Re: [virt-tools-list] [PATCH V2] urlfetcher: Enable Ubuntu 16.04 s390x detection

2016-04-27 Thread Cole Robinson
I pushed it yesterday actually :) sorry, forgot to send a mail Thanks, Cole On 04/27/2016 01:47 AM, Kevin Zhao wrote: > Hi Cole && Leno, > I have also tested this patch and works fine with me~I think it is a > proper way, could you help to merge patch ? > > 2016-04-26 16:10 GMT+08:00 Leno

Re: [virt-tools-list] [PATCH 3/5] virtinst: add listen=none graphics option

2016-04-29 Thread Cole Robinson
On 04/28/2016 09:31 AM, Pavel Hrdina wrote: > On Thu, Apr 28, 2016 at 02:22:09PM +0200, Marc-André Lureau wrote: >> Add a special listen value to disable any extra display server listening >> socket. This is necessary now that qemu prevents starting a spice+virgl >> VM with listening sockets (until

Re: [virt-tools-list] [PATCH virt-manager] chardev: use pretty type of virtio

2016-05-02 Thread Cole Robinson
On 04/30/2016 02:24 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > We shoud use VirtIO instead of virtio. > > Signed-off-by: Chen Hanxiao > --- > virtManager/addhardware.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virtManager/addhardware.py b/virtManager/addh

Re: [virt-tools-list] [PATCH 1/5] ConnectionInfo: console is active if fd can be provided

2016-05-02 Thread Cole Robinson
port in [None, -1]): > return False > return True > Thanks for the patch. Actually rather than call into libvirt/qemu for this minor check I just dropped console_active entirely: commit 0a1d22f395e86861c3725e37fec9f592a616a4ce Author: Cole Robinson Date: Mon May 2 17

Re: [virt-tools-list] argparse and Python 2.6

2016-05-06 Thread Cole Robinson
On 05/05/2016 10:49 PM, Programmingkid wrote: > I was trying to run virt-clone.py, when I encountered an error. This file > uses argparse. This feature was not added to Python until 2.7. I'm using > Python 2.6. The INSTALL document says python >= 2.6 is needed. The simplest > way to fix this pro

Re: [virt-tools-list] [PATCH v1] virtinst: Use virtio bus type for cdrom disk on s390x

2016-05-07 Thread Cole Robinson
On 05/05/2016 01:59 PM, Leno Hou wrote: > s390x doesn't support scsi and so was changed to use the scsi. virtio works > better on s390x with better performance outcomes. Change the default to > virtio for cdrom disks > Hmm, this is definitely supposed to be bus=virtio, and not bus=scsi with a vir

Re: [virt-tools-list] [PATCH] INSTALL: update Python version requirement to 2.7

2016-05-07 Thread Cole Robinson
On 05/06/2016 10:21 AM, Programmingkid wrote: > The virt-clone file uses the argparse module. This module is only found in > version 2.7 of Python or higher. So update the documentation to indicate > Python 2.7 or higher is required. > > Signed-off-by: John Arbuckle > --- > INSTALL | 2 +- > 1

Re: [virt-tools-list] [PATCH virt-install 1/2] Append '--attach' to virt-viewer for local display if spice gl enabled.

2016-05-07 Thread Cole Robinson
On 05/04/2016 05:33 AM, Lin Ma wrote: > Currently SPICE GL support is local-only, So it needs to attach to the > local display. > > Signed-off-by: Lin Ma > --- > virtinst/cli.py | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/virtinst/cli.py b/virtinst/cli.py > index 8a3f6ae..cff1

Re: [virt-tools-list] argparse and Python 2.6

2016-05-07 Thread Cole Robinson
On 05/06/2016 11:51 AM, Programmingkid wrote: > > On May 6, 2016, at 7:52 AM, Cole Robinson wrote: > >> On 05/05/2016 10:49 PM, Programmingkid wrote: >>> I was trying to run virt-clone.py, when I encountered an error. This file >>> uses argparse. This feature

Re: [virt-tools-list] [PATCH 2/5] virtinst: check minimum qemu/libvirt for spice+gl

2016-05-07 Thread Cole Robinson
On 04/28/2016 08:22 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > virtinst/guest.py | 5 + > virtinst/support.py | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/virtinst/guest.py b/virtinst/guest.py > index ab6dcba..5824e87 100644 > --- a/virtinst/guest

Re: [virt-tools-list] argparse and Python 2.6

2016-05-08 Thread Cole Robinson
On 05/07/2016 10:53 PM, Programmingkid wrote: > > On May 7, 2016, at 7:31 PM, Cole Robinson wrote: > >> On 05/06/2016 11:51 AM, Programmingkid wrote: >>> >>> On May 6, 2016, at 7:52 AM, Cole Robinson wrote: >>> >>>> On 05/05/2016 10:49 PM

Re: [virt-tools-list] [PATCH] INSTALL: Add download links for requirements

2016-05-08 Thread Cole Robinson
On 05/07/2016 11:06 PM, Programmingkid wrote: > It is much easier and faster to give the user the prerequite software links > rather than having them find the software themselves. This patch adds these > links to the INSTALL document. > > Signed-off-by: John Arbuckle > --- > INSTALL | 7 +++

Re: [virt-tools-list] libosinfo version 1.0

2016-05-09 Thread Cole Robinson
On 05/08/2016 11:15 PM, Programmingkid wrote: > I just installed libosinfo 0.2.10 which is a required dependency. When I try > to run virt-manager, I see this error message: > > /Virt-manager/virt-manager/virtinst/osdict.py", line 27, in > gi.require_version('Libosinfo', '1.0') > File "/u

Re: [virt-tools-list] libosinfo version 1.0

2016-05-09 Thread Cole Robinson
On 05/09/2016 10:53 AM, Programmingkid wrote: > > On May 9, 2016, at 10:19 AM, Cole Robinson wrote: > >> On 05/08/2016 11:15 PM, Programmingkid wrote: >>> I just installed libosinfo 0.2.10 which is a required dependency. When I >>> try to run virt-

Re: [virt-tools-list] [PATCH v1] virtinst: set preserve when on_crash in s390x

2016-05-10 Thread Cole Robinson
On 05/10/2016 09:24 AM, Leno Hou wrote: > When booting from empty disk image or none bootdev, its leads > system IPL enter into infinite loop with message on s390x. > This patch sets preserve when on_crash to avoid the loop. > Is this correct behavior, or is this a qemu or guest OS bug? If it's s

Re: [virt-tools-list] [PATCH v1] virtinst: set preserve when on_crash in s390x

2016-05-10 Thread Cole Robinson
On 05/10/2016 12:41 PM, Leno Hou wrote: > On Wed, May 11, 2016 at 12:22 AM, Cole Robinson <mailto:crobi...@redhat.com>> wrote: > > On 05/10/2016 12:16 PM, Leno Hou wrote: > > On Tue, May 10, 2016 at 11:48 PM, Cole Robinson <mailto:crobi...@redhat.com> >

Re: [virt-tools-list] [PATCH v1] virtinst: set preserve when on_crash in s390x

2016-05-10 Thread Cole Robinson
On 05/10/2016 12:16 PM, Leno Hou wrote: > On Tue, May 10, 2016 at 11:48 PM, Cole Robinson <mailto:crobi...@redhat.com>> wrote: > > On 05/10/2016 09:24 AM, Leno Hou wrote: > > When booting from empty disk image or none bootdev, its leads > > system IPL

Re: [virt-tools-list] [PATCH v2] virtinst: set preserve when on_crash in s390x

2016-05-10 Thread Cole Robinson
On 05/10/2016 01:36 PM, Leno Hou wrote: > When booting from empty disk image or none bootdev, its leads > system IPL enter into infinite loop with message on s390x. > This patch sets preserve when on_crash to avoid the loop > > Signed-off-by: Leno Hou > --- > tests/cli-test-xml/compare/virt-inst

Re: [virt-tools-list] Using virt-manager with QEMU in emulation mode

2016-05-10 Thread Cole Robinson
On 05/10/2016 07:36 PM, Programmingkid wrote: > I just finally made virt-manager 1.3.2 run on Mac OS 10.6.8. Is it possible > to make virt-manager manage QEMU when it is used in emulation mode? For > example, could I use QEMU on x86 hardware to manage qemu-system-ppc? Yes, that should work for s

Re: [virt-tools-list] Using virt-manager with QEMU in emulation mode

2016-05-10 Thread Cole Robinson
On 05/10/2016 07:39 PM, Cole Robinson wrote: > On 05/10/2016 07:36 PM, Programmingkid wrote: >> I just finally made virt-manager 1.3.2 run on Mac OS 10.6.8. Is it possible >> to make virt-manager manage QEMU when it is used in emulation mode? For >> example, could I use QE

Re: [virt-tools-list] Using virt-manager with QEMU in emulation mode

2016-05-10 Thread Cole Robinson
On 05/10/2016 07:48 PM, Programmingkid wrote: > > On May 10, 2016, at 7:41 PM, Cole Robinson wrote: > >> On 05/10/2016 07:39 PM, Cole Robinson wrote: >>> On 05/10/2016 07:36 PM, Programmingkid wrote: >>>> I just finally made virt-manager 1.3.2 run on Mac OS

Re: [virt-tools-list] Does virt-manager support virt-clone "like" ?

2016-05-13 Thread Cole Robinson
On 05/13/2016 12:18 PM, Leno Hou wrote: > Hi everyone, > > *As we all know, we can use virt-clone as following cases.* > > * virt-clone from disk to image > >#virt-clone --original ubuntu --name ubuntu-image1 --file > /var/lib/libvirt/images/ubuntu1.qcow2 > > * virt-clone from d

Re: [virt-tools-list] connection driver for QEMU

2016-05-13 Thread Cole Robinson
On 05/12/2016 11:15 AM, Programmingkid wrote: > I'm having problems with virt-manager connecting to QEMU. I installed libvirt > 1.3.4 with no argument added to configure. When I try to make a connection > with the QEMU/KVM option, I see this error message: File > "/Library/Frameworks/Python.fram

Re: [virt-tools-list] [virt-manager PATCH] seclabel: add a validation for security type static

2016-05-13 Thread Cole Robinson
On 05/13/2016 01:19 PM, Pavel Hrdina wrote: > Commit 510d28e3 refactored the seclabel code and one check was lost. > Add the check back into the code. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1298031 > > Signed-off-by: Pavel Hrdina > --- > virtinst/seclabel.py | 5 + > 1 fi

Re: [virt-tools-list] [virt-manager PATCH] create: skip continue-install restart if user destroys VM

2016-05-13 Thread Cole Robinson
On 05/13/2016 11:46 AM, Pavel Hrdina wrote: > Commit 159e4af1 fixed a case where VM was started if user destroyed VM > while installing it. This moves the code before we check whether we > need to restart the VM in order to continue in installation (windows > requires that). > > Resolves: https:/

Re: [virt-tools-list] [PATCH 0/5] virt-manager: more spice+virgl support

2016-05-19 Thread Cole Robinson
On 04/28/2016 08:22 AM, Marc-André Lureau wrote: > Hi > > The following new series allows virt-manager to setup and use a > local-only spice & virgl-enabled VM. It depends on qemu 2.6 and > libvirt 1.3.3. > > After this series, to configure a VM for virgl+spice, you can go to > Spice display deta

Re: [virt-tools-list] [virt-manager PATCH] virt-manager: fix --show-domain-creator to not depend on manager window

2016-05-20 Thread Cole Robinson
On 05/20/2016 09:27 AM, Pavel Hrdina wrote: > Commit a0c2fdf4 fixed a bug that there was no way how to close the app. > > The original issue isn't present anymore but reverting that commit isn't > enough. We need to increment/decrement window count while > showing/closing the create window in ord

Re: [virt-tools-list] [virt-manager PATCH] addhardware: don't remove QXL if VNC graphics are configured

2016-05-20 Thread Cole Robinson
On 05/20/2016 12:16 PM, Pavel Hrdina wrote: > Commit 1a6e803a introduced a fix for bogus behavior of QXL+VNC where > there was no cursor visible by disabling this configuration in > virt-manager. We should enable it again because this is a supported > configuration and the bug was actually in QEMU

Re: [virt-tools-list] QEMU/VirtFS user permission on files in shares

2016-05-20 Thread Cole Robinson
Please don't respond to a digest message, the mail content is 90% irrelevant On 05/20/2016 12:46 PM, Sorrillo, Lawrence wrote: > All, > I have been using VirtFS in QEMU for filesystem passthrough. > > I would like files/dirs created on the VirtFS share in the VM to have the > UID/GID of the us

Re: [virt-tools-list] [virt-manager PATCH] ui: remove "Restore Saved Machine..." from File menu of Connection Details

2016-05-31 Thread Cole Robinson
On 05/31/2016 07:16 AM, Pavel Hrdina wrote: > Commit 839ce682 removed deprecated support of save/restore which was replaced > by > managedsave feature. This is a leftover that wasn't removed together with > that > commit. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1340356 > ACK

Re: [virt-tools-list] [PATCH virt-install] virtinst: Add --transient flag.

2016-06-07 Thread Cole Robinson
On 06/02/2016 06:54 AM, Pavel Hrdina wrote: > On Thu, Jun 02, 2016 at 11:27:33AM +0100, Daniel P. Berrange wrote: >> On Thu, Jun 02, 2016 at 12:20:32PM +0200, Pavel Hrdina wrote: >>> On Thu, Jun 02, 2016 at 11:02:27AM +0100, Richard W.M. Jones wrote: On Thu, Jun 02, 2016 at 11:00:16AM +0200, P

Re: [virt-tools-list] [virt-manager PATCH] test: Fix tests with latest libvirt

2016-06-07 Thread Cole Robinson
On 05/28/2016 03:12 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > libvirt commit > b33c14b342e5c2ab91c852ef2032327cb355 > introduce this. > I added compare_check annotations to clitest.py test cases that changed, so we skip them on older libvirt, and pushed Thanks, Cole ___

Re: [virt-tools-list] [PATCH] virtinst: Fix detection of openSUSE tumbleweed media

2016-06-07 Thread Cole Robinson
On 06/03/2016 03:25 PM, Charles Arnold wrote: > With Tumbleweed now part of libosinfo we do not need to default > to openSUSE 13.2 when pointing at the installation media. > > Signed-off-by: Charles Arnold > > diff --git a/virtinst/urlfetcher.py b/virtinst/urlfetcher.py > index e477ee0..692a297

Re: [virt-tools-list] [virt-manager PATCH] create: report an error if storage doesn't exists for import installation

2016-06-07 Thread Cole Robinson
On 06/07/2016 10:21 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1305210 > > Signed-off-by: Pavel Hrdina > --- > virtManager/create.py | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/virtManager/create.py b/virtManager/create.py > index f4f9d05.

Re: [virt-tools-list] [virt-manager PATCH] maint: fix pylint warnings wrong-import-order

2016-06-07 Thread Cole Robinson
On 06/07/2016 11:39 AM, Pavel Hrdina wrote: > standard import "import logging" comes before "from gi.repository import GLib" > > Signed-off-by: Pavel Hrdina hmm I wonder why my pylint doesn't warn about that... but good idea anyways - Cole ___ virt-t

Re: [virt-tools-list] [PATCH] virtinst: Fix detection of openSUSE tumbleweed media

2016-06-07 Thread Cole Robinson
On 06/07/2016 01:07 PM, Charles Arnold wrote: >>>> On 6/7/2016 at 09:08 AM, Cole Robinson wrote: >> On 06/03/2016 03:25 PM, Charles Arnold wrote: >> >> Is there a public URL for tumbleweed that I can add to test_urls.py? > > The tumbleweed repo is found

Re: [virt-tools-list] [virt-manager PATCH] create: report an error if storage doesn't exists for import installation

2016-06-07 Thread Cole Robinson
On 06/07/2016 07:58 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1305210 > > Signed-off-by: Pavel Hrdina > --- > virtManager/create.py | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/virtManager/create.py b/virtManager/create.py > index f4f9d05.

Re: [virt-tools-list] [virt-manager PATCH 1/2] console: fix checkbox to save password if it was loaded from keyring

2016-06-07 Thread Cole Robinson
On 06/07/2016 11:20 AM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1302175 > > Signed-off-by: Pavel Hrdina > --- > virtManager/console.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/virtManager/console.py b/virtManager/consol

Re: [virt-tools-list] [virt-manager PATCH 2/2] console: add support to forget password

2016-06-07 Thread Cole Robinson
On 06/07/2016 10:21 AM, Pavel Hrdina wrote: > If password for console is saved currently there is no way how to tell > virt-manager to forget that password. This patch improves the authentication > page in order to provide a way how to forget password simply by unchecking the > "Save this password

Re: [virt-tools-list] [virt-manager PATCH 3/5] virtinst: prepare XML parsers to handle GIC for ARM

2016-06-11 Thread Cole Robinson
ACK 1-3 - Cole On 06/10/2016 01:30 PM, Pavel Hrdina wrote: > GIC is used instead of APIC on ARM and libvirt allows configure specific > version of GIC for guests. > > Signed-off-by: Pavel Hrdina > --- > tests/xmlparse.py | 1 + > virtinst/domainfeatures.py | 3 ++- > virtinst/domc

Re: [virt-tools-list] [virt-manager PATCH 4/5] virt-install: add a new guest feature GIC for ARM guests

2016-06-11 Thread Cole Robinson
On 06/10/2016 01:30 PM, Pavel Hrdina wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1334857 > > Signed-off-by: Pavel Hrdina > --- > man/virt-install.pod | 5 +++ > .../compare/virt-install-aarch64-kvm-gic.xml | 33 ++ > tests/c

Re: [virt-tools-list] [virt-manager PATCH] details: Show users a clue about where to map UEFI/OVMF path in libvirtd

2016-06-11 Thread Cole Robinson
On 06/11/2016 10:44 AM, Lin Ma wrote: > Signed-off-by: Lin Ma > --- > virtManager/details.py | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/virtManager/details.py b/virtManager/details.py > index 0c369a4..0ac0549 100644 > --- a/virtManager/details.py > +++ b/virtMan

Re: [virt-tools-list] [virt-manager PATCH 5/5] virt-manager: add a new guest feature GIC for AMR guests

2016-06-11 Thread Cole Robinson
Okay, I need to finally truly figure out how all this stuff fits together to try and understand if it makes sense to expose in the GUI. My understanding is that there's 4 pieces of info at play here: - What gic versions can qemu emulate? (available for domain type=qemu) - What gic versions does th

Re: [virt-tools-list] [virt-manager PATCH 4/5] virt-install: add a new guest feature GIC for ARM guests

2016-06-11 Thread Cole Robinson
On 06/11/2016 11:36 AM, Pavel Hrdina wrote: > On Sat, Jun 11, 2016 at 10:58:17AM -0400, Cole Robinson wrote: >> On 06/10/2016 01:30 PM, Pavel Hrdina wrote: >>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1334857 >>> >>> Signed-off-by: Pavel Hrdin

Re: [virt-tools-list] [virt-manager PATCH 4/5] virt-install: add a new guest feature GIC for ARM guests

2016-06-11 Thread Cole Robinson
On 06/11/2016 12:09 PM, Cole Robinson wrote: > On 06/11/2016 11:36 AM, Pavel Hrdina wrote: >> On Sat, Jun 11, 2016 at 10:58:17AM -0400, Cole Robinson wrote: >>> On 06/10/2016 01:30 PM, Pavel Hrdina wrote: >>>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1

Re: [virt-tools-list] [PATCH] Use storage pool lifecycle events

2016-06-14 Thread Cole Robinson
On 06/13/2016 02:25 PM, Jovanka Gulicoska wrote: > --- > virtManager/connection.py | 35 +++ > virtManager/storagelist.py | 5 + > virtManager/storagepool.py | 5 - > 3 files changed, 40 insertions(+), 5 deletions(-) > > diff --git a/virtManager/connecti

Re: [virt-tools-list] [PATCH python] storagelist: code cleanup

2016-06-14 Thread Cole Robinson
On 06/14/2016 05:56 PM, Jovanka Gulicoska wrote: > Remove cb() function calling pool.refresh, instead use pool.refresh > in vmmAsyncJob > --- > virtManager/storagelist.py | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/virtManager/storagelist.py b/virtManager/storagel

Re: [virt-tools-list] [PATCH python v2] Use storage pool lifecycle events

2016-06-14 Thread Cole Robinson
On 06/14/2016 05:52 PM, Jovanka Gulicoska wrote: > Changes since v1: split long lines, remove unnecessary call of tick(), > remove code cleanup > --- > virtManager/connection.py | 37 + > virtManager/storagepool.py | 4 +++- > 2 files changed, 40 insertions(+)

Re: [virt-tools-list] [PATCH] virtinst: Pass Xen machine type to libvirt getDomainCapabilities

2016-06-15 Thread Cole Robinson
On 06/15/2016 11:40 AM, Charles Arnold wrote: On 6/15/2016 at 09:21 AM, Pavel Hrdina wrote: >> On Wed, Jun 15, 2016 at 08:31:42AM -0600, Charles Arnold wrote: >>> Tell libvirt what machine type the user chose for Xen (PV or HVM). >>> Without a type specified, the default is to return the cap

Re: [virt-tools-list] [virt-manager PATCH] tests: fix a testcase failure by --os-variant

2016-06-16 Thread Cole Robinson
On 06/15/2016 10:35 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Current libosinfo release on fedora23 and centos7 > didn't know fedora23. > Change --os-variant fedora22 as a workaroud. > > df1c3e74a introduce this issue. > > Signed-off-by: Chen Hanxiao > --- > tests/clitest.py | 2 +- >

Re: [virt-tools-list] [virt-manager PATCH 0/3] add support to create a XEN guest with uefi

2016-06-16 Thread Cole Robinson
On 06/16/2016 06:23 AM, Pavel Hrdina wrote: > Those patches are small hacks to fix this issue before release. > > We should simplify the domain installation code and unify it a little bit for > both virt-install and virt-manager. The code got way too complicated over the > time and now it's hard

Re: [virt-tools-list] [virt-manager PATCH 5/5] virt-manager: add a new guest feature GIC for AMR guests

2016-06-16 Thread Cole Robinson
On 06/14/2016 08:59 AM, Andrea Bolognani wrote: > I'm CCing Drew so that he can point out any mistakes I might > have made below :) > > On Sun, 2016-06-12 at 11:35 +0200, Pavel Hrdina wrote: >> On Sat, Jun 11, 2016 at 12:04:35PM -0400, Cole Robinson wrote: >>> &

Re: [virt-tools-list] [PATCH virt-install] virtinst: Add --transient flag.

2016-06-17 Thread Cole Robinson
On 06/07/2016 10:07 AM, Cole Robinson wrote: > On 06/02/2016 06:54 AM, Pavel Hrdina wrote: >> On Thu, Jun 02, 2016 at 11:27:33AM +0100, Daniel P. Berrange wrote: >>> On Thu, Jun 02, 2016 at 12:20:32PM +0200, Pavel Hrdina wrote: >>>> On Thu, Jun 02, 2016 at 11:02:

[virt-tools-list] ANNOUNCE: virt-manager 1.4.0 released

2016-06-18 Thread Cole Robinson
(Marc-André Lureau, Cole Robinson) - Note, this isn't enabled by default, and there isn't any GUI bits to enable this, but if it _is_ enabled the virt-manager SPICE viewer will do the right thing. More details: http://blog.wikichoon.com/2016/05/spice-openglvirgl-acceleration

Re: [virt-tools-list] [PATCH python v2] Use storage pool lifecycle events

2016-06-18 Thread Cole Robinson
Okay, I've pushed this patch now with that bit dropped Thanks, Cole On 06/16/2016 10:33 AM, Jovanka Gulicoska wrote: > It doesn't make a difference. I've missed it. > > Thanks, > Jovanka > > On Wed, Jun 15, 2016 at 1:24 AM, Cole Robinson <mailto:crobi...@r

Re: [virt-tools-list] [virt-manager PATCH 0/3] test fixes

2016-07-13 Thread Cole Robinson
On 07/08/2016 12:11 PM, Pavel Hrdina wrote: > I've pushed this series as test breaker fix and trivial fix. > > Pavel Hrdina (3): > tests.testdriver: add usb controller if usbredir is used > tests.xmlparse: fix network test > deviceinterface: disallow using source dev for ethernet interface >

Re: [virt-tools-list] [PATCH 0/5] virtinst: Add --smbios command line option

2016-07-13 Thread Cole Robinson
On 07/12/2016 03:28 PM, Charles Arnold wrote: > This patchset introduces a command line option to pass smbios information to > the guest. It adds an smbios mode sub-element to the guest's os element. The > mode attribute must be specified and is either "emulate" (let the hypervisor > generate all v

Re: [virt-tools-list] No UEFI option in virt-manager 1.3

2016-07-13 Thread Cole Robinson
On 07/08/2016 10:05 PM, Anders Pitman wrote: > Hi, > > My host machine is running Ubuntu 16.04 with libvirt 1.3.1. I've been > administering my VMs using virt-manager over SSH from my laptop. I was using > virt-manager 0.9.5, but noticed some discrepancies with most of the tutorials > out there (h

Re: [virt-tools-list] No UEFI option in virt-manager 1.3

2016-07-13 Thread Cole Robinson
keeping up with important kvm features but still being relatively stable? > Personally I recommend Fedora, I think it's the distro that the largest chunk of virt stack development is performed on. - Cole > //anders > > On Wed, Jul 13, 2016 at 11:47 AM, Cole Robinson <mailt

Re: [virt-tools-list] [PATCH 0/2] virtinst: Pass SMBios information to guest

2016-07-18 Thread Cole Robinson
On 07/14/2016 10:06 AM, Charles Arnold wrote: > This patchset introduces a command line option to pass smbios information to > the guest. It adds an smbios mode sub-element to the guest's os element. The > mode attribute must be specified and is either "emulate" (let the hypervisor > generate all v

Re: [virt-tools-list] [virt-install] Support for capturing guest serial console to a log file?

2016-07-18 Thread Cole Robinson
use of a logfile with chardev backends > Nope, released virt-install doesn't support it, but I just fixed it upstream: commit 322d21251630d16ab6664477c10d7442d9f222e7 Author: Cole Robinson Date: Mon Jul 18 15:03:06 2016 -0400 cli: Add --serial log.file= and l

Re: [virt-tools-list] [c...@centos.org: [Libvirt-ci] Build failed in Jenkins: virt-manager-test » libvirt-fedora-23 #1440]

2016-07-19 Thread Cole Robinson
On 07/19/2016 12:10 PM, Daniel P. Berrange wrote: > It appears that quite a few tests in virt-manager are currently > failing. I'm unclear if this is due to genuine libvirt regressions, > or the tests were relying on undefined behaviour which has now > changed in libvirt > Hmm, I'm not sure eithe

Re: [virt-tools-list] [c...@centos.org: [Libvirt-ci] Build failed in Jenkins: virt-manager-test » libvirt-fedora-23 #1440]

2016-07-20 Thread Cole Robinson
On 07/20/2016 02:56 AM, Pavel Hrdina wrote: > On Tue, Jul 19, 2016 at 01:38:06PM -0400, Cole Robinson wrote: >> On 07/19/2016 12:10 PM, Daniel P. Berrange wrote: >>> It appears that quite a few tests in virt-manager are currently >>> failing. I'm unclear i

Re: [virt-tools-list] Focus getting stuck in viewer

2016-07-26 Thread Cole Robinson
On 07/26/2016 09:01 AM, Chuck Anderson wrote: > After upgrading to Fedora 24, I'm now experiencing a new issue where > the mouse focus keeps getting stuck in the virt-manager viewer. > Keystrokes are sent to the guest VM even though the mouse pointer is > in an adjacent gnome-terminal window (on a

Re: [virt-tools-list] [PATCH] enable zvol creation

2016-07-28 Thread Cole Robinson
On 07/28/2016 07:51 AM, Tristan Helmich wrote: > Hi, > > just a quick patch to allow creation of ZFS zvol via virt-manager. > Please let me know if anything else needs to be changed. > Thanks Tristan, patch looks fine to me, but can you provide XML for an example zfs storage pool and storage vol

Re: [virt-tools-list] [Libvirt-ci] Build failed in Jenkins: virt-manager-test » libvirt-centos-7 #1474

2016-07-29 Thread Cole Robinson
de is just blindly copying the device >name from libosinfo, into the guest XML, but this is not valid >since there's not a 1-1 match between dev names in libosinfo >and device model names in libvirt. > > eg, a name virtio1.0-input in libosinfo maps to > in li

Re: [virt-tools-list] [virt-manager PATCH] snapshot: start snapshot when double-click the item of snapshot list

2016-08-02 Thread Cole Robinson
On 07/29/2016 05:44 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Signed-off-by: Chen Hanxiao > --- > ui/snapshots.ui | 37 +++-- > virtManager/snapshots.py | 3 ++- > 2 files changed, 21 insertions(+), 19 deletions(-) ACK and pushed (before rememb

Re: [virt-tools-list] virt-install looking for i386 installer but should be looking for amd64 installer

2016-08-08 Thread Cole Robinson
On 08/06/2016 09:51 PM, Dave Hein wrote: > I've been trying to install a KVM guest using Ubuntu Server 16.04. But I keep > getting the error "Couldn't find hvm kernel for Ubuntu tree". > > ubuntu server 16.04 > virt-install 1.3.2 > libosinfo 0.2.12 > > Here's my virt-install command: > > virt-in

Re: [virt-tools-list] virt-install looking for i386 installer but should be looking for amd64 installer

2016-08-08 Thread Cole Robinson
On 08/08/2016 08:00 PM, Dave Hein wrote: > > > On Mon, Aug 8, 2016 at 10:48 AM, Cole Robinson <mailto:crobi...@redhat.com>> wrote: > > On 08/06/2016 09:51 PM, Dave Hein wrote: > > I've been trying to install a KVM guest using Ubuntu Server 16.04. B

Re: [virt-tools-list] [PATCH] Use node device lifecycle events

2016-08-09 Thread Cole Robinson
Please add something like this to the commit message body: API will be available in upcoming libvirt 2.2.0 On 08/08/2016 03:41 PM, Jovanka Gulicoska wrote: > --- > virtManager/connection.py | 37 + > virtManager/nodedev.py| 3 +++ > 2 files changed, 40

Re: [virt-tools-list] [PATCH] Update initrd and kernel path for ppc64le platform.

2016-08-09 Thread Cole Robinson
On 08/09/2016 06:21 AM, Manjunath A Kumatagi wrote: > In CentOS 7 ppc64le platform initrd and kernel files are present under > ppc/ppc64 folder. Currently GenericDistro module will find only under > images/pxeboot folder. So to support custom boot the CentOS 7 ppc64le > platform I've added the c

Re: [virt-tools-list] [PATCH] enable zvol creation

2016-08-09 Thread Cole Robinson
On 07/28/2016 10:43 AM, Cole Robinson wrote: > On 07/28/2016 07:51 AM, Tristan Helmich wrote: >> Hi, >> >> just a quick patch to allow creation of ZFS zvol via virt-manager. >> Please let me know if anything else needs to be changed. >> > > Thanks Trist

Re: [virt-tools-list] [PATCH v2] Use node device lifecycle events

2016-08-11 Thread Cole Robinson
On 08/11/2016 09:11 AM, Jovanka Gulicoska wrote: > API will be available in upcoming libvirt 2.2.0 > --- > virtManager/connection.py | 32 > virtManager/nodedev.py| 2 ++ > 2 files changed, 34 insertions(+) > > diff --git a/virtManager/connection.py b/virtMan

Re: [virt-tools-list] [PATCH v3] Use node device lifecycle events

2016-08-11 Thread Cole Robinson
Thanks, pushed now. - Cole On 08/11/2016 10:10 AM, Jovanka Gulicoska wrote: > API will be available in upcoming libvirt 2.2.0 > --- > virtManager/connection.py | 32 > virtManager/nodedev.py| 2 ++ > 2 files changed, 34 insertions(+) > > diff --git a/virtMa

Re: [virt-tools-list] [PATCH] Update initrd and kernel path for ppc64le platform.

2016-08-16 Thread Cole Robinson
hareable=on > --extra-args ks=file:/centos-7ppc64le.ks inst.cmdline > stage2=live:CDLABEL=CentOS_AltArch_7_ppc64le --location /mnt/cdrom --channel > tcp,host=127.0.0.1:33696,mode=connect,target_type=virtio,name=org.fedoraproject.anaconda.log.0 > > Inactive hide details for Cole Robinson ---08/

Re: [virt-tools-list] virt-install looking for i386 installer but should be looking for amd64 installer

2016-08-16 Thread Cole Robinson
why the newer version is handling ISOs > differently. > > > I believe that the virt-inst that shipped with Ubuntu 14.04 (Trusty) predates > the merger of the python-virtinst source into the virt-manager GitHub repo. > Confirmed, and I've fixed it upstream now: commit 3f15a48

Re: [virt-tools-list] [PATCH] Use dode device update event support

2016-08-17 Thread Cole Robinson
On 08/17/2016 04:32 AM, Jovanka Gulicoska wrote: > API will be available in upcoming libvirt 2.2.0 > --- > virtManager/connection.py | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/virtManager/connection.py b/virtManager/connection.py > index 44f9bb5..8ef39a8

Re: [virt-tools-list] [virt-manager PATCH 2/2] console: don't use _close_viewer directly

2016-08-17 Thread Cole Robinson
On 08/17/2016 12:38 PM, Pavel Hrdina wrote: > Function _close_viewer should be always called together with setting > unavailable page. Call only _activate_unavailable_page which does both > things. > > Signed-off-by: Pavel Hrdina > --- > virtManager/console.py | 15 +-- > 1 file ch

Re: [virt-tools-list] [PATCH] Fix storage pool refresh event signal

2016-08-19 Thread Cole Robinson
On 08/18/2016 11:26 AM, Jovanka Gulicoska wrote: > When creating a storage volume, it wouldn't show up in the list > since the refresh signaling was busted. > Code was using VIR_STORAGE_POOL_EVENT_REFRESHED which was dropped > from lifecycle event type, refresh is introduced as top level > event. >

<    1   2   3   4   5   6   7   8   9   10   >