Re: [virt-tools-list] [virt-viewer v2] ovirt: Only use active ISO domains for foreign menu

2016-03-02 Thread Christophe Fergeau
On Wed, Mar 02, 2016 at 08:52:28AM +0100, Christophe Fergeau wrote: > oVirt storage domains can be in various states (inactive, in > maintainance, ...). We only want to show the ISOs it contains in the > foreign menu when the storage domain is actually active, not in the > other states. > > https:

Re: [virt-tools-list] [virt-viewer v2] ovirt: Only use active ISO domains for foreign menu

2016-03-02 Thread Fabiano Fidêncio
On Wed, Mar 2, 2016 at 12:02 PM, Christophe Fergeau wrote: > On Wed, Mar 02, 2016 at 08:52:28AM +0100, Christophe Fergeau wrote: >> oVirt storage domains can be in various states (inactive, in >> maintainance, ...). We only want to show the ISOs it contains in the >> foreign menu when the storage

Re: [virt-tools-list] [virt-viewer v2] ovirt: Only use active ISO domains for foreign menu

2016-03-02 Thread Eduardo Lima (Etrunko)
On 03/02/2016 09:04 AM, Fabiano Fidêncio wrote: > On Wed, Mar 2, 2016 at 12:02 PM, Christophe Fergeau > wrote: >> On Wed, Mar 02, 2016 at 08:52:28AM +0100, Christophe Fergeau wrote: >>> oVirt storage domains can be in various states (inactive, in >>> maintainance, ...). We only want to show the I

[virt-tools-list] [virt-viewer] app: Remove useless libxml includes

2016-03-02 Thread Fabiano Fidêncio
--- src/virt-viewer-app.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c index 3fa80a5..b51bf4f 100644 --- a/src/virt-viewer-app.c +++ b/src/virt-viewer-app.c @@ -36,9 +36,6 @@ #include #include -#include -#include - #ifdef HAVE_SYS_SOC

[virt-tools-list] [virt-viewer v2] Use GResource for loading ui files

2016-03-02 Thread Fabiano Fidêncio
Let's take advantage of GResource for loading ui files in a better and cleaner way than virt_viewer_util_load_ui() was doing. It also brings the benefit, at least for developers, of being able to test ui changes without having to "make install" virt-viewer. Signed-off-by: Fabiano Fidêncio --- Cha

Re: [virt-tools-list] [virt-viewer v2] Use GResource for loading ui files

2016-03-02 Thread Eduardo Lima (Etrunko)
On 03/02/2016 12:23 PM, Fabiano Fidêncio wrote: > Let's take advantage of GResource for loading ui files in a better and > cleaner way than virt_viewer_util_load_ui() was doing. > It also brings the benefit, at least for developers, of being able to > test ui changes without having to "make install

Re: [virt-tools-list] [virt-viewer v2] Use GResource for loading ui files

2016-03-02 Thread Eduardo Lima (Etrunko)
On 03/02/2016 02:46 PM, Eduardo Lima (Etrunko) wrote: > On 03/02/2016 12:23 PM, Fabiano Fidêncio wrote: >> Let's take advantage of GResource for loading ui files in a better and >> cleaner way than virt_viewer_util_load_ui() was doing. >> It also brings the benefit, at least for developers, of bein

Re: [virt-tools-list] [virt-viewer v2] Use GResource for loading ui files

2016-03-02 Thread Fabiano Fidêncio
On Wed, Mar 2, 2016 at 8:05 PM, Eduardo Lima (Etrunko) wrote: > On 03/02/2016 02:46 PM, Eduardo Lima (Etrunko) wrote: >> On 03/02/2016 12:23 PM, Fabiano Fidêncio wrote: >>> Let's take advantage of GResource for loading ui files in a better and >>> cleaner way than virt_viewer_util_load_ui() was do

Re: [virt-tools-list] [virt-viewer v2] Use GResource for loading ui files

2016-03-02 Thread Eduardo Lima (Etrunko)
On 03/02/2016 05:24 PM, Fabiano Fidêncio wrote: > On Wed, Mar 2, 2016 at 8:05 PM, Eduardo Lima (Etrunko) > wrote: >> On 03/02/2016 02:46 PM, Eduardo Lima (Etrunko) wrote: >>> On 03/02/2016 12:23 PM, Fabiano Fidêncio wrote: Let's take advantage of GResource for loading ui files in a better and