Re: [virt-tools-list] [PATCH v7 1/3] Port to GtkApplication API's

2016-02-22 Thread Pavel Grunt
Hi, ack from me. Now more code improvements can come. Pavel On Thu, 2016-02-18 at 21:51 +0100, Fabiano Fidêncio wrote: > From: "Eduardo Lima (Etrunko)" > > Most of this patch consists in code being shuffled around to fit the > expected flow while using the new APIs. I tried my best to make thi

Re: [virt-tools-list] [PATCH 4/5] virt-manager: connect with openGraphicsFD

2016-02-22 Thread Cole Robinson
On 02/22/2016 10:10 AM, Marc-André Lureau wrote: > Hi > > On Thu, Feb 18, 2016 at 8:11 PM, Cole Robinson wrote: >> Can you expand on this a bit more? Does this require > ... value to be specified by the user or something? Or will it enable gl >> even >> for listen=127.0.0.1 for example > > It

Re: [virt-tools-list] [PATCH 4/5] virt-manager: connect with openGraphicsFD

2016-02-22 Thread Marc-André Lureau
Hi On Thu, Feb 18, 2016 at 8:11 PM, Cole Robinson wrote: > Can you expand on this a bit more? Does this require ... value to be specified by the user or something? Or will it enable gl even > for listen=127.0.0.1 for example It doesn't require any Spice listening socket, the fd passing is done

Re: [virt-tools-list] [PATCH 4/5] virt-manager: connect with openGraphicsFD

2016-02-22 Thread Marc-André Lureau
Hi - Original Message - > On 02/22/2016 10:10 AM, Marc-André Lureau wrote: > > Hi > > > > On Thu, Feb 18, 2016 at 8:11 PM, Cole Robinson wrote: > >> Can you expand on this a bit more? Does this require >> socket='XXX' > >> ... value to be specified by the user or something? Or will it

Re: [virt-tools-list] [PATCH v7 1/3] Port to GtkApplication API's

2016-02-22 Thread Jonathon Jongsma
Ack from me as well On Mon, 2016-02-22 at 12:02 +0100, Pavel Grunt wrote: > Hi, > ack from me. > > Now more code improvements can come. > > Pavel > > On Thu, 2016-02-18 at 21:51 +0100, Fabiano Fidêncio wrote: > > From: "Eduardo Lima (Etrunko)" > > > > Most of this patch consists in code being

Re: [virt-tools-list] [PATCH v7 1/3] Port to GtkApplication API's

2016-02-22 Thread Fabiano Fidêncio
Pushed the 3 patches on this series. Thanks for the reviews! -- Fabiano Fidêncio ___ virt-tools-list mailing list virt-tools-list@redhat.com https://www.redhat.com/mailman/listinfo/virt-tools-list

Re: [virt-tools-list] [PATCH virtio-win-pkg-scripts] cpdrivers: accept unsigned binaries

2016-02-22 Thread Cole Robinson
On 02/20/2016 08:57 AM, Roman Kagan wrote: > PE binaries included in the driver package (.sys, .dll, etc) may contain > no internal signatures; in that case their digest in the catalog is > calculated till the end of the file. > > Signed-off-by: Roman Kagan > --- > util/cpdrivers.py | 2 ++ > 1