e even happier to review a MR adding the unattended scripts for
the new installer.
Best Regards,
--
Fabiano Fidêncio
top|jeos),admin-password-file=/path/to/admin/password/file,user-password-file=/path/to/user/password/file
This second option will rely on the libosinfo project to get the
optimal values for memory, vcpus, disk size, os-variant, etc.
Best Regards,
--
Fabiano Fidêncio
On Thu, Aug 15, 2019 at 9:03 PM Eduardo Lima (Etrunko)
wrote:
>
> On 8/15/19 12:07 PM, Fabiano Fidêncio wrote:
> > gmaovirt-foreign-menu.c: In function 'storage_domains_fetched_cb':
> > ovirt-foreign-menu.c:721:9: error: format not a string literal and no
> >
awhide/589/
Signed-off-by: Fabiano Fidêncio
---
src/ovirt-foreign-menu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 75f9ac4..4ec0858 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -71
installation to complete.
Signed-off-by: Fabiano Fidêncio
---
virt-install | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt-install b/virt-install
index af6c75bf..8efa4960 100755
--- a/virt-install
+++ b/virt-install
@@ -610,7 +610,7 @@ class WaitHandler:
self
Let's use identify_tree(), which is part of libosinfo v1.6.0 release,
instead of using guess_os_from_tree().
The API has been implemented on libosinfo in order to be consistent with
what was already done for medias.
Signed-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 15 +++--
Later on, it'll be used to generate the install-script and the kernel
command-line based on the specific tree being used.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/installer.py | 5 -
virtinst/install/unattended.py | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
nerate
the install-script and kernel command-line.
It's important to mention that those APIs are part of libosinfo v1.6.0
release and that's the reason the check for them has been added.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/unattended.py | 19 ---
Let's get the _OsTree object and have it added to the _LocationData
class.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/installertreemedia.py | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/virtinst/install/installertreemedia.py
b/virtinst/in
Let's allow to get the tree object from InstallerTreeMedia class.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/installertreemedia.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/virtinst/install/installertreemedia.py
b/virtinst/install/installertreemedia.py
index 6b9
Let's add a method that allows the tree object to be retrieved from the
_DistroTree class.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/urldetect.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/virtinst/install/urldetect.py b/virtinst/install/urldetect.py
index d20
Instead of returning an OsinfoTree, let's be consistent with what we
already do in guess_os_from_iso() and return our internal _OsTree
object.
This change doesn't affect any code as the only place using it doesn't
care about the returned tree object.
Signed-off-by: F
Similarly to the _OsMedia() class, let's create a _OsTree() class which,
at least for now, has only one method that returns the OsinfoTree
object.
Although this class & method are not extrictly needed, having them makes
the code more consistent.
Signed-off-by: Fabiano Fidêncio
---
Let's use generate_*_for_tree() whenever it's possible in order to have
the install-script and kernel command-line generated specifically for the
tree being used.
Fabiano Fidêncio (9):
osdict: Add _OsTree() class
osdict: Return a _OsTree instead of OsinfoTree when guessing an OS
As already done for _OsMedia, let's store the _OsTree object detected
as it'll be used later on in order to improve the installer script and
the kernel command line used for (tree based) unattended installations.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/urldetect.py | 4 ++
gt; @@ -21,12 +21,10 @@ class CloudInitData():
> return fobj.readline().rstrip("\n\r")
>
> def get_root_password(self):
> -if self.root_password == "generate":
> +if self.root_password_generate:
> return self.generate_password()
> elif self.root_password_file:
> return self._get_password(self.root_password_file)
> -else:
> -return self.root_password
>
>
> def create_metadata(scratchdir):
> --
> 2.20.1
>
> ___
> virt-tools-list mailing list
> virt-tools-list@redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
Reviewed-by: Fabiano Fidêncio
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
; +return fobj.readline().rstrip("\n\r")
> +
Not for now, but later on we can have this together with the one used
for unattended-installations.
> def get_root_password(self):
> if self.root_password == "generate":
> return self.generate_pa
Let's pass the OsinfoMedia object down to the OSInstallScript class so
it can be used, later on, to generate the install-script and kernel
command-line specifically for the media being used.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/unattended.py | 7 +--
1 file chang
Let's add a way to get the OsinfoMedia from the _OsMedia class. It's
going to be needed in order to properly generate the command line for
the unattended installations, when doing an installation from a media.
Signed-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 3 +++
1 file
PI or not.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/unattended.py | 8
1 file changed, 8 insertions(+)
diff --git a/virtinst/install/unattended.py b/virtinst/install/unattended.py
index 98bcbb21..e34b8ae2 100644
--- a/virtinst/install/unattended.py
+++ b/virtinst/install/unatte
just using the normal resources.
Fabiano Fidêncio (5):
unattended: Simplify _generate_debug()
osdict: Add get_osinfo_media() to _OsMedia class
unattended: Pass OsinfoMedia to OSInstallScript
unattended: Use generate_*_for_media when possible
unattended: Always set "media" as
Let's set "media" as installation source for all the ISOs, even the
net-installer ones, as this can be dealt with on osinfo-db side.
Signed-off-by: Fabiano Fidêncio
---
.../compare/virt-install-osinfo-netinst-unattended.xml| 2 +-
virtinst/instal
Instead of a creating a new Config object and setting and the needed
fields, let's just save the original user & admin passwords, set the
"[SCRUBBLED]" one for generating the debug output, and reset the
original values after that.
Signed-off-by: Fabiano Fidêncio
--
On Fri, Jul 5, 2019 at 10:30 AM Fabiano Fidêncio wrote:
>
> On Fri, Jul 5, 2019 at 9:10 AM Cedric Bosdonnat wrote:
> >
> > Hey!
> >
> > I know nothing of SELinux, the patches look good though I'm helpless on
> > that topic.
>
> Please, let me give
On Fri, Jul 5, 2019 at 9:10 AM Cedric Bosdonnat wrote:
>
> Hey!
>
> I know nothing of SELinux, the patches look good though I'm helpless on
> that topic.
Please, let me give it a try before pushing. I'll do so after lunch
and give my Ack here. :-)
>
> --
> Cedric
>
> On Thu, 2019-07-04 at 21:59
file:' selector should be used instead.
Signed-off-by: Fabiano Fidêncio
---
man/virt-bootstrap.pod | 16 ++--
src/virtBootstrap/__init__.py | 2 +-
src/virtBootstrap/virt_bootstrap.py | 14 ++
tests/__init__.py | 8 ++
0183' has been assigned to the virt-install --unattended
admin-password=xxx disclosure issue.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/unattended.py | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/virtinst/install/unattended.py
archives/virt-tools-list/2019-July/msg00013.html
- passowrd -> password;
- pwd.read().rstrip("\n\r") -> pwd.readline().rstrip("\n\r") + document
this in our manpage;
- create a new config, with the sanitised password, and use it to print
the script content as a debug
Let's not expose the user/root password in the CLI and, instead, let's
rely on a file passed by the admin and read the password from there.
'CVE-2019-10183' has been assigned to the virt-install --unattended
admin-password=xxx disclosure issue.
Signed-off-by: Fabiano Fid
On Wed, Jul 3, 2019 at 1:54 PM Pavel Hrdina wrote:
>
> On Tue, Jul 02, 2019 at 09:21:45PM +0200, Fabiano Fidêncio wrote:
> > Logging user & admin passwords in the command-line is a security issue,
> > let's avoid doing so by:
> > - Not printing the values se
On Wed, Jul 3, 2019 at 10:53 AM Pavel Hrdina wrote:
>
> On Tue, Jul 02, 2019 at 09:21:44PM +0200, Fabiano Fidêncio wrote:
> > Let's not expose the user/root password in the CLI and, instead, let's
> > rely on a file passed by the admin and read the password from th
0183' has been assigned to the virt-install --unattended
admin-password=xxx disclosure issue.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install/unattended.py | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/virtinst/install/unattended.py b/virtinst/install/
Let's not expose user & admin passwords neither by having an option to
be used to set those passwords nor in the debug messages.
'CVE-2019-10183' has been assigned to the virt-install --unattended
admin-password=xxx disclosure issue.
Fabiano Fidêncio (2):
unattended: Read t
Let's not expose the user/root password in the CLI and, instead, let's
rely on a file passed by the admin and read the password from there.
'CVE-2019-10183' has been assigned to the virt-install --unattended
admin-password=xxx disclosure issue.
Signed-off-by: Fabiano Fid
On Wed, Jun 26, 2019 at 4:38 PM Cole Robinson wrote:
>
> On 6/26/19 7:43 AM, Fabiano Fidêncio wrote:
> > guess_os_from_tree() has been depracated in libosinfo 1.6.0 release and
> > identify_tree() should be used instead.
> >
> > Signed-off-by: Fabiano Fidêncio
>
guess_os_from_tree() has been depracated in libosinfo 1.6.0 release and
identify_tree() should be used instead.
Signed-off-by: Fabiano Fidêncio
---
I'm aware of the "let's not depend on something new for things that are
not crucial" policy ... although as I'm alre
gt;
>> > > On Fri, Jun 07, 2019 at 12:00:56PM +0200, Fabiano Fidêncio wrote:
>> > > > Instead of using "floppy" as the way to perform unattended
>> > > > installations
>> > > > for Windoes, let's prefer using "cdro
Let's just use mktemp() as done in several other places and avoid the
risk of having the content of the folder overwritten in case of parallel
installations.
Signed-off-by: Fabiano Fidêncio
---
virtinst/unattended.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/vir
Similarly to what's already done in installertreeinfo.py, let's log when
removing the files used during the unattended installation.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/virtinst/installer.py b/virtinst/installe
that's
not desirable, just ignore the patch.
Fabiano Fidêncio (3):
unattended: Do not create a "unattended" dir
installer: Log when cleaning up the unattended files
installer*.py: Remove temporary dirs
virtinst/installer.py | 11 +++
virtinst/installertreemed
Together with the temporary files removal, let's also remove the
directories created to store those files.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 10 ++
virtinst/installertreemedia.py | 9 +
2 files changed, 19 insertions(+)
diff --git a/vir
rating the ISO depends on genisofs, tho. However, it's not a big
deal as genisofs is already a virt-manager dependency.
Signed-off-by: Fabiano Fidêncio
---
virt-manager.spec.in | 5
virtinst/{floppyinject.py => cdrominject.py} | 26 +++
On Thu, Jun 6, 2019 at 4:12 PM Fabiano Fidêncio wrote:
>
> Instead of using "floppy" as the way to perform unattended installations
> for Windows, let's prefer using "cdrom" instead.
>
> The main reasons behind this change are:
> - VMs using q35 may
Let's download and pre/post install the drivers available. In order to
do so, we have to keep the cdrom containing the files as it'll be used
after the machine does its first reboot.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 20 ++--
1 file c
When getting all_devices(), we should also take into consideration the
pre-installable drivers.
Signed-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/virtinst/osdict.py b/virtinst/osdict.py
index 90aa3d5d..31446380
Windows(es) may provide more than one installer script. Those scripts
are used to perform pre/post installation of drivers.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 16 ++--
virtinst/installertreemedia.py | 18 ++
virtinst/osdict.py
Let's add a couple of methods to:
- get the pre/post installable drivers (these will return a list of
OsinfoDeviceDrivers);
- get the pre/post installable drivers location (these will return a list
of strings);
Signed-off-by: Fabiano Fidêncio
---
virtinst/osdict.py
Similarly to what's already done in installertreeinfo.py, let's log when
removing the files used during the unattended installation.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/virtinst/installer.py b/virtinst/installe
Any unattended installation creates a (or similar to)
~/.cache/virt-manager/$pid/unattended directory where the unattended
installations related files are stored.
Let's clean those dirs up during the clean up process.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 10
This will be used by unattended installations. The drivers are
downloaded in the very same directory where the unattended files are
generated.
Signed-off-by: Fabiano Fidêncio
---
virtinst/unattended.py | 16
1 file changed, 16 insertions(+)
diff --git a/virtinst/unattended.py
Any unattended installation creates a (or similar to)
~/.cache/virt-manager/$pid/unattended directory where the unattended
installations related files are stored.
Let's clean those dirs up during the clean up process.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installertreemedia.p
s created by the "make"
method.
Signed-off-by: Fabiano Fidêncio
---
virtinst/util.py | 13 +
1 file changed, 13 insertions(+)
diff --git a/virtinst/util.py b/virtinst/util.py
index 7219d49f..d8b19b7e 100644
--- a/virtinst/util.py
+++ b/virtinst/util.py
@@ -271,6 +27
rating the ISO depends on genisofs, which is not a big deal as it's
already a virt-manager dependency.
Signed-off-by: Fabiano Fidêncio
---
virt-manager.spec.in | 5 -
virtinst/cdrominject.py | 26 ++
virtinst/floppyinject.py | 35
Instead of passing a scratch dir and creating another dir inside it,
let's just take advantage of util's util.make_unattended_cache_dir() and
create the "unattended.img" file there.
Signed-off-by: Fabiano Fidêncio
---
virtinst/floppyinject.py | 11 +--
virtinst/
Let's use this util's method and avoid creating the cache dir by our
own.
Signed-off-by: Fabiano Fidêncio
---
virtinst/unattended.py | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/virtinst/unattended.py b/virtinst/unattended.py
index 11de2fed..e79c1a47 10
when dealing with
unattended installs?
- Everytime the unattended cdrom is added, a new pool is created. It's
already the current behaviour with the floppy.
Fabiano Fidêncio (12):
util: Add {make,get}_unattended_cache_dir()
unattended: Use make_unattended_cache_dir()
"maxMemory", "maxMemorySlots", "memory", "_currentMemory",
> "blkiotune", "memtune", "memoryBacking",
> "_vcpus", "vcpu_current", "vcpu_placement",
> @@ -178,7 +178,9 @@
On Mon, May 20, 2019 at 1:45 PM Athina Plaskasoviti
wrote:
>
> XML mapping:
>
>
> ...
>
>
> Signed-off-by: Athina Plaskasoviti
Reviewed-by: Fabiano Fidêncio
[snip]
Best Regards,
--
Fabiano Fidêncio
___
virt-tools-list
s_onoff=True)
> diff --git a/virtinst/devices/disk.py b/virtinst/devices/disk.py
> index 6556c8cd..cfe57cb7 100644
> --- a/virtinst/devices/disk.py
> +++ b/virtinst/devices/disk.py
> @@ -643,6 +643,7 @@ class DeviceDisk(Device):
> driver_copy_on_read = XMLProperty("./
Michal Privoznik
> ---
>
> diff to v1:
> - Fixed 'make syntax-check' issue
> - Introduced support for completing domain IDs
> - Introduced --display= completer
Reviewed-by: Fabiano Fidêncio
[snip]
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
On Mon, May 6, 2019 at 9:25 AM Fabiano Fidêncio wrote:
>
> Michal,
>
> Take this review (and, spoiler alert, ack) with a grain of salt as
> I've been out of virt-viewer development for several years now.
>
> On Tue, Mar 26, 2019 at 4:28 PM Michal Privoznik wrote:
> &
; +# Our bash completion script uses virsh to list domains
> +Requires: libvirt-client
> +%endif
> +
> +
> %if 0%{?enable_autotools}
> BuildRequires: autoconf
> BuildRequires: automake
> @@ -51,6 +59,9 @@ BuildRequires: gettext
> %if %{with_govirt}
> BuildRequires: pkgconfig(govirt-1.0) >= @GOVIRT_REQUIRED@
> %endif
> +%if %{with_bash_completion}
> +BuildRequires: pkgconfig(bash-completion) >= @BASH_COMPLETION_REQUIRED@
> +%endif
>
> %if 0%{?fedora} >= 20
> Obsoletes: spice-client < 0.12.3-2
> @@ -102,5 +113,8 @@ rm -rf $RPM_BUILD_ROOT
> %{_datadir}/mime/packages/virt-viewer-mime.xml
> %{_mandir}/man1/virt-viewer.1*
> %{_mandir}/man1/remote-viewer.1*
> +%if %{with_bash_completion}
> +%{_datadir}/bash-completion/completions/virt-viewer
> +%endif
>
> %changelog
> --
> 2.19.2
>
> ___
> virt-tools-list mailing list
> virt-tools-list@redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
Apart from the two issues pointed out, the patch works as expected!
Here's a diff of the changes that have to be squashed:
```
fidencio@laerte ~/src/upstream/virt-viewer $ git diff
diff --git a/bash-completion/virt-viewer b/bash-completion/virt-viewer
index e4a7544..ad60d46 100644
--- a/bash-completion/virt-viewer
+++ b/bash-completion/virt-viewer
@@ -67,7 +67,7 @@ _virt_viewer_complete()
-*)
COMPREPLY=( $( compgen -W '$( _parse_help "$1" -h )' -- "$cur" ) )
-[[ $COMPREPLY == *= ]] && compopt -o nospace
+[[ $COMPREPLY == *= ]] && compopt || nospace
return
;;
esac
@@ -87,4 +87,3 @@ _virt_viewer_complete()
complete -F _virt_viewer_complete virt-viewer
# vim: ft=sh:et:ts=4:sw=4:tw=80
-
```
Reviewed-by: Fabiano Fidêncio
___
virt-tools-list mailing list
virt-tools-list@redhat.com
https://www.redhat.com/mailman/listinfo/virt-tools-list
On Mon, Apr 29, 2019 at 1:42 PM Pavel Hrdina wrote:
>
> On Thu, Apr 25, 2019 at 03:42:36PM +0200, Fabiano Fidêncio wrote:
> > When performing a tree based unattended installation, some distros
> > require extra arguments to be passed to the kernel command line.
> >
With that in mind and knowing that osinfo-db has been updated
accordingly, we can fully rely on the command line returned by libosinfo
and stop appending arguments returned by get_kernel_url_arg() when
performing unattended installations.
Signed-off-by: Fabiano Fidêncio
---
osinfo-db patches, stil
7;s something up to the distros to pick the newest source and/or
depend on their update policies.
If you need virt-viewer 8.0 in your preferred distro, I'd strongly
suggest to open them a bug.
Best Regards,
--
Fabiano Fidêncio
___
virt-too
In case there's no self.osinfo_media, it means the installation won't
happen from the media itself, so it should return "True" (as in, it
requires internet).
Returning "False", though, should be done when no "netinst" variant was
found (but we do have a
On Thu, Mar 28, 2019 at 10:45 PM Fabiano Fidêncio wrote:
>
> The main differences are:
> - Windows unattended installation will be performed via "floppy"
> injection instead of "initrd";
> - Windows target disk must be a letter ("C", in our case);
&g
ne in a previous commit, but those were basically:
- Not using /dev/*da as a target disk, but use "C" instead;
- Set the product-key
- Explicitly set the injection method as "floppy"
Signed-off-by: Fabiano Fidêncio
---
virt-install | 9 +
v
The main differences are:
- Windows unattended installation will be performed via "floppy"
injection instead of "initrd";
- Windows target disk must be a letter ("C", in our case);
- Windows requires a product-key to be passed
Signed-off-by: Fabiano Fidêncio
-
Let's have a way to keep track of unattended files that are going to be
used when performing a unattended installation of a Windows guest so we
can clean them up whenever the installation is done.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 5 +
1 file changed, 5 inser
Let's add unattended data to the Installer class as it's going to be
used whenever a Windows unattended installation is performed.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/virtinst/installer.py b/virtinst/installe
Similar to perform_initrd_injections(), which is used by Linux(es)
unattended installations, perform_floppy_injections() is going to be
used by Windows(es) unattended installations.
Signed-off-by: Fabiano Fidêncio
---
virt-manager.spec.in | 5 +
virtinst/floppyinject.py | 34
important, they can be added later and, AFAIR, we
will have to spend some time figuring out a few things before actually be
able to achieve them.
Fabiano Fidêncio (7):
Add perform_floppy_injections()
unattended: Add product-key to Unattended data
unattended: Adapt for Windows
installer:
A floppy device is going to be used when performing a unattended
installation in a Windows guest.
In order to have it done cleanly, let's mimic the what's already
existent for dealing with cdrom devices used during installation.
Signed-off-by: Fabiano Fidêncio
---
virtinst/install
Signed-off-by: Fabiano Fidêncio
---
tests/clitest.py | 1 +
virtinst/cli.py| 1 +
virtinst/unattended.py | 1 +
3 files changed, 3 insertions(+)
diff --git a/tests/clitest.py b/tests/clitest.py
index 3668e26b..d3bd6044 100644
--- a/tests/clitest.py
+++ b/tests/clitest.py
On Fri, Mar 22, 2019 at 4:23 PM Fabiano Fidêncio wrote:
>
> In order to properly do a unattended installation of some medias (as net
> installers), we have to check whether the media requires or not
> internet. Doing so by checking its variant is not the most beautiful way
> (as
The OsinfoMedia class is a wrapper around OsinfoMedia and will help us
to keep the logic of dealing with media related stuff from inside
osdict.py
Signed-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/virtinst/osdict.py b/virtinst
This method returns whether the installer requires or not internet to
perform the installation.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installertreemedia.py | 10 ++
1 file changed, 10 insertions(+)
diff --git a/virtinst/installertreemedia.py b/virtinst/installertreemedia.py
On Fri, Mar 22, 2019 at 4:23 PM Fabiano Fidêncio wrote:
>
> The OsinfoMedia class is a wrapper around OsinfoMedia and will help us
> to keep the logic of dealing with media related stuff from inside
> osdict.py
s/OsinfoMedia/OsMedia, in both commit short-log and message.
>
s internal
_get_installation_source() method
- rename osdict::get_install_script's media argument to os_media
Signed-off-by: Fabiano Fidêncio
---
virtinst/installertreemedia.py | 8
virtinst/osdict.py | 3 ++-
virtinst/unattended.py | 10 ++
virtinst/urldetect.p
-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 15 +++
1 file changed, 15 insertions(+)
diff --git a/virtinst/osdict.py b/virtinst/osdict.py
index 4ffcfa29..c49c45e4 100644
--- a/virtinst/osdict.py
+++ b/virtinst/osdict.py
@@ -483,6 +483,21 @@ class _OsVariant(object
r the
installation.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 32 ++--
1 file changed, 26 insertions(+), 6 deletions(-)
diff --git a/virtinst/installer.py b/virtinst/installer.py
index 67cdfb29..b8c048f1 100644
--- a/virtinst/installer.py
+++ b/vir
By using OsinfoMedia.requires_internet() we ensure this logic is not
spread in our codebase and also keep _OsinfoIter internal to osdict.
Signed-off-by: Fabiano Fidêncio
---
virtinst/unattended.py | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/virtinst
an be done with the current state of osinfo-db.
Signed-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 8
1 file changed, 8 insertions(+)
diff --git a/virtinst/osdict.py b/virtinst/osdict.py
index 6486643d..67e70f62 100644
--- a/virtinst/osdict.py
+++ b/virtinst/osdict.py
@@ -616,3 +6
- Moved the whole logic about setting-up the guest XML to installer.py
Fabiano Fidêncio (7):
osdict: Add get_network_install_resources()
osdict: Add OsinfoMedia class
osdict: Add requires_internet() to OsMedia
urldetect: return osdict.py:OsMedia instead of Libosinfo.Media
unattended: Take
This method returns whether the installer requires or not internet to
perform the installation.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installertreemedia.py | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/virtinst/installertreemedia.py b/virtinst
Signed-off-by: Fabiano Fidêncio
---
virtinst/installer.py | 17 +
1 file changed, 17 insertions(+)
diff --git a/virtinst/installer.py b/virtinst/installer.py
index 67cdfb29..cd9e7fc2 100644
--- a/virtinst/installer.py
+++ b/virtinst/installer.py
@@ -152,6 +152,21 @@ class
-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/virtinst/osdict.py b/virtinst/osdict.py
index 08176976..12f625ba 100644
--- a/virtinst/osdict.py
+++ b/virtinst/osdict.py
@@ -478,6 +478,20 @@ class _OsVariant(object
**: info still to be filled
Fabiano Fidêncio (4):
osdict: Add get_network_install_resources()
installertreemedia: Add requires_internet()
guest: Deal with network install resources
installer: Set the network install resources when needed
virtinst/guest.py | 14
Let's add two new methods to deal with network install resources so
those can be set from the installer.
Signed-off-by: Fabiano Fidêncio
---
virtinst/guest.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/virtinst/guest.py b/virtinst/guest.py
index 2cca3e8d..2bb
On Thu, 2019-03-07 at 13:52 +0100, Fabiano Fidêncio wrote:
> This series provides the 3rd part of unattended installation support
> and
> consists in:
>
> - "installertreemdia: Set user specified --location as the installer
> URL":
> - Fix unattended install
Let's pass the media down to prepare_install_script() as it'll be used
to:
- select the preferred installation source;
- be passed down to the get_install_script() method;
Signed-off-by: Fabiano Fidêncio
---
virtinst/installertreemedia.py | 2 +-
virtinst/unattended.py | 2 +
thing. In case no installer script is supported,
let's just error out and abort the installation.
Signed-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 22 ++
1 file changed, 22 insertions(+)
diff --git a/virtinst/osdict.py b/virtinst/osdict.py
index 0ef1617c..08176976 1
to have its installation source set accordingly.
An different approach for this would be to generate the script
specifically from the media whenever a media is passed. However, IMO, it
would just add two new codepaths and having the media passed around
without a real gain against the method chose
t; work properly when combined with
"--cdrom".
Signed-off-by: Fabiano Fidêncio
---
virt-install | 3 +++
1 file changed, 3 insertions(+)
diff --git a/virt-install b/virt-install
index 27b52c6b..d7af107b 100755
--- a/virt-install
+++ b/virt-install
@@ -449,6 +449,9 @@ def build_installe
be used without the
user having to explicitly pass them when calling virt-install.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installertreemedia.py | 8
1 file changed, 8 insertions(+)
diff --git a/virtinst/installertreemedia.py b/virtinst/installertreemedia.py
index 39f5ac0f..0b8b1
Let's refactor get_install_script() in a way that any addition done in
order to get the install scripts from the media would be cleaner.
Signed-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 53 --
1 file changed, 28 insertions(+), 25 dele
reason, their own URLs should be covered as well.
Signed-off-by: Fabiano Fidêncio
---
virtinst/installertreemedia.py | 3 ++-
virtinst/unattended.py | 10 +++---
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/virtinst/installertreemedia.py b/virtinst/installertreemedia.py
Signed-off-by: Fabiano Fidêncio
---
virtinst/osdict.py | 2 +-
virtinst/unattended.py | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/virtinst/osdict.py b/virtinst/osdict.py
index a54cc413..0ef1617c 100644
--- a/virtinst/osdict.py
+++ b/virtinst/osdict.py
@@ -535,7
Let's add an internal Libosinfo.OsMedia attribute to the
InstallerTreeMedia object.
By doing this, it'll help us to:
- easily get the media's kernel and initrd path
- pass down the Libosinfo.Media to the generate_install_script() method
Signed-off-by: Fabiano Fidêncio
1 - 100 of 931 matches
Mail list logo
