[vdr] [patch] avoid inheritance of file descriptors

Hi, I think there is a problem in calling external programs from plugins. If such a program takes some while for execution (even in background) it gets inherited all file descriptors of VDR. This prevents vdr from zapping to another channel or even from restarting properly. You will see messag

Re: [vdr] [patch] avoid inheritance of file descriptors

Klaus Schmidinger wrote: > Doesn't SystemExec() (see tools.c) take care of this? Yes you are right - it takes care internally but not for plugins like dvdswitch etc. In order to fix this problem you could patch every single plugin or just set the right file descriptor flag once. I think the latt

Re: [vdr] [patch] avoid inheritance of file descriptors

Anssi Hannula wrote: > Deti Fliegl wrote: >> Klaus Schmidinger wrote: >>> Doesn't SystemExec() (see tools.c) take care of this? >> Yes you are right - it takes care internally but not for plugins like >> dvdswitch etc. In order to fix this problem you could pa

Re: [vdr] [patch] avoid inheritance of file descriptors

Deti Fliegl wrote: > Anssi Hannula wrote: >> Deti Fliegl wrote: >>> Klaus Schmidinger wrote: >>>> Doesn't SystemExec() (see tools.c) take care of this? >>> Yes you are right - it takes care internally but not for plugins like >>> dvdswitch et

Re: [vdr] [patch] avoid inheritance of file descriptors

Klaus Schmidinger wrote: > Plugins can call SystemExec() just as well when the want to execute > an external program. Yes, but would you point every single developer on this issue? > IMHO it is no feasible solution to expect every file handle to > be opened with FD_CLOEXEC. Even if VDR itself woul

[vdr] consistent device removal

Hi, sometimes it is very useful to create and destroy cDevice based classes at runtime. Currently it is only possible to create such classes at any time but destroying causes inconsistency in the 'devices' array which leads to segmentation faults in various places. The patch attached keeps t

Re: [vdr] consistent device removal

uups: change the 'break' by 'return' otherwise you'll get a wrong error message ;-) Deti ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] consistent device removal

Udo Richter wrote: > Definitely something that is worth considering. The patch also brings us > one step closer towards hotplug support, a feature that seems very > obvious in times of USB DVB devices. Yep you are right but IMHO there would be some more work to do: VDR should compile also withou

[vdr] [PATCH] Section Filter Read Abstraction

Hi, when using cDevice based classes that have no access to kernel based section filters it makes sense to have an abstract 'ReadFilter' function. The patch attached adds such a method to the cDevice class and changes cSectionHandler code to use the new method. Please add this patch to curre

Re: [vdr] [PATCH] Section Filter Read Abstraction

Rolf Ahrenberg wrote: > The IPTV plugin manages this by creating pipes for section filters, so > you can make software-only devices also with the current API. Anyway, Yes I know - my Plugin currently uses the same workaround. But this time lets make "Nägel mit Köpfen" (i.e. make it properly). >