[v8-users] Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-07-09 Thread Rodrigo Hernandez
Hello, I am trying to create a VCPKG (https://github.com/microsoft/vcpkg) port of v8, and in doing so I am syncing to tag 8.3.110.13 as suggested here: https://v8.dev/docs/version-numbers Since this is package manager, I want to build against msvc's c++ lib, so I am using use_custom_libcxx=fal

[v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-07-12 Thread Rodrigo Hernandez
o a dirty repo. So while I guess I found a workaround I still would like to know whats with the initializer symbols missing in MSVC, can somebody comment? Thanks! On Thursday, July 9, 2020 at 2:06:21 PM UTC-6, Rodrigo Hernandez wrote: > > Hello, > > I am trying to create a VCPKG (htt

Re: [v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-07-13 Thread Rodrigo Hernandez
al, since MSVC programs > won't be able to reliably link to it. > Ben > > On Mon, 13 Jul 2020, 2:17 am Rodrigo Hernandez, < > kwizatz.aeongames@gmail.com> wrote: > >> >> Ok, findings so far: >> >> commenting out the flag "/Zc:inline

Re: [v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-07-13 Thread Rodrigo Hernandez
asically MSVC is not a fully supported compiler. > static releases builds are tested (e.g. that's how Node.js builds), but > everything else is untested and breaks pretty quickly even if you get a fix > in. > > - Bill > > On Monday, July 13, 2020 at 7:41:39 AM UTC-7, Rodr

Re: [v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-07-14 Thread Rodrigo Hernandez
Got to the same point with branch head 8.1, did some dependency moves like adding v8_initializers as a v8 dependency as well as wasm_api_test as well as adding some missing V8_EXPORT macros until I got to the point where NodeCache was undefined, moved more deps and got duplicated symbols. Some

Re: [v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-07-16 Thread Rodrigo Hernandez
those cryptic undefined symbol errors. On Tuesday, July 14, 2020 at 11:50:03 AM UTC-6, Rodrigo Hernandez wrote: > > > Got to the same point with branch head 8.1, did some dependency moves like > adding v8_initializers as a v8 dependency as well as wasm_api_test as well > as adding so

Re: [v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-07-16 Thread Rodrigo Hernandez
r users out there in the > same boat. > Ben > > > > On Fri, 17 Jul 2020 at 03:40, Rodrigo Hernandez > wrote: > >> >> Ok, found the problem, beside some missing V8_PRIVATE_EXPORTs, >> v8_enable_verify_heap is broken on component builds. >> >> v

[v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-07-17 Thread Rodrigo Hernandez
t;, I may be able to create a CL later on, but if someone can help with that, it would be great. Cheers! On Thursday, July 9, 2020 at 2:06:21 PM UTC-6, Rodrigo Hernandez wrote: > > Hello, > > I am trying to create a VCPKG (https://github.com/microsoft/vcpkg) port > of v8, > and in

[v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-07-22 Thread Rodrigo Hernandez
works on Linux which was something vcpkg bots checked for last time I submitted a port. That last one is probably the one that's going to take more time. Cheers! On Thursday, July 9, 2020 at 2:06:21 PM UTC-6, Rodrigo Hernandez wrote: > > Hello, > > I am trying to create a VCPKG (h

[v8-users] Re: Compiling V8 8.4 on Windows using using_custom_libcxx=false

2020-07-27 Thread Rodrigo Hernandez
See the patches I posted on this thread , you need to add "-Wno-range-loop-construct" and maybe "-Wno-invalid-offsetof" to your compilation flags if you're using clang. The patches are for the 8.3 branch head, but the changes needed a

[v8-users] Re: Compiling V8 8.4 on Windows using using_custom_libcxx=false

2020-07-28 Thread Rodrigo Hernandez
No problem, I am glad it worked out for you. On Tuesday, July 28, 2020 at 1:29:52 AM UTC-6, Hans Maier wrote: > > With your patches and a patch for ICU (see attach.) I was able to build > the version 8.4. > > Thanks! > > Am Montag, 27. Juli 2020 17:10:50 UTC+2 schr

[v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-08-04 Thread Rodrigo Hernandez
A PR for the vcpkg port is up at: https://github.com/microsoft/vcpkg/pull/12687 Just working out the final issues with x86-windows. On Thursday, July 9, 2020 at 2:06:21 PM UTC-6, Rodrigo Hernandez wrote: > > Hello, > > I am trying to create a VCPKG (https://github.com/microsoft

[v8-users] Re: GN failure on Windows

2020-10-10 Thread Rodrigo Hernandez
Hi Tekman, I've seen that error before, apparently there was a bug which allowed the dependency to be done, and that kind of dependency was/is made by older versions/tags. If you've already run gclient sync AFTER checking out LKGR 8.5 with git and that did not work, you can try manually repla

[v8-users] Recovering a FunctionTemplate (or how to ->Inherit from one you've lost the handle to?)

2020-10-10 Thread Rodrigo Hernandez
Hello, So, suppose I am wrapping a C++ class around a JS constructor, I've already created and initialized the isolate, created and initialized a context, I have the FunctionTemplate for the constructor and I have instantiated the function and I can call it from Js as x() or new X(), all this i

Re: [v8-users] Recovering a FunctionTemplate (or how to ->Inherit from one you've lost the handle to?)

2020-10-11 Thread Rodrigo Hernandez
that pretty much just resets the permanent handles. Thanks Again! On Sunday, October 11, 2020 at 1:49:10 AM UTC-6 Ben Noordhuis wrote: > On Sat, Oct 10, 2020 at 10:44 PM Rodrigo Hernandez > wrote: > > > > Hello, > > > > So, suppose I am wrapping a C++ class around

[v8-users] Re: GN failure on Windows

2020-10-13 Thread Rodrigo Hernandez
ot;™ for us until > now. > > Thanks! > > On Saturday, October 10, 2020 at 1:29:37 PM UTC-7 Rodrigo Hernandez wrote: > >> >> Hi Tekman, >> >> I've seen that error before, apparently there was a bug which allowed the >> dependency to be done, and th

Re: [v8-users] Re: GN failure on Windows

2020-10-16 Thread Rodrigo Hernandez
infra-packages.appspot.com/dl/gn/gn/mac-amd64/+/latest> and > Windows > <https://chrome-infra-packages.appspot.com/dl/gn/gn/windows-amd64/+/latest>. * > > > On Tuesday, October 13, 2020 at 8:38:26 AM UTC-7 Rodrigo Hernandez wrote: > >> You can just replace t

Re: [v8-users] Recovering a FunctionTemplate (or how to ->Inherit from one you've lost the handle to?)

2020-10-19 Thread Rodrigo Hernandez
e to cast them to a void* and wrapping them inside a v8::External? On Sunday, October 11, 2020 at 11:40:27 AM UTC-6 Rodrigo Hernandez wrote: > Thanks Ben, I see how those are less optimal, I was hoping for something > along the lines of context->global()->GetFunctionTemplate("

Re: [v8-users] Recovering a FunctionTemplate (or how to ->Inherit from one you've lost the handle to?)

2020-10-22 Thread Rodrigo Hernandez
ing to do? In that case you don't need > to put them in a v8::External. You can pass those objects to > data->SetInternalField safely I would think. > Ben > > > On Tuesday, 20 October 2020 at 15:10:00 UTC+10:30 Rodrigo Hernandez wrote: > >> So, coming back

[v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-10-22 Thread Rodrigo Hernandez
src\x64\Debug\ezv8.dll : fatal error > LNK1120: 1 unresolved externals > > > > On Wednesday, 5 August 2020 at 07:53:41 UTC+9:30 kosit la-orngsri wrote: > >> สวัสดี >> >> ในวันที่ วันพุธที่ 5 สิงหาคม ค.ศ. 2020 เวลา 0 นาฬิกา 59 นาที 57 วินาที >> UTC+7 Ro

[v8-users] Re: Errors Building v8 8.3.110.13 for Windows with is_component_build=true target_cpu="x64" is_clang=false use_custom_libcxx=false

2020-10-22 Thread Rodrigo Hernandez
I almost forgot, I created this repo for my own sanity: https://github.com/AeonGames/v8-builder it has bash scripts to make generating patches for new versions easier... or at least for me 😁 On Thursday, October 22, 2020 at 2:12:47 PM UTC-6 Rodrigo Hernandez wrote: > Latest is 8.5.210

Re: [v8-users] Recovering a FunctionTemplate (or how to ->Inherit from one you've lost the handle to?)

2020-10-23 Thread Rodrigo Hernandez
an static_cast it back to > FunctionTemplate where you call "Inherit". It still means you're doing some > deliberate garbage handling however. > > On Friday, 23 October 2020 at 06:35:07 UTC+10:30 Rodrigo Hernandez wrote: > >> Hi Ben, >> >> Yes, however w

Re: [v8-users] Enable pointer compression V8 8.6

2020-10-24 Thread Rodrigo Hernandez
Hi Ben, You need to add - DV8_COMPRES_POINTERS to your compile flags. On Sat, Oct 24, 2020, 7:06 PM Ben Ernst wrote: > Hey all, thank you in advance for any advice here. How does one enable > pointer compression? I'm updating from v7.1 to v8.6, and I get this error > message (below) at runti

Re: [v8-users] Re: [8.7] Compile errors with Visual Studio 2019

2021-02-01 Thread Rodrigo Hernandez
Is there a reason it MUST be 8.7? I am the current maintainer for Windows builds on VCPKG and Mingw-w64, the VCPKG version is probably exactly what you need, but it currently sits at 8.6. I am working on an update to current stable version 8.8, but if it must be 8.7 you may have to see the port