Re: [v8-users] Questions when adding global object

2018-06-27 Thread zcw
Thank you! We decided to temporarily remove the console block. Really appreciate your help! On Wednesday, June 27, 2018 at 11:55:02 AM UTC-7, Jakob Kummerow wrote: > > Sorry, I only know what I see in the code. I'm not sure if/how > ConsoleDelegate is supposed to be used via the regular API. > >

Re: [v8-users] Questions when adding global object

2018-06-27 Thread Jakob Kummerow
Sorry, I only know what I see in the code. I'm not sure if/how ConsoleDelegate is supposed to be used via the regular API. If you want to hack it, you can remove the entire { // -- C o n s o l e block in src/bootstrapper.cc, that'll prevent the built-in console from overriding the global template

Re: [v8-users] Questions when adding global object

2018-06-27 Thread zcw
And actually is the consoleDelegate exposed in the .h files in the include directory? I saw it is defined in interface-types.h but if I were to include that, it will lead to a chain of includes from /src.. Am I misunderstanding something? Thanks! On Wednesday, June 27, 2018 at 11:03:35 AM UTC-

Re: [v8-users] Questions when adding global object

2018-06-27 Thread zcw
Hello Jakob, May I get some more directions for using the consoleDelegate? >From d8 files. I saw that we could make a console class and use set consoleDelegate to set console functions. But in our old way, we create a global template for "console" and using setAccessor to append functions to it.

Re: [v8-users] Questions when adding global object

2018-06-25 Thread Jakob Kummerow
On Mon, Jun 25, 2018 at 8:30 PM zcw wrote: > Thank you so much! > I wanted to save the log to a specific file. I tried using the provided > console but couldn't find where it stored the log message. > On a closer look at the code, it seems that you *have to* provide a ConsoleDelegate if you want

Re: [v8-users] Questions when adding global object

2018-06-25 Thread zcw
Thank you so much! I wanted to save the log to a specific file. I tried using the provided console but couldn't find where it stored the log message. And could the ConsoleDelegate work for the release build? On Monday, June 25, 2018 at 6:14:42 PM UTC-7, Jakob Kummerow wrote: > > V8 now provides

Re: [v8-users] Questions when adding global object

2018-06-25 Thread Jakob Kummerow
V8 now provides its own "console" object, with the usual methods installed on it. Does it not serve your needs? You can override it by providing a ConsoleDelegate via the debug interface. The d8 shell (src/d8.cc) provides an example. On Mon, Jun 25, 2018 at 5:52 PM zwc wrote: > Hello, > we are