Re: [v8-users] High CPU usage in v8::internal::Runtime_LoadIC_Miss

2020-07-30 Thread 'Seth Brenith' via v8-users
After trying and failing to generate a small repro (I always got soft deopts instead of the bug), I realized that it's because Leszek already fixed it! https://chromium-review.googlesource.com/c/v8/v8/+/2150586 On Wednesday, July 29, 2020 at 4:23:56 PM UTC-7, Seth Brenith wrote: > > A few brief

Re: [v8-users] High CPU usage in v8::internal::Runtime_LoadIC_Miss

2020-07-29 Thread 'Seth Brenith' via v8-users
A few brief observations based on stepping through the problem area in the debugger: - The generated code for this JS function calls directly into Builtins_LoadICTrampoline_Megamorphic. - However, the feedback vector slot for that load is in monomorphic state. - The map we're cur

Re: [v8-users] High CPU usage in v8::internal::Runtime_LoadIC_Miss

2020-07-27 Thread Camillo Bruni
Hi, Inline Caches are a crucial optimization to speed up property accesses. Usually, you get misses the first time an inline cache is used (for initialization) or when the shape of objects is different (different order, different types of properties).