Re: [v8-users] Clarification on AllowJavascriptExecution

2018-05-14 Thread Jakob Kummerow
Yes. On Fri, May 11, 2018 at 8:47 PM madana gopal wrote: > Thanks, ok. let me go through and update. We have both Script.Run() calls > and vm.runScript() calls in our project. > > So, we have to make sure, we are not making any JS calls, when either > Run() or vm.runScript() going on (as they w

Re: [v8-users] Clarification on AllowJavascriptExecution

2018-05-11 Thread madana gopal
> > Thanks, ok. let me go through and update. We have both Script.Run() calls and vm.runScript() calls in our project. So, we have to make sure, we are not making any JS calls, when either Run() or vm.runScript() going on (as they will involve in code compilation) and need to wait for its co

Re: [v8-users] Clarification on AllowJavascriptExecution

2018-05-11 Thread Jakob Kummerow
It's not about the garbage collection operation being completed. Presumably you have a call to v8::Script::Run() somewhere? When that call returns, you can safely execute other scripts. On Fri, May 11, 2018 at 5:01 PM madana gopal wrote: > Thanks Jakob. > > Below is the backtrace. Here how can

Re: [v8-users] Clarification on AllowJavascriptExecution

2018-05-11 Thread madana gopal
Thanks Jakob. Below is the backtrace. Here how can I identify, when I came out of event loop. Because, we want cleanup calls to get called quickly. *Backtrace:* V8_Fatal 0x5ac3ec3 v8::Function::NewInstance(v8::Local, int, v8::Local*) const* // calling javascript function here* // app code v8::

Re: [v8-users] Clarification on AllowJavascriptExecution

2018-05-11 Thread Jakob Kummerow
A DisallowJavascriptExecution scope indicates that the following code relies on no JavaScript code being executed. If you execute JavaScript code anyway, you will probably cause corruption and subsequent crashes or misbehavior. The CHECK-failure exists to point out the problem early and in an easy-