Re: [blink-dev] Re: [v8-users] Intent to Ship: Numeric separators

2019-04-01 Thread Adam Klein
LGTM3 On Fri, Mar 29, 2019 at 5:37 PM Sam Goto wrote: > LGTM++!! Exciting! > > On Thu, Mar 28, 2019, 12:21 PM 'Mathias Bynens' via blink-dev < > blink-...@chromium.org> wrote: > >> LGTM now that the conflict has been resolved! >> >> On Thu, Mar 28, 2019 at 12:01 PM 'Sathya Gunasekaran' via blink

Re: [blink-dev] Re: [v8-users] Intent to Ship: Numeric separators

2019-03-28 Thread 'Mathias Bynens' via v8-users
LGTM now that the conflict has been resolved! On Thu, Mar 28, 2019 at 12:01 PM 'Sathya Gunasekaran' via blink-dev < blink-...@chromium.org> wrote: > On Thu, Mar 15, 2018 at 2:25 PM Adam Klein wrote: > > > > There's a possible conflict between this feature and another proposal, > Extended Numeric

Re: [blink-dev] Re: [v8-users] Intent to Ship: Numeric separators

2019-03-28 Thread Sathya Gunasekaran
(retrying from @chromium.org account) On Thu, Mar 15, 2018 at 2:25 PM Adam Klein wrote: > > There's a possible conflict between this feature and another proposal, > Extended Numeric Literals. The issue, > https://github.com/tc39/proposal-extended-numeric-literals/issues/7, should > be addresse