Re: [v8-users] V8_31BIT_SMIS_ON_64BIT_ARCH

2020-04-17 Thread Toon Verwaest
On Wed, Apr 15, 2020 at 5:48 PM Alex Kodat wrote: > Ah yes, of course. So a teensy bit better to set > v8_enable_31bit_smis_on_64bit_arch = false if > v8_enable_pointer_compression == false. This would suggest that the default > for v8_enable_31bit_smis_on_64bit_arch (true) is ever so slightly >

Re: [v8-users] V8_31BIT_SMIS_ON_64BIT_ARCH

2020-04-15 Thread Alex Kodat
Ah yes, of course. So a teensy bit better to set v8_enable_31bit_smis_on_64bit_arch = false if v8_enable_pointer_compression == false. This would suggest that the default for v8_enable_31bit_smis_on_64bit_arch (true) is ever so slightly suboptimal (since it's irrelevant if v8_enable_pointer_co

Re: [v8-users] V8_31BIT_SMIS_ON_64BIT_ARCH

2020-04-15 Thread Jakob Kummerow
> > Is there any reason to use V8_31BIT_SMIS_ON_64BIT_ARCH or not when not > using compressed pointers? Smis are faster than any alternative, so 32-bit Smis potentially allow more code to benefit from the Smi advantage than 31-bit Smis. We separated the build flags mostly to be able to track the

[v8-users] V8_31BIT_SMIS_ON_64BIT_ARCH

2020-04-14 Thread Alex Kodat
It appears that the default for v8_enable_31bit_smis_on_64bit_arch has changed from false to true somewhere between 7.7 (our last build for our code) and 8.1 (what we're trying to upgrade to). It appears that if V8_COMPRESS_POINTERS is defined, the setting of V8_31BIT_SMIS_ON_64BIT_ARCH doesn't