[v8-users] v8 crash when reaching heap limit

2022-02-16 Thread Jason Wan
v8 version: 9.6 Hi I was able to reproduce a crash in the example shell and d8 with following script. Before this could be caught by an OOM handler. Also if I set the heap size to be very small (e.g. 2MB) the oom handler could still work. let a = []; for (;;) a.push("test") # # Fatal error in

Re: [v8-users] V8 Crash

2019-07-01 Thread Austin Einter
Thanks Jakob I have realised this. I am now trying integrate chromium headless to my c application. Thanks -Austin On Mon, Jul 1, 2019 at 8:07 PM Jakob Kummerow wrote: > The crash means you called .ToLocalChecked() on an empty MaybeLocal. If > you run a Debug build, you should get line numbers,

Re: [v8-users] V8 Crash

2019-07-01 Thread Jakob Kummerow
The crash means you called .ToLocalChecked() on an empty MaybeLocal. If you run a Debug build, you should get line numbers, so you can find out where in your source code that is. That said, https://webrtc.github.io/adapter/adapter-latest.js looks like it's designed to run in a browser; if that's i

[v8-users] V8 Crash

2019-06-29 Thread Austin Einter
Dear All I am trying run a javascript available at https://webrtc.github.io/adapter/adapter-latest.js using V8. It is crashing with back trace as below. #0 0x7fe928fa5022 in v8::base::OS::Abort() #1 0x7fe9288c9b07 in v8::V8::ToLocalEmpty() #2 0x7fe9288c2a7b in v8::MaybeLocal::ToLoca

Re: [v8-users] v8 crash with weak handles.

2017-07-18 Thread Ben Noordhuis
On Tue, Jul 18, 2017 at 7:08 AM, Jane Chen wrote: > So that was the culprit which caused the crash. Now I ensure only the > owning thread resets the weak handles. > > A question remains: why does a weak handle have to be reset? Isn't the idea > of being weak so that it can be forgotten and clean

Re: [v8-users] v8 crash with weak handles.

2017-07-17 Thread Jane Chen
So that was the culprit which caused the crash. Now I ensure only the owning thread resets the weak handles. A question remains: why does a weak handle have to be reset? Isn't the idea of being weak so that it can be forgotten and cleaned up as part of garbage collections? I get memory corru

Re: [v8-users] v8 crash with weak handles.

2017-07-17 Thread Ben Noordhuis
On Mon, Jul 17, 2017 at 3:15 AM, Jane Chen wrote: > Ben, > > Can PersistentBase::Reset() be called from a different thread from which the > isolate is attached to? Is PersistentBase::Reset() thread-safe? > > Jane No, it's not; almost nothing in V8 is. Create a v8::Locker instance first to ensur

Re: [v8-users] v8 crash with weak handles.

2017-07-17 Thread Zac Hansen
have you run it with address sanitizer turned on? On Sunday, July 16, 2017 at 10:18:36 PM UTC-7, Jane Chen wrote: > > My question is if one thread is calling PersistentBase::Reset() on a weak > handle while another thread is running garbage collection, is it possible > to cause memory corruption

Re: [v8-users] v8 crash with weak handles.

2017-07-16 Thread Jane Chen
My question is if one thread is calling PersistentBase::Reset() on a weak handle while another thread is running garbage collection, is it possible to cause memory corruption? On Sunday, July 16, 2017 at 6:15:16 PM UTC-7, Jane Chen wrote: > > Ben, > > Can PersistentBase::Reset() be called from a

Re: [v8-users] v8 crash with weak handles.

2017-07-16 Thread Jane Chen
Ben, Can PersistentBase::Reset() be called from a different thread from which the isolate is attached to? Is PersistentBase::Reset() thread-safe? Jane On Thursday, July 13, 2017 at 12:59:13 PM UTC-7, Ben Noordhuis wrote: > > On Thu, Jul 13, 2017 at 12:40 AM, Jane Chen > wrote: > > Embedding

Re: [v8-users] v8 crash with weak handles.

2017-07-13 Thread Jane Chen
Ben, I'm not using object groups, just having weak handles in several isolates. Calling LowMemoryNotification to force deep GC avoids the crash. I haven't tried with latest v8 release. Maybe I keep a count of the weak handles in my code. Jane On Thursday, July 13, 2017 at 12:59:13 PM UTC-7,

Re: [v8-users] v8 crash with weak handles.

2017-07-13 Thread Ben Noordhuis
On Thu, Jul 13, 2017 at 12:40 AM, Jane Chen wrote: > Embedding v8 5.3. > > Seeing a crash if I have weak handles in many isolates: > > Thread [51] 27257 [core: 6] (Suspended : Signal : SIGILL:Illegal > instruction) > v8::base::OS::Abort() at platform-posix.cc:240 0x75f078a1 > V8_Fatal() at l

[v8-users] v8 crash with weak handles.

2017-07-12 Thread Jane Chen
Embedding v8 5.3. Seeing a crash if I have weak handles in many isolates: Thread [51] 27257 [core: 6] (Suspended : Signal : SIGILL:Illegal instruction) v8::base::OS::Abort() at platform-posix.cc:240 0x75f078a1 V8_Fatal() at logging.cc:116 0x75f02d88 v8::internal::GlobalHandles::Nod