Re: [v8-users] OnStackReplacement (OSR) Invocation

2015-03-13 Thread Ben Noordhuis
On Fri, Mar 13, 2015 at 7:33 PM, Malek Musleh wrote: > So to be clear, this is for OSR or just invoking crankshaft? In my > mind, I am viewing them as 2 different things (although I guess OSR is > part of crankshaft), the first for optimizing the function as it goes, > and the other trying to reco

Re: [v8-users] OnStackReplacement (OSR) Invocation

2015-03-13 Thread Malek Musleh
So to be clear, this is for OSR or just invoking crankshaft? In my mind, I am viewing them as 2 different things (although I guess OSR is part of crankshaft), the first for optimizing the function as it goes, and the other trying to recompile the function for its next use. Is it that seeing the sa

Re: [v8-users] OnStackReplacement (OSR) Invocation

2015-03-13 Thread Ben Noordhuis
On Fri, Mar 13, 2015 at 6:14 PM, Malek Musleh wrote: > Hi, > > I am trying to get a better understanding of when the OSR optimization > is invoked. As per my understanding, CrankShaft is only invoked for > functions which have been seen at least 2, based on the parameter > kProfilerTicksBeforeOpti

[v8-users] OnStackReplacement (OSR) Invocation

2015-03-13 Thread Malek Musleh
Hi, I am trying to get a better understanding of when the OSR optimization is invoked. As per my understanding, CrankShaft is only invoked for functions which have been seen at least 2, based on the parameter kProfilerTicksBeforeOptimization = 2 in runtime-profiler.cc. But because there might be f