Re: [v8-users] Debugging mksnapshot bus error

2024-08-19 Thread 'Ryan Manuel' via v8-users
Any further thoughts on this? It definitely seems like a bug in V8 to me now. Switching between a call to `fn.call` vs. a call to `fn.apply` should work. I'd be willing to try my hand at resolving the issue, but I'm not really sure where to start. On Tuesday, August 13, 2024 at 4:10:19 PM UTC-5

Re: [v8-users] Debugging mksnapshot bus error

2024-08-13 Thread 'Ryan Manuel' via v8-users
I was able to simplify the code even more and still recreate the error. I've pasted it below. The weird thing is if I change this line: applyDefs.definitions[modulePath].apply(mod.exports, [mod, applyDefs]) to applyDefs.definitions[modulePath].call(mod.exports, mod, applyDefs) Everything work

Re: [v8-users] Debugging mksnapshot bus error

2024-08-13 Thread 'Ryan Manuel' via v8-users
That did resolve the issue, but I'm not 100% positive it's a heap size issue. I was able to whittle my snapshot file down to a much smaller subset (55.1 MB down to 83 KB for the input file) and it still causes the same problem. The updated file is in this gist

Re: [v8-users] Debugging mksnapshot bus error

2024-08-10 Thread Ben Noordhuis
Maybe check if a v8_enable_pointer_compression=false build works okay? It only happens with large snapshots, right? Comrpessed pointers don't work for heap sizes > 4 GB. On Tue, Aug 6, 2024 at 6:45 AM 'Ryan Manuel' via v8-users wrote: > > Ah thanks for the advice. I put the output below of runnin

Re: [v8-users] Debugging mksnapshot bus error

2024-08-05 Thread 'Ryan Manuel' via v8-users
Ah thanks for the advice. I put the output below of running the command below. Any thoughts on what to do next? # # Fatal error in ../../src/common/ptr-compr-inl.h, line 81 # Debug check failed: (tagged & kPtrComprCageBaseMask) == base() || ((static_cast(tagged) & ::i::kSmiTagMask) == ::i::kSmiT

Re: [v8-users] Debugging mksnapshot bus error

2024-08-04 Thread Ben Noordhuis
On Fri, Aug 2, 2024 at 4:17 PM 'Ryan Manuel' via v8-users wrote: > > Oops sorry about that. I meant this issue: > https://issues.chromium.org/issues/345280736 Does the problem manifest with a debug build? What error message, if any, do you get? Debug builds have lots of additional checks enable

Re: [v8-users] Debugging mksnapshot bus error

2024-08-02 Thread 'Ryan Manuel' via v8-users
And the commit where I started seeing the problem was here: https://github.com/v8/v8/commit/8cd1e89fae9005237bba014fad72bddc0434394b On Friday, August 2, 2024 at 9:17:51 AM UTC-5 Ryan Manuel wrote: > Oops sorry about that. I meant this issue: > https://issues.chromium.org/issues/345280736 > > O

Re: [v8-users] Debugging mksnapshot bus error

2024-08-02 Thread 'Ryan Manuel' via v8-users
Oops sorry about that. I meant this issue: https://issues.chromium.org/issues/345280736 On Thursday, August 1, 2024 at 1:16:15 PM UTC-5 Ben Noordhuis wrote: > On Wed, Jul 31, 2024 at 7:58 PM 'Ryan Manuel' via v8-users > wrote: > > > > Hi all, I'm looking into a mksnapshot crash which I logged h

Re: [v8-users] Debugging mksnapshot bus error

2024-08-01 Thread Ben Noordhuis
On Wed, Jul 31, 2024 at 7:58 PM 'Ryan Manuel' via v8-users wrote: > > Hi all, I'm looking into a mksnapshot crash which I logged here: > https://issues.chromium.org/issues/42203948 > > I haven't gotten much traction on the issue itself, but I've been able to > identify the commit that introduced

[v8-users] Debugging mksnapshot bus error

2024-07-31 Thread 'Ryan Manuel' via v8-users
Hi all, I'm looking into a mksnapshot crash which I logged here: https://issues.chromium.org/issues/42203948 I haven't gotten much traction on the issue itself, but I've been able to identify the commit that introduced the bug: https://ch

Re: [v8-users] Debugging mksnapshot bus error

2023-05-20 Thread Ben Noordhuis
On Fri, May 19, 2023 at 2:25 PM Matt Henkes wrote: > > Thanks for the tip! > With your help i was able to run mksnapshot through the debugger. Here's my > vsCode launch.json file for anyone who comes along after me. > > ``` > { > // Use IntelliSense to learn about possible attributes. > // Hover

Re: [v8-users] Debugging mksnapshot bus error

2023-05-19 Thread Matt Henkes
Thanks for the tip! With your help i was able to run mksnapshot through the debugger. Here's my vsCode launch.json file for anyone who comes along after me. ``` { // Use IntelliSense to learn about possible attributes. // Hover to view descriptions of existing attributes. // For more information

Re: [v8-users] Debugging mksnapshot bus error

2023-05-18 Thread Ben Noordhuis
On Wed, May 17, 2023 at 9:29 PM Matt Henkes wrote: > > Hi all, I'm looking into a mksnapshot bus error which i have logged here: > https://bugs.chromium.org/p/v8/issues/detail?id=14007 > > I've been able to identify the commit that introduced the bug: > https://chromium.googlesource.com/v8/v8.gi

[v8-users] Debugging mksnapshot bus error

2023-05-17 Thread Matt Henkes
Hi all, I'm looking into a mksnapshot bus error which i have logged here: https://bugs.chromium.org/p/v8/issues/detail?id=14007 I've been able to identify the commit that introduced the bug: https://chromium.googlesource.com/v8/v8.git/+/91637c25fcdb199526a7060ceca858aeef16bd3d But i could reall