Re: [v8-users] Re: Problem linking when implementing V8InspectorClient

2024-09-30 Thread alex...@gmail.com
Thanks Jakob and Benedikt! Will do. On Monday, September 30, 2024 at 7:44:40 AM UTC-4 Jakob Kummerow wrote: > Benedikt says off-list that he doesn't have an opinion: moving the empty > implementations into v8-inspector.h is fine. > > Feel free to upload a patch. > > > On Mon, Sep 30, 2024 at 10

Re: [v8-users] Re: Problem linking when implementing V8InspectorClient

2024-09-30 Thread Jakob Kummerow
Benedikt says off-list that he doesn't have an opinion: moving the empty implementations into v8-inspector.h is fine. Feel free to upload a patch. On Mon, Sep 30, 2024 at 10:42 AM Jakob Kummerow wrote: > +Benedikt Meurer who made these changes and might > have an opinion. > > > On Sun, Sep 29

Re: [v8-users] Re: Problem linking when implementing V8InspectorClient

2024-09-30 Thread Jakob Kummerow
+Benedikt Meurer who made these changes and might have an opinion. On Sun, Sep 29, 2024 at 12:55 PM alex...@gmail.com wrote: > FWIW, I rebuilt V8 after I made the above change to v8-inspector.h and > discovered that, in fact, there are default implementations of consoleTime > and friends in v8