Re: Severe 7.0.47 startup performance regression

2013-12-06 Thread David Rees
On Thu, Dec 5, 2013 at 12:18 AM, Konstantin Kolinko wrote: > Remove the tomcat7-websocket.jar library if you do not need it. This > library (added in 7.0.47, a JSR-356 Java WebSocket 1.0 implementation) > has a ServletContainerInitializer and thus forces Tomcat to perform > annotation scanning.

Re: Severe 7.0.47 startup performance regression

2013-12-05 Thread Rossen Stoyanchev
On Thu, Dec 5, 2013 at 10:57 AM, Mark Thomas wrote: > On 05/12/2013 14:22, Rossen Stoyanchev wrote: > > On Thu, Dec 5, 2013 at 7:05 AM, Mark Thomas wrote: > > > >> > >> There is also the programmatic interface to WebSockets so once there is > >> a way to disable the SCI, you can use the programm

Re: Severe 7.0.47 startup performance regression

2013-12-05 Thread Mark Thomas
On 05/12/2013 14:22, Rossen Stoyanchev wrote: > On Thu, Dec 5, 2013 at 7:05 AM, Mark Thomas wrote: > >> >> There is also the programmatic interface to WebSockets so once there is >> a way to disable the SCI, you can use the programmatic interface to set >> everything up. > > > Yes, the very exi

Re: Severe 7.0.47 startup performance regression

2013-12-05 Thread Rossen Stoyanchev
On Thu, Dec 5, 2013 at 7:05 AM, Mark Thomas wrote: > > There is also the programmatic interface to WebSockets so once there is > a way to disable the SCI, you can use the programmatic interface to set > everything up. Yes, the very existence of a programmatic interface alternative more or less

Re: Severe 7.0.47 startup performance regression

2013-12-05 Thread Mark Thomas
On 05/12/2013 11:50, Johan Compagner wrote: >> >>> Does anyone know why this wasn't done by using services? (SPI) >>> So that we can directly point to a class that is the websocket or point >> to >>> a class that registers the websockets? >> >> The Java WebSocket 1.0 specification requires this be

Re: Severe 7.0.47 startup performance regression

2013-12-05 Thread Johan Compagner
> > > Does anyone know why this wasn't done by using services? (SPI) > > So that we can directly point to a class that is the websocket or point > to > > a class that registers the websockets? > > The Java WebSocket 1.0 specification requires this behaviour. > > As has been pointed out previously,

Re: Severe 7.0.47 startup performance regression

2013-12-05 Thread Mark Thomas
On 05/12/2013 08:33, Johan Compagner wrote: >> >> >> Good. >> >> Remove the tomcat7-websocket.jar library if you do not need it. This >> library (added in 7.0.47, a JSR-356 Java WebSocket 1.0 implementation) >> has a ServletContainerInitializer and thus forces Tomcat to perform >> annotation scann

Re: Severe 7.0.47 startup performance regression

2013-12-05 Thread Johan Compagner
> > > Good. > > Remove the tomcat7-websocket.jar library if you do not need it. This > library (added in 7.0.47, a JSR-356 Java WebSocket 1.0 implementation) > has a ServletContainerInitializer and thus forces Tomcat to perform > annotation scanning. > > Does anyone know why this wasn't done by us

Re: Severe 7.0.47 startup performance regression

2013-12-05 Thread Konstantin Kolinko
2013/12/5 David Rees : > Since upgrading to 7.0.47 from 7.0.42, I've seen a very severe > performance hit during startup. > > One Tomcat instance with a lot of webapps slowed down from ~33 seconds > to ~180 seconds. It appears to be related to jar-scanning - If I > change catalina.properties' > tom

Severe 7.0.47 startup performance regression

2013-12-04 Thread David Rees
Since upgrading to 7.0.47 from 7.0.42, I've seen a very severe performance hit during startup. One Tomcat instance with a lot of webapps slowed down from ~33 seconds to ~180 seconds. It appears to be related to jar-scanning - If I change catalina.properties' tomcat.util.scan.DefaultJarScanner.jars