Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-27 Thread Osipov, Michael
Am 2020-05-27 um 12:35 schrieb Mark Thomas: > This then opens up an interesting question of whether to bother reading > *any* of the request body if Tomcat knows it is going to close the > connection before reading all of it. Based on what you have observed, > would earlier closure of the connecti

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-27 Thread Oleg Kalnichevski
On Wed, 2020-05-27 at 14:47 +0200, Osipov, Michael wrote: > Am 2020-05-27 um 12:35 schrieb Mark Thomas: > > On 27/05/2020 10:59, Osipov, Michael wrote: > > > > > > > > > Am 2020-05-27 um 10:51 schrieb Mark Thomas: > > > > On 22/05/2020 22:59, Osipov, Michael wrote: > > > > > > > > > > > > > >

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-27 Thread Osipov, Michael
Am 2020-05-27 um 12:35 schrieb Mark Thomas: On 27/05/2020 10:59, Osipov, Michael wrote: Am 2020-05-27 um 10:51 schrieb Mark Thomas: On 22/05/2020 22:59, Osipov, Michael wrote: I found one issue with HttpClient and Tomcat via HTTP/1.1. I have decrypted the TLS traffic [1]. I can see that

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-27 Thread Mark Thomas
On 27/05/2020 10:59, Osipov, Michael wrote: > > > Am 2020-05-27 um 10:51 schrieb Mark Thomas: >> On 22/05/2020 22:59, Osipov, Michael wrote: >> >> >> >>> I found one issue with HttpClient and Tomcat via HTTP/1.1. I have >>> decrypted the TLS traffic [1]. I can see that HttpClient sends the >>> h

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-27 Thread Osipov, Michael
Am 2020-05-27 um 10:51 schrieb Mark Thomas: On 22/05/2020 22:59, Osipov, Michael wrote: I found one issue with HttpClient and Tomcat via HTTP/1.1. I have decrypted the TLS traffic [1]. I can see that HttpClient sends the headers also with a 4 KiB large chunk of the ZIP file. In return a To

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-27 Thread Mark Thomas
On 22/05/2020 22:59, Osipov, Michael wrote: > I found one issue with HttpClient and Tomcat via HTTP/1.1. I have > decrypted the TLS traffic [1]. I can see that HttpClient sends the > headers also with a 4 KiB large chunk of the ZIP file. In return a > Tomcats send the 401 response with: >> Keep-

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-26 Thread Osipov, Michael
Am 2020-05-22 um 13:26 schrieb Mark Thomas: On 21/05/2020 23:30, Osipov, Michael wrote: Output will be sent privately. Got it. Tx. Looking at the direct case. It looks like you have debug logging enabled for everything. You only need it for the org.apache.coyote.http2 package. grep "http

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-22 Thread Osipov, Michael
Am 2020-05-22 um 18:51 schrieb [ext] Osipov, Michael: Am 2020-05-22 um 13:26 schrieb Mark Thomas: On 21/05/2020 23:30, Osipov, Michael wrote: Output will be sent privately. Got it. Tx. Looking at the direct case. It looks like you have debug logging enabled for everything. You only n

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-22 Thread Osipov, Michael
Am 2020-05-22 um 13:26 schrieb Mark Thomas: On 21/05/2020 23:30, Osipov, Michael wrote: Output will be sent privately. Got it. Tx. Looking at the direct case. It looks like you have debug logging enabled for everything. You only need it for the org.apache.coyote.http2 package. grep "htt

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-22 Thread Mark Thomas
On 21/05/2020 23:30, Osipov, Michael wrote: > Output will be sent privately. Got it. Tx. Looking at the direct case. It looks like you have debug logging enabled for everything. You only need it for the org.apache.coyote.http2 package. grep "http2" catalina.2020-05-21.log | less gives a nic

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-21 Thread Osipov, Michael
Am 2020-05-21 um 23:36 schrieb Mark Thomas: On 21/05/2020 21:45, Osipov, Michael wrote: Am 2020-05-21 um 11:02 schrieb Mark Thomas: On 20/05/2020 17:57, Osipov, Michael wrote: Is there an option to proxy via HTTP/2? That should be able to handle these sorts of situations more gracefully.

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-21 Thread Mark Thomas
On 21/05/2020 21:45, Osipov, Michael wrote: > > > Am 2020-05-21 um 11:02 schrieb Mark Thomas: >> On 20/05/2020 17:57, Osipov, Michael wrote: >> Is there an option to proxy via HTTP/2? That should be able to handle these sorts of situations more gracefully. >>> >>> This seems to be broke

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-21 Thread Osipov, Michael
Am 2020-05-21 um 11:02 schrieb Mark Thomas: On 20/05/2020 17:57, Osipov, Michael wrote: Is there an option to proxy via HTTP/2? That should be able to handle these sorts of situations more gracefully. This seems to be broken for some reason in another way: What now? Turn on debug lo

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-21 Thread Mark Thomas
On 20/05/2020 17:57, Osipov, Michael wrote: >> Is there an option to proxy via HTTP/2? That should be able to handle >> these sorts of situations more gracefully. > > This seems to be broken for some reason in another way: > What now? Turn on debug logging for o.a.coyote.http2 for both. For

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-20 Thread Osipov, Michael
Am 2020-05-20 um 15:07 schrieb Mark Thomas: On 20/05/2020 11:05, Osipov, Michael wrote: My questions are: * Why is parseRequestLine printing the request body? Because it is the contents of the input buffer that is being logged, not just the headers. * Can someone confirm the erratic behav

Re: maxSwallowSize and misbehaving clients (e.g., mod_proxy_http)

2020-05-20 Thread Mark Thomas
On 20/05/2020 11:05, Osipov, Michael wrote: > My questions are: > * Why is parseRequestLine printing the request body? Because it is the contents of the input buffer that is being logged, not just the headers. > * Can someone confirm the erratic behavior of HTTPd's module? I'm not sure it is