Re: context root with relative path

2016-05-09 Thread David kerber
On 5/9/2016 11:34 AM, Dimitar Valov wrote: Hi, Have you decided if the proposed fix make since? If the corner case is :/, then it can be handled as well, not to remove the slash in case the previous char is :. IMO, the correct result for this case would most likely be to INCLUDE the trailing

Re: context root with relative path

2016-05-09 Thread Dimitar Valov
Hi, Have you decided if the proposed fix make since? If the corner case is :/, then it can be handled as well, not to remove the slash in case the previous char is :. Best Regards, Dimitar On Thu, Apr 21, 2016 at 7:12 PM, Leo Donahue wrote: > On Apr 21, 2016 10:38 AM, "David kerber" wrote: >

Re: context root with relative path

2016-04-21 Thread Leo Donahue
On Apr 21, 2016 10:38 AM, "David kerber" wrote: > > On 4/21/2016 11:33 AM, Leo Donahue wrote: >> >> Chris, >> >> On Apr 21, 2016 9:15 AM, "Christopher Schultz" < ch...@christopherschultz.net> >> wrote: >>> >>> >>> I don't have a Windows machine handy right this minute, but from my >>> previous exp

Re: context root with relative path

2016-04-21 Thread David kerber
On 4/21/2016 11:33 AM, Leo Donahue wrote: Chris, On Apr 21, 2016 9:15 AM, "Christopher Schultz" wrote: I don't have a Windows machine handy right this minute, but from my previous experience, "C:" means "the current working directory on the C drive, from this process's perspective. For insta

Re: context root with relative path

2016-04-21 Thread Leo Donahue
Chris, On Apr 21, 2016 9:15 AM, "Christopher Schultz" wrote: > > I don't have a Windows machine handy right this minute, but from my > previous experience, "C:" means "the current working directory on the C > drive, from this process's perspective. > > For instance: > > D:\> DIR C:\ > ... > Progr

Re: context root with relative path

2016-04-21 Thread Christopher Schultz
Konstantin, On 4/20/16 8:31 AM, Konstantin Kolinko wrote: > 2016-04-19 22:42 GMT+03:00 Mark Thomas : >> On 19/04/2016 19:38, Dimitar Valov wrote: >>> All static resources such as index.html will not be found when application >>> is added with , for example tomcat >>> is put inside the application'

Re: context root with relative path

2016-04-20 Thread David kerber
On 4/20/2016 12:07 PM, Dimitar Valov wrote: System.out.println(new File("C:").exists()); prints true, so I guess it works okay. All that means is that it does something. That doesn't means it's doing the correct thing. That *should* be checking the existence of the "current" directory, whic

RE: context root with relative path

2016-04-20 Thread Caldarale, Charles R
> From: Dimitar Valov [mailto:dimitar.va...@gmail.com] > Subject: Re: context root with relative path > System.out.println(new File("C:").exists()); prints true, so I guess it > works okay. Depends on the definition of "okay"; that only tells us that the C drive

Re: context root with relative path

2016-04-20 Thread Dimitar Valov
System.out.println(new File("C:").exists()); prints true, so I guess it works okay. On Wed, Apr 20, 2016 at 3:31 PM, Konstantin Kolinko wrote: > 2016-04-19 22:42 GMT+03:00 Mark Thomas : > > On 19/04/2016 19:38, Dimitar Valov wrote: > >> All static resources such as index.html will not be found w

Re: context root with relative path

2016-04-20 Thread Konstantin Kolinko
2016-04-19 22:42 GMT+03:00 Mark Thomas : > On 19/04/2016 19:38, Dimitar Valov wrote: >> All static resources such as index.html will not be found when application >> is added with , for example tomcat >> is put inside the application's META-INF. >> >> I've drilled down that the AbstractFileResource

RE: context root with relative path

2016-04-19 Thread Caldarale, Charles R
> From: Mark Thomas [mailto:ma...@apache.org] > Subject: Re: context root with relative path On 19/04/2016 19:38, Dimitar Valov wrote: > All static resources such as index.html will not be found when application > is added with , for example tomcat > is put inside the applica

Re: context root with relative path

2016-04-19 Thread David kerber
On 4/19/2016 4:13 PM, Dimitar Valov wrote: Hi Mark, Yes, it is sensitive, that's why I'm suggesting such simple solution. For me the issues comes because of AbstractFileResourceSet::file -> absPath = absPath.substring(absoluteBase.length() + 1); and if (!canPath.equals(absPath)). This + 1 should

Re: context root with relative path

2016-04-19 Thread Dimitar Valov
Hi Mark, Yes, it is sensitive, that's why I'm suggesting such simple solution. For me the issues comes because of AbstractFileResourceSet::file -> absPath = absPath.substring(absoluteBase.length() + 1); and if (!canPath.equals(absPath)). This + 1 should account for the /. However we cannot count o

Re: context root with relative path

2016-04-19 Thread Mark Thomas
On 19/04/2016 19:38, Dimitar Valov wrote: > All static resources such as index.html will not be found when application > is added with , for example tomcat > is put inside the application's META-INF. > > I've drilled down that the AbstractFileResourceSet class is responsible for > this behaviour,