RE: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-06-01 Thread Hedrick, Brooke - 43
> -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Friday, June 01, 2012 11:06 AM > > > By the way: > > 53254 (1340160): > Add in the ability to purge connections from the pool (fhanik) > > https://issues.apache.org/bugzil

RE: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-06-01 Thread Caldarale, Charles R
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: Question about resetting datasources and changes to the > BasicDataSource.close() method > Locking "this" makes sure that the thread's local copy of > whatever-you-are-getting is

Re: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-06-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brooke, On 6/1/12 11:54 AM, Hedrick, Brooke - 43 wrote: >> -Original Message- From: Christopher Schultz >> [mailto:ch...@christopherschultz.net] Sent: Thursday, May 31, >> 2012 5:23 PM > > That's what I will submit to commons-dbcp, then. > >

Re: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-06-01 Thread Konstantin Kolinko
2012/5/30 Hedrick, Brooke - 43 : >(...) > > Next, I looked at the new datasource org.apache.tomcat.jdbc.pool.DataSource.   > I have not found any methods to close/reset the pools and the JMX attributes > are readonly.  This prevents us both from resetting and resizing our > connection pools. > B

RE: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-06-01 Thread Hedrick, Brooke - 43
> -Original Message- > From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Sent: Thursday, May 31, 2012 5:23 PM > > > Yup: the solution is to just synchronize all the methods. If restart() is > synchronized, it will only operate while other methods are not actively > checkin

Re: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-05-31 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brooke, On 5/31/12 3:53 PM, Hedrick, Brooke - 43 wrote: > Are you just concerned about the restart() being called by more > than 1 thread since the restarting member variable isn't > protected? Yes. > If so, I was looking for a short term, simple, f

RE: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-05-31 Thread Hedrick, Brooke - 43
> -Original Message- > From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Sent: Thursday, May 31, 2012 2:27 PM > To: Tomcat Users List > Subject: Re: Question about resetting datasources and changes to the > BasicDataSource.close() method > > -

Re: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-05-31 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brooke, On 5/31/12 11:56 AM, Hedrick, Brooke - 43 wrote: > /** * Not used currently */ protected boolean restarting = false; > // bth new > > public void restart() { try { restarting = true; // bth new try { > close(); } finally { restarting = fals

Re: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-05-31 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brooke, On 5/31/12 11:51 AM, Hedrick, Brooke - 43 wrote: > Our release cycle has us releasing many applications on many JVMs > every week. From time to time, these applications have issues in > them where someone has made a code change that require

RE: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-05-31 Thread Hedrick, Brooke - 43
59.1322 Cel: 515.314.8953 -Original Message- From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] Sent: Thursday, May 31, 2012 8:19 AM To: Tomcat Users List Subject: Re: Question about resetting datasources and changes to the BasicDataSource.close() method 2012/5/30 Hedrick, Brooke - 43 : >

RE: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-05-31 Thread Hedrick, Brooke - 43
: Re: Question about resetting datasources and changes to the BasicDataSource.close() method -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brooke, On 5/30/12 3:31 PM, Hedrick, Brooke - 43 wrote: > How are others dynamically resetting/resizing their database > connection pools when necessary?

Re: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-05-31 Thread Konstantin Kolinko
2012/5/30 Hedrick, Brooke - 43 : >(...) > > So far, my options point to making changes to the BasicDataSource to provide > a way to set closed=false or make the private method below public with a > change to set closed=false. > >    /** >     * Not used currently >     */ >    private void restar

Re: Question about resetting datasources and changes to the BasicDataSource.close() method

2012-05-30 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brooke, On 5/30/12 3:31 PM, Hedrick, Brooke - 43 wrote: > How are others dynamically resetting/resizing their database > connection pools when necessary? Quick question about all this: why do you need to do any more dynamic-resizing than dbcp already

Question about resetting datasources and changes to the BasicDataSource.close() method

2012-05-30 Thread Hedrick, Brooke - 43
How are others dynamically resetting/resizing their database connection pools when necessary? Background: I am running into some issues with how we manage datasources due to changes in Tomcat/commons-dbcp. We are just now beginning to move some of our applications to Tomcat 7.0.21 from Tomcat