Re: Inconsistency in AprEndpoint.java and JIoEndpoint.java

2012-02-29 Thread Mark Thomas
On 29/02/2012 04:51, Ken Cheung wrote: > Because both of them are performing the same function. However, one > of them (AprEndpoint.java:1057:1058) you typecast "SocketWrapper" to > "Long" and check if "socket.async" is true while another one > (JloEndpoint.java) you just typecast it to "Socket" an

RE: Inconsistency in AprEndpoint.java and JIoEndpoint.java

2012-02-28 Thread Caldarale, Charles R
> From: Ken Cheung [mailto:msrbugzi...@gmail.com] > Subject: Re: Inconsistency in AprEndpoint.java and JIoEndpoint.java > you typecast "SocketWrapper" to "Long" and check if "socket.async" > is true while another one (JloEndpoint.java) you just typec

Re: Inconsistency in AprEndpoint.java and JIoEndpoint.java

2012-02-28 Thread Ken Cheung
Because both of them are performing the same function. However, one of them (AprEndpoint.java:1057:1058) you typecast "SocketWrapper" to "Long" and check if "socket.async" is true while another one (JloEndpoint.java) you just typecast it to "Socket" and execute the same piece of codes. The check

Re: Inconsistency in AprEndpoint.java and JIoEndpoint.java

2012-02-28 Thread Mark Thomas
On 28/02/2012 16:40, Ken Cheung wrote: > I observed some code clones in Tomcat and found inconsistent code. > Could anyone explain why this is not a bug? Yes. Perhaps you'd like to explain your basis for assuming it is a bug. Mark

Inconsistency in AprEndpoint.java and JIoEndpoint.java

2012-02-28 Thread Ken Cheung
I observed some code clones in Tomcat and found inconsistent code. Could anyone explain why this is not a bug? /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java 1048try { 1049Thread.sleep(1000); 1050} catch (Interrupted