Re: Is resource-ref really needed?

2009-09-02 Thread Robert Whane
On Wed, Sep 2, 2009 at 1:22 AM, Martin Gainty wrote: > > the fellow who wrote it was writing code for at least 2 other projects > it may have been a case of where he accomplished 75% of what was needed then > some other task got moved to his front burner I hear you, we've all been there a couple o

Re: Is resource-ref really needed?

2009-09-01 Thread Robert Whane
On Tue, Sep 1, 2009 at 5:07 AM, Martin Gainty wrote: > both the entries and web.xml reference > ContextResource > > //WebAnnotationSet.java >     protected static void addResource(Context context, Resource annotation) > { > > //if the annotation is > DataSource,ConnectionFactory,QueueConnectionFa

Re: Is resource-ref really needed?

2009-09-01 Thread Robert Whane
On Tue, Sep 1, 2009 at 5:41 PM, Christopher Schultz wrote: >On 8/31/2009 6:19 PM, Robert Whane wrote: >> Okay, it's optional, so I don't HAVE to use, but if I DO use it, what >> possible advantage does it have? > > Adherence to the Servlet Specification? Which

Re: Is resource-ref really needed?

2009-08-31 Thread Robert Whane
On Mon, Aug 31, 2009 at 1:50 PM, Martin Gainty wrote: > > https://issues.apache.org/bugzilla/show_bug.cgi?id=47769 That's a very good start. Thanks! There is however still one vital piece of information missing in the proposed documentation update. It now clearly states that resource-ref in the w

Re: Is resource-ref really needed?

2009-08-31 Thread Robert Whane
On Mon, Aug 31, 2009 at 2:27 AM, Martin Gainty wrote: > you can enter a documentation change to correct either > 1)duplicate behaviour of ApplicationContext.xml by web.xml > > 2)or make the documentation a bit clearer on what is required and what is > optional That's not a bad idea really, but

Re: Is resource-ref really needed?

2009-08-30 Thread Robert Whane
Hi, On Mon, Aug 31, 2009 at 1:12 AM, Martin Gainty wrote: > > mandatory: define the attributes in in > applicationContext.xml > OR > optionally define the resource attributes or > in web.xml > > http://proteinbank.vbi.vt.edu/tomcat-docs/config/context.html#Resource%20Definitions Thanks for t

Is resource-ref really needed?

2009-08-30 Thread Robert Whane
Hi, I'm using Tomcat 6.20 and have configured a datasource in META-INF/context.xml, which looks basically like this: For brevity I have removed some attributes, but this is basically my definition. I can now just directly look up this DataSource using JDNI under the java:comp/env/jdbc/myd