Re: Inconsistency in AprEndpoint.java and JIoEndpoint.java

2012-02-28 Thread Ken Cheung
and execute the same piece of codes. The checking of "socket.async" is missing here and therefore it could be a bug. On 29 Feb, 2012, at 2:45 AM, Mark Thomas wrote: > On 28/02/2012 16:40, Ken Cheung wrote: >> I observed some code clones in Tomcat and found inconsistent co

Inconsistency in AprEndpoint.java and JIoEndpoint.java

2012-02-28 Thread Ken Cheung
I observed some code clones in Tomcat and found inconsistent code. Could anyone explain why this is not a bug? /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java 1048try { 1049Thread.sleep(1000); 1050} catch (Interrupted

Inconsistency in AjpMessage.java

2012-02-28 Thread Ken Cheung
I observed some code clones in Tomcat and found inconsistent code. Could anyone explain why this is not a bug? /tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java 195if (cc == null) { 196log.error(sm.getString("ajpmessage.null"), 197new Nu