Re: TriggerFragment/FormFragment not working properly in 5.4.5

2020-02-25 Thread Ilya Obshadko
There's a bug about it which is 1 year old already: https://issues.apache.org/jira/projects/TAP5/issues/TAP5-2604 But the issue itself was introduced by Howard's commit back in 2015. I'm quite surprised by the fact that nobody ran into this issue since then. FormFragment is not heavily used? On

Re: TriggerFragment/FormFragment not working properly in 5.4.5

2020-02-25 Thread Ilya Obshadko
I think I found the reason: when *events.formfragment.changeVisibility* is triggered, all 'input' descendants of the fragment are indiscriminately updated, including t:formdata fields which may belong to nested fragments. This forces Tapestry to treat them as enabled during a subsequent submission,

Re: TriggerFragment/FormFragment not working properly in 5.4.5

2020-01-07 Thread Ben Weidig
Hi Thiago, with "from the outside" I meant triggering them manually, sorry. But if I find some time, I'll check it out again, and if I can fix it on Tapestry's side, I'll create a pull request. Ben On Wed, Jan 8, 2020 at 1:52 AM Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: > Do y

Re: TriggerFragment/FormFragment not working properly in 5.4.5

2020-01-07 Thread Thiago H. de Paula Figueiredo
Do you happen to know how to fix this from the outside? If you create a pull request, after testing, I'll happily apply it. On Mon, Jan 6, 2020 at 5:26 AM Ben Weidig wrote: > Hi, > > we ran into some issues with nested fragments and disabled fields, too. > Instead of using the mixin we ended up

Re: TriggerFragment/FormFragment not working properly in 5.4.5

2020-01-06 Thread Ilya Obshadko
The amount of code broken by this issue is substantial. I'd rather consider maintaining my own fork from 5.4-beta6 (outdated dependencies is my only concern about this version, everything else works perfectly). On Mon, Jan 6, 2020 at 4:26 PM Ben Weidig wrote: > Hi, > > we ran into some issues wi

Re: TriggerFragment/FormFragment not working properly in 5.4.5

2020-01-06 Thread Ben Weidig
Hi, we ran into some issues with nested fragments and disabled fields, too. Instead of using the mixin we ended up triggering the fragments ourselves with CoffeeScript: define ['jquery', 't5/core/events', 't5/core/form-fragment'], ($, events) -> fieldChange = (event) -> $('#formFragm

Re: TriggerFragment/FormFragment not working properly in 5.4.5

2020-01-05 Thread Ilya Obshadko
Also: nested FormFragment support appears broken. Page initialization somehow triggers the code in t5/core/form-fragment module, that effectively disables input fields and form controls in visible fragments. On a bright side: Loop/AjaxFormLoop issues that prevented me from upgrade to release versi

Re: TriggerFragment/FormFragment not working properly in 5.4.5

2020-01-03 Thread Ilya Obshadko
I found the place where the old behavior was possibly broken: https://issues.apache.org/jira/browse/TAP5-2308 Did anyone else encounter this problem as well? On Fri, Jan 3, 2020 at 10:04 PM Ilya Obshadko wrote: > Disclaimer: I'm doing a 'long overdue' upgrade from 5.4-beta6, so I might > be miss

TriggerFragment/FormFragment not working properly in 5.4.5

2020-01-03 Thread Ilya Obshadko
Disclaimer: I'm doing a 'long overdue' upgrade from 5.4-beta6, so I might be missing something obvious. Symptoms: - I'm using a checkbox with *TriggerFragment* mixin and *FormFragment* component - I'm getting a JavaScript error in Chrome console: RequireJS error: require: Invalid conf