You are right, that pattern is not doing what it's supposed to do. I
reopened the issue and attached a new patch.
And email addresses containing an underscore are allowed. I put that
into the patch too.
Uli
Christian Dutaret schrieb:
Seems there is a bug in the new pattern:
public static
Seems there is a bug in the new pattern:
public static final String USERNAME_PATTERN =
"([da-z]+[-._+&'])*[da-z]+";
should be:
public static final String USERNAME_PATTERN =
"([\\da-z]+[-._+&'])*[\\da-z]+";
or:
public static final String USERNAME_PATTERN =
"([0-9a-z]+[-._+&'])*[
GMT +1
Uli
Christian Dutaret schrieb:
Thx for the swift fix. I've patched my code to use the suggested new
validator instead of the previous one (I've copied the one that was
committed earlier today). I'll let you know if any new problem arise.
(seems this was a short night sleep for both of y
Thx for the swift fix. I've patched my code to use the suggested new
validator instead of the previous one (I've copied the one that was
committed earlier today). I'll let you know if any new problem arise.
(seems this was a short night sleep for both of you guys, or is it some time
zone illusion?
thx for all - i'll see if i can have the test do performance check,
and commit asap
Ulrich Stärk wrote:
I Just created a JIRA report and a fix for that problem.
https://issues.apache.org/jira/browse/TAPESTRY-1857
Uli
Ulrich Stärk schrieb:
I just came to the same conclusion. The problem is with
I Just created a JIRA report and a fix for that problem.
https://issues.apache.org/jira/browse/TAPESTRY-1857
Uli
Ulrich Stärk schrieb:
I just came to the same conclusion. The problem is with the
([-_\\.]*[A-Za-z0-9]+)* part of the regexp in the user as well as the
domain part. Apart from that
I now remember where I saw that one before. Jeffrey Friedl included it
in "Mastering Regular Expressions". In print! :)
Uli
andyhot schrieb:
hmmm - nice report - looks like that specific email regex is problematic
when
the given string is not email and contains lots of chars (>25-30 result
in
I just came to the same conclusion. The problem is with the
([-_\\.]*[A-Za-z0-9]+)* part of the regexp in the user as well as the
domain part. Apart from that this regexp will reject email addresses
which are valid according to RFC 3696 like [EMAIL PROTECTED]
Uli
andyhot schrieb:
hmmm - nice
hmmm - nice report - looks like that specific email regex is problematic
when
the given string is not email and contains lots of chars (>25-30 result
in more than 10 iterations
according to RegexBuddy) - we'll probably have to find a better regex i
guess
http://www.ex-parrot.com/~pdw/Mail-
