Re: Comment in Tapestry 5 TML

2009-10-23 Thread Howard Lewis Ship
I think an Asset, for compatibility down the line; there may be changes to the public RenderSupport API and the (internal?) DocumentLinker API. On Fri, Oct 23, 2009 at 1:54 PM, Robert Zeigler wrote: > Would the href be a string, or would it be an Asset? > > Robert > > On Oct 22, 2009, at 10/225:3

Re: Comment in Tapestry 5 TML

2009-10-23 Thread Robert Zeigler
Would the href be a string, or would it be an Asset? Robert On Oct 22, 2009, at 10/225:34 PM , Howard Lewis Ship wrote: Just make them all final and we're onto something. On Thu, Oct 22, 2009 at 2:08 PM, Andreas Andreou wrote: Hey, that used to be called RelationBean in the old days :) I

Re: Comment in Tapestry 5 TML

2009-10-22 Thread Howard Lewis Ship
Just make them all final and we're onto something. On Thu, Oct 22, 2009 at 2:08 PM, Andreas Andreou wrote: > Hey, that used to be called RelationBean in the old days :) > > It contained: > >    /** The target URL of the resource. */ >    private String _href; > >    /** Specifies on what device t

Re: Comment in Tapestry 5 TML

2009-10-22 Thread Andreas Andreou
Hey, that used to be called RelationBean in the old days :) It contained: /** The target URL of the resource. */ private String _href; /** Specifies on what device the document will be displayed. */ private String _media; /** Defines the relationship between the current docu

Re: Comment in Tapestry 5 TML

2009-10-22 Thread Howard Lewis Ship
So now we're up to media, condition (for IE) and perhaps title? Probably time to define a parameters object with all those properties. On Thu, Oct 22, 2009 at 1:47 PM, cordenier christophe wrote: > Now we are talking about RenderSupport and CSS inclusion, would it also > possible to add the 'titl

Re: Comment in Tapestry 5 TML

2009-10-22 Thread cordenier christophe
Now we are talking about RenderSupport and CSS inclusion, would it also possible to add the 'title' attribute programmatically ? 2009/10/22 Andreas Andreou > Yea, I recently went in a similar route in T4... see > > https://svn.apache.org/repos/asf/tapestry/tapestry4/trunk/tapestry-framework/src/

Re: Comment in Tapestry 5 TML

2009-10-22 Thread Andreas Andreou
Yea, I recently went in a similar route in T4... see https://svn.apache.org/repos/asf/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/html/Style.jwc and specifically the parameter "ieCondition" On Thu, Oct 22, 2009 at 10:03 PM, Howard Lewis Ship wrote: > Actually, what I

Re: Comment in Tapestry 5 TML

2009-10-22 Thread Howard Lewis Ship
Actually, what I'd like to do is open up the API defined by RenderSupport to make it easy to specify that a CSS file is for IE. It could generate the necessary comment around the the script tag for you. Perhaps include an additional annotation for including JavaScript resources with the necessary q

Re: Comment in Tapestry 5 TML

2009-10-22 Thread cordenier christophe
Well i know my Post was about a detail, but generally even if the problem is really Minor (in our case to allow IE hacks :), I think it make sense to fix it, especially when the fix is obvious. But, I will follow your advise and develop a LeComment component... Christophe. 2009/10/22 Andreas A

Re: Comment in Tapestry 5 TML

2009-10-22 Thread Andreas Andreou
In fact the comment string shouldn't contain -- at all as per the specs... it makes browsers think the comment has ended Anyway, i guess you could write a custom component IeComment to handle this and add an improvement request in JIRA if you think the Comment class should be changed On Thu, Oct