Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-17 Thread Felix Gonschorek
Am 17.04.2012 10:06, schrieb Lance Java: > That just flags that you don't have enough test coverage then ;) haha, you got me ;) > Running through the object reflectively won't work. In the case of > List the generic type is lost at runtime through type erasure. you're right. more unit tests it

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-17 Thread Lance Java
That just flags that you don't have enough test coverage then ;) Running through the object reflectively won't work. In the case of List the generic type is lost at runtime through type erasure.

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-17 Thread Felix Gonschorek
Am 17.04.2012 09:32, schrieb Lance Java: > A simpler option could be to serialize the data to a temp OutputStream > instead of checking instanceof Serializable. yeah, but as i wrote: you wont catch nested non serializable data this way, if it is not instantiated. @SessionState private Cart cart;

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-17 Thread Lance Java
A simpler option could be to serialize the data to a temp OutputStream instead of checking instanceof Serializable.

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-17 Thread Felix Gonschorek
Am 16.04.2012 09:44, schrieb Lance Java: > I think that SeleniumTestCase should inject a Session implementation that > fails when setAttribute() is called with a non-Serializable object so that > we can catch this in the future that would be a start, but you won't catch nested (uninitialized, non

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-16 Thread Thiago H. de Paula Figueiredo
On Sun, 15 Apr 2012 09:23:55 -0300, Felix Gonschorek wrote: hi thiago, Hi, Felix! it's not me persisting the model ;-) - it's the Tree component: org.apache.tapestry5.corelib.components.Tree, Line 113: @Persist private TreeExpansionModel defaultTreeExpansionModel; Ouch! I sho

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-16 Thread Lance Java
I think that SeleniumTestCase should inject a Session implementation that fails when setAttribute() is called with a non-Serializable object so that we can catch this in the future

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-15 Thread Felix Gonschorek
Am 15.04.2012 04:25, schrieb Kalle Korhonen: > Sounds reasonable to me, please open a jira. https://issues.apache.org/jira/browse/TAP5-1905 -- Netzgut Unternehmergesellschaft (haftungsbeschränkt) Kirchstr. 18 69115 Heidelberg Telefon: +49 6221 39298 51 Telefax: +49 6221 39298 59 E-Mail: fe..

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-15 Thread Felix Gonschorek
Am 15.04.2012 14:23, schrieb Felix Gonschorek: > i will try to fix this issue for me and implement a tree expansion model > that extends the default expansion model and adds a serializable > interface. will get back to the list with results. confirmed: it works. example serializable model: import

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-15 Thread Felix Gonschorek
Am 15.04.2012 13:52, schrieb Thiago H. de Paula Figueiredo: > Why are you persisting TreeExpansionModels in the session? I'd avoid that. hi thiago, it's not me persisting the model ;-) - it's the Tree component: org.apache.tapestry5.corelib.components.Tree, Line 113: @Persist private Tr

Re: Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-14 Thread Kalle Korhonen
Sounds reasonable to me, please open a jira. Kalle On Sat, Apr 14, 2012 at 5:07 PM, Felix Gonschorek wrote: > Hi all, > > i'am currently trying to improve our tapestry application framework to > support session persistence across server restarts (and maybe across > multiple nodes in our server

Not serializable: org.apache.tapestry5.tree.TreeExpansionModel

2012-04-14 Thread Felix Gonschorek
Hi all, i'am currently trying to improve our tapestry application framework to support session persistence across server restarts (and maybe across multiple nodes in our server farm in the future). i managed to made it to change all our own business objects that are stored in the session to imple