Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-25 Thread Ulrich Stärk
What exactly do you have in mind with the filter attribute? Because I could think of situations where you might want to import the same file for different browser versions. Uli Howard Lewis Ship schrieb: I'm afraid its time to go for something a bit more structured: @ImportJavaScript({ @Im

Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-25 Thread Thiago H. de Paula Figueiredo
Em Wed, 25 Nov 2009 19:21:07 -0200, Howard Lewis Ship escreveu: I'm afraid its time to go for something a bit more structured: @ImportJavaScript({ @Import("classpath:foo.js" filter="IE5" combine=false), @Import("context:bar.js")}) public class MyJSComponent ... Looks good to me. I just

Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-25 Thread Howard Lewis Ship
I'm afraid its time to go for something a bit more structured: @ImportJavaScript({ @Import("classpath:foo.js" filter="IE5" combine=false), @Import("context:bar.js")}) public class MyJSComponent ... ... also the term "import" is much more accurate than "include". This raises some ambiguities

Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-24 Thread Thiago H. de Paula Figueiredo
Em Tue, 24 Nov 2009 18:25:10 -0200, Howard Lewis Ship escreveu: I'm picturing this as a new form of the @IncludeJavascript annotation that allows new options to be included, such as browser type (i.e., build that comment thingey around the

Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-24 Thread Howard Lewis Ship
I'm picturing this as a new form of the @IncludeJavascript annotation that allows new options to be included, such as browser type (i.e., build that comment thingey around the

Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-24 Thread Josh Canfield
> However, I think the ticket should still be considered. Definitely. On Tue, Nov 24, 2009 at 7:07 AM, raulmt wrote: > > This is a good workaround, thanks. > > This won't work when the textarea with TinyMCE is loaded from an Ajax > request, though. Nevertheless, the problem shouldn't arise when

Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-24 Thread raulmt
This is a good workaround, thanks. This won't work when the textarea with TinyMCE is loaded from an Ajax request, though. Nevertheless, the problem shouldn't arise when the script is loaded from an Ajax request, so in case the request is an Ajax request, you can include it with RenderSupport as u

Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-23 Thread Josh Canfield
Here is a workaround that I used in my tinymce mixin. void afterRender(MarkupWriter writer) { // inject script in a non-combinable way final String scriptelementid = "tinymce-script"; final Element src = writer.getDocument().getElementById(scriptelementid); if (src

Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-23 Thread raulmt
https://issues.apache.org/jira/browse/TAP5-935 If you have something to add or clarify, please do it as well ;) Thiago H. de Paula Figueiredo wrote: > > Em Mon, 23 Nov 2009 19:13:09 -0200, raulmt escreveu: > >> Hello, > > Hi! > >> should I post a ticket in jira about per-script combining c

Re: Combining Javascript doesn't work with libraries like TinyMCE

2009-11-23 Thread Thiago H. de Paula Figueiredo
Em Mon, 23 Nov 2009 19:13:09 -0200, raulmt escreveu: Hello, Hi! should I post a ticket in jira about per-script combining configuration? Please do it. -- Thiago H. de Paula Figueiredo Independent Java, Apache Tapestry 5 and Hibernate consultant, developer, and instructor Owner, softwar

Combining Javascript doesn't work with libraries like TinyMCE

2009-11-23 Thread raulmt
Hello, Combining Javascripts feature in T5.1 is great, but sadly I had to disable it. I use TinyMCE and this library uses its own path (where tiny_mce.js "lives") to load other files that are needed (themes, languages, etc.). The problem arises when tiny_mce.js is in the combined virtual asset be