Re: ASM7 required

2019-04-19 Thread Thiago H. de Paula Figueiredo
Nevermind, I just did. :) On Thu, Apr 18, 2019 at 7:07 PM Thiago H. de Paula Figueiredo < thiag...@gmail.com> wrote: > Thanks, Dmitry! > > Would you do the honors of applying this patch? :) > > On Fri, Apr 12, 2019 at 6:53 PM Dmitry Gusev > wrote: > >> Hi Thiago! >> >> >> From 1f428d21610ca2ee4a

Re: ASM7 required

2019-04-18 Thread Thiago H. de Paula Figueiredo
Thanks, Dmitry! Would you do the honors of applying this patch? :) On Fri, Apr 12, 2019 at 6:53 PM Dmitry Gusev wrote: > Hi Thiago! > > > From 1f428d21610ca2ee4a0b0630b1e3d1c693a5a7e6 Mon Sep 17 00:00:00 2001 > From: Mats Andersson > Date: Mon, 1 Apr 2019 17:52:26 +0200 > Subject: [PATCH] ASM7

Re: ASM7 required

2019-04-12 Thread Dmitry Gusev
Hi Thiago! >From 1f428d21610ca2ee4a0b0630b1e3d1c693a5a7e6 Mon Sep 17 00:00:00 2001 From: Mats Andersson Date: Mon, 1 Apr 2019 17:52:26 +0200 Subject: [PATCH] ASM7 dependencies --- .../apache/tapestry5/internal/plastic/PlasticInternalUtils.java | 2 +- .../tapestry5/ioc/internal/AbstractReloa

Re: ASM7 required

2019-04-12 Thread Thiago H. de Paula Figueiredo
Hello! Which edits? On Thu, Apr 11, 2019 at 3:01 PM Dmitry Gusev wrote: > Hello Mats and Thiago, > > I guess we need to reopen https://issues.apache.org/jira/browse/TAP5-2588 > or > just don't forget to commit the last two edits. > I also got failures trying to run our test suite against 5.5-be

Re: ASM7 required

2019-04-11 Thread Dmitry Gusev
Hello Mats and Thiago, I guess we need to reopen https://issues.apache.org/jira/browse/TAP5-2588 or just don't forget to commit the last two edits. I also got failures trying to run our test suite against 5.5-beta-2 & Java 11. With the two last changes the errors are gone. Thanks! On Sat, Apr

Re: ASM7 required

2019-04-06 Thread Mats Andersson
Yes of course, did that now. Thanks Thiago! /Mats On 2019-04-05 19:46, Thiago H. de Paula Figueiredo wrote: Hello, Mats! On Tue, Apr 2, 2019 at 12:42 PM Mats Andersson wrote: Continuing the attempt to upgrade an application from 5.4.4 to 5.5.0-beta-2 I stepped into a couple of issues relate

Re: ASM7 required

2019-04-05 Thread Thiago H. de Paula Figueiredo
Hello, Mats! On Tue, Apr 2, 2019 at 12:42 PM Mats Andersson wrote: > Continuing the attempt to upgrade an application from 5.4.4 to > 5.5.0-beta-2 I stepped into a couple of issues related to ASM. In > org.apache.tapestry5.internal.plastic.asm.ClassVisitor#visitNestMember > ASM7 is required, but

ASM7 required

2019-04-02 Thread Mats Andersson
Continuing the attempt to upgrade an application from 5.4.4 to 5.5.0-beta-2 I stepped into a couple of issues related to ASM. In org.apache.tapestry5.internal.plastic.asm.ClassVisitor#visitNestMember ASM7 is required, but calls from internal/plastic and ioc modules are made using ASM4 as parame