Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-30 Thread Joost Schouten (ml)
Before I forget, thanks a lot for your help on this issue! It caused me to dive into the Tapestry source a bit deeper and makes me appreciate the framework even more! A few more weeks and I will bring a new Tapestry application to the world ;-) Ulrich Stärk wrote: That explains why I wasn't

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-30 Thread Ulrich Stärk
That explains why I wasn't able to reproduce it. Great investigative work :) Uli Am 30.11.2009 08:55 schrieb Joost Schouten (ml): Eureka! ;-) I figured it out (I think). The problem only exists when using any UrlRewriteRule, activation context and additional parameters. The t:ac seems to be ad

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-29 Thread Joost Schouten (ml)
Eureka! ;-) I figured it out (I think). The problem only exists when using any UrlRewriteRule, activation context and additional parameters. The t:ac seems to be added to the URL before the UrlRewriting happens, where the AjaxFormLoop parameters seem to be added after the rewriting which result

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-28 Thread Ulrich Stärk
Joost, I still can't reproduce your issue. The requested URL when clicking the add row link according to firebug is http://localhost:8080/testpage.myajaxloop.rowinjector:inject?t:ac=passivate_value&t:formcomponentid=TestPage:form&t:formid=form which is perfectly valid and is the same as genera

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-28 Thread Joost Schouten (ml)
I have created: https://issues.apache.org/jira/browse/TAP5-937 whith a patch to fix the problem in the LinkImpl. Thanks, Joost Ulrich Stärk wrote: I tested it with 5.2.0-SNAPSHOT and 5.1.0.5, but to be 100% sure, I'll clear out my local maven repo and test again this evening. Uli Am 27.11.20

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-27 Thread Joost Schouten (ml)
I just tested it against 5.1.0.5 and it does *not* have the problem with the double printing of the question mark. There seems to be a problem on the snapshot. Has any work been done on it lately? Ulrich Stärk wrote: I tested it with 5.2.0-SNAPSHOT and 5.1.0.5, but to be 100% sure, I'll clear

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-27 Thread Ulrich Stärk
I tested it with 5.2.0-SNAPSHOT and 5.1.0.5, but to be 100% sure, I'll clear out my local maven repo and test again this evening. Uli Am 27.11.2009 15:21 schrieb Joost Schouten (ml): Ulrich, So in your case the add row url has appended the t:componentformid and t:formid to the parameter list

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-27 Thread Joost Schouten (ml)
Ulrich, So in your case the add row url has appended the t:componentformid and t:formid to the parameter list in the url with the already available activation context param t:ac? And are you using the 5.2.0-SNAPSHOT? This only started happening recently where before all worked fine. Thanks f

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-27 Thread Ulrich Stärk
I'm unable to reproduce any of the behaviour you are experiencing. The URL for the Ajax update generated by tapestry is valid and I don't get any errors. Uli Am 26.11.2009 17:15 schrieb Joost Schouten (ml): Hi, It's not just passivate, its an activate and passivate combination. The page [1]

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-26 Thread Joost Schouten (ml)
Hi, It's not just passivate, its an activate and passivate combination. The page [1] and tml [2] will reproduce the problem. Strangely enough when in this example you remove the activate and passivate you get another weird error which looks like it could be related to http://issues.apache.or

Re: [T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-26 Thread Ulrich Stärk
Could you provide a minimal example? Am 26.11.2009 15:53 schrieb Joost Schouten (ml): Hi, When using the AjaxFormLoop's AddRowLink in conjunction with onPassivate an invalid url is generated [1]. When I remove onPassivate from my page all works fine. Am I missing something, is this work in

[T5.2.0] AddRowLink generates incorrect link in conjunction with onPassivate

2009-11-26 Thread Joost Schouten (ml)
Hi, When using the AjaxFormLoop's AddRowLink in conjunction with onPassivate an invalid url is generated [1]. When I remove onPassivate from my page all works fine. Am I missing something, is this work in progress (I'm using the SNAPSHOT version) or shall I file a bug report? Cheers, Joost