Re: https://issues.apache.org/jira/browse/TAP5-2630

2023-08-01 Thread Ben Weidig
That's weird... Here's an example from my code with some custom types: public static final List WEEK_DAY_SOURCE = List.of(...); In the TML: ... Works fine for me, but I'm running 5.8.2 with OpenJDK 17, not 11. On Tue, Aug 1, 2023 at 4:29 PM Jens Breitenstein wrote: > Sorry, Ben, tri

Re: https://issues.apache.org/jira/browse/TAP5-2630

2023-08-01 Thread Jens Breitenstein
Sorry, Ben, tried it, but this is not working.     private final String x = "...";     public final String x = "..."; throws: "Update to non-static final field ...x... attempted from a different method (initializeInstance) than the initializer method " which is correct, because the field isn'

Re: https://issues.apache.org/jira/browse/TAP5-2630

2023-08-01 Thread Ben Weidig
Hi Jens, I was looking into static fields and the @Property annotation worker the other day but stopped, as I realized you can use "public static final" fields directly in the TML without any additional work. So the following code should be fine: public final String[] keys = new String[] {

https://issues.apache.org/jira/browse/TAP5-2630

2023-08-01 Thread Jens Breitenstein
HI! I noticed due to JDK 11 there is a subtile change in handling of final fields and initialization. On rare cases we used final fields including @Property(write = false), which is no longer working. Example:     @Property(write="false") private final String[] _keys = new String[] {   

T5.8.3 upgrade of old webapp

2023-08-01 Thread Jens Breitenstein
Hi! we are currently trying to upgrade our webapp from T5.4 to T5.8.3 The migrator did his job, entire applications builds and starts, well, partly. It looks like our migration is incomplete because we use two external libs "federated-accounts" and "json-bindinding". We made a fork of both,

Re: T5.8.3 upgrade T5.4 webapp

2023-08-01 Thread Jens Breitenstein
Ben, you nailed it. Surprisingly, the import of TapestryModule in our own application module solved the issue. Honestly, we should consider this as a bug, because a Tapestry application without having TapestryModule loaded won't work at all and this behaviour differes from the past, what you t