Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-03-06 Thread Trent Nelson
On 2/23/12 10:50 AM, "Torsten Krah" wrote: > >In theory yes it would work to do the same thing again in post-commit - >but pre-commit already did all the work before. Would be nice if there >would be no need to parse and analyze things twice, may take time and >resources depending on the commit

Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-02-23 Thread Andreas Krey
On Thu, 23 Feb 2012 11:50:29 +, Torsten Krah wrote: ... > In theory yes it would work to do the same thing again in post-commit - > but pre-commit already did all the work before. Would be nice if there > would be no need to parse and analyze things twice, may take time and > resources dependin

Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-02-23 Thread Torsten Krah
Am Donnerstag, den 23.02.2012, 11:16 +0100 schrieb Stephen Butler: > Why not do 1 & 3 in a post-commit hook? In pre-commit things are already needed to be parsed to check if the commit itself is allowed. When doing those checks things can be prepared too for the external system - 2 in 1 ;-). So th

Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-02-23 Thread Stephen Butler
On Feb 23, 2012, at 10:44 , Torsten Krah wrote: > Am Mittwoch, den 22.02.2012, 14:53 -0500 schrieb Andy Levy: >> Can pre-commit clean up after itself, so that the environment is clean >> regardless of the result of the commit? > > Hm no, the action should do some work (external system) and does

Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-02-23 Thread Torsten Krah
Am Mittwoch, den 22.02.2012, 14:53 -0500 schrieb Andy Levy: > Can pre-commit clean up after itself, so that the environment is clean > regardless of the result of the commit? Hm no, the action should do some work (external system) and does need to know if commit was successful or if it failed. At

Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-02-22 Thread Philip Martin
Mark Phippard writes: > On Wed, Feb 22, 2012 at 2:49 PM, Torsten Krah > wrote: > >> If commit can not fail - for which ever reason - why the doc does state that >> the hook does only run if the commit is actual successful? >> So it is possible to fail or not? > > Commits can fail. A common reas

Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-02-22 Thread Mark Phippard
On Wed, Feb 22, 2012 at 2:49 PM, Torsten Krah wrote: > If commit can not fail - for which ever reason - why the doc does state that > the hook does only run if the commit is actual successful? > So it is possible to fail or not? Commits can fail. A common reason would be that a file included in

Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-02-22 Thread Andy Levy
On Wed, Feb 22, 2012 at 14:49, Torsten Krah wrote: > Am 22.02.2012 18:27, schrieb Ryan Schmidt: > >> >> On Feb 22, 2012, at 09:23, Torsten Krah wrote: >> >>> the http://svnbook.red-bean.com/en/1.6/svn.ref.reposhooks.html book >>> tells about the various post-* hooks. >>> But those one are called o

Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-02-22 Thread Torsten Krah
Am 22.02.2012 18:27, schrieb Ryan Schmidt: On Feb 22, 2012, at 09:23, Torsten Krah wrote: the http://svnbook.red-bean.com/en/1.6/svn.ref.reposhooks.html book tells about the various post-* hooks. But those one are called on "successfull" operations. Whats the way to implement a hook, which is

Re: commit hooks - is there a hook which is called after commit even if its not successful

2012-02-22 Thread Ryan Schmidt
On Feb 22, 2012, at 09:23, Torsten Krah wrote: > the http://svnbook.red-bean.com/en/1.6/svn.ref.reposhooks.html book > tells about the various post-* hooks. > But those one are called on "successfull" operations. > Whats the way to implement a hook, which is called after commit - it > does not ma

commit hooks - is there a hook which is called after commit even if its not successful

2012-02-22 Thread Torsten Krah
Hi, the http://svnbook.red-bean.com/en/1.6/svn.ref.reposhooks.html book tells about the various post-* hooks. But those one are called on "successfull" operations. Whats the way to implement a hook, which is called after commit - it does not matter if successful or failed - the hook must be able t