Re: Incomplete SVN dump files

2015-09-16 Thread Daniel Shahaf
Eric Johnson wrote on Wed, Sep 16, 2015 at 16:11:21 -0700: > Hi Daniel, > > The exact logistics of handling an error are probably pretty > straightforward. The underlying problem is that it is never a good > idea to pipe the output of svnrdump directly into svnadmin load, > because svnadmin cannot

Re: Incomplete SVN dump files

2015-09-16 Thread Eric Johnson
Hi Daniel, The exact logistics of handling an error are probably pretty straightforward. The underlying problem is that it is never a good idea to pipe the output of svnrdump directly into svnadmin load, because svnadmin cannot handle the failure unless the stream itself carries more information.

Re: Incomplete SVN dump files

2015-09-16 Thread Daniel Shahaf
Eric Johnson wrote on Wed, Sep 16, 2015 at 11:03:08 -0700: > So if the dump of the last commit is incomplete, I an error code tells me, > what, exactly? That I need to manually edit the stream that I just dumped > into a file? That I should discard the whole dump, and start again? If you run dump

Re: Incomplete SVN dump files

2015-09-16 Thread Daniel Shahaf
Eric Johnson wrote on Wed, Sep 16, 2015 at 11:03:08 -0700: > On Wed, Sep 16, 2015 at 2:33 AM, Bert Huijben wrote: > > After an error you can't trust that the final portion is ok. > > > > Sure, but why not encode that in the dump itself! The absence of an > "end-commit" trailer could be a signal t

Re: Incomplete SVN dump files

2015-09-16 Thread Mark Phippard
On Wed, Sep 16, 2015 at 3:55 PM, Mark Phippard wrote: > On Wed, Sep 16, 2015 at 3:47 PM, Eric Johnson wrote: > > Yes, I can do that. Probably going to do that in chunks, otherwise it >> has the same awful performance profile as svnsync over a low latency >> connection. >> > > FWIW, svnsync and s

Re: Incomplete SVN dump files

2015-09-16 Thread Mark Phippard
On Wed, Sep 16, 2015 at 3:47 PM, Eric Johnson wrote: Yes, I can do that. Probably going to do that in chunks, otherwise it > has the same awful performance profile as svnsync over a low latency > connection. > FWIW, svnsync and svnrdump make identical calls over the network so their performance

Re: Incomplete SVN dump files

2015-09-16 Thread Eric Johnson
-- >>>> From: Andreas Mohr [mailto:a...@lisas.de] >>>> Sent: woensdag 16 september 2015 07:48 >>>> To: Eric Johnson >>>> Cc: b...@qqmail.nl; users@subversion.apache.org >>>> Subject: Re: Incomplete SVN dump files >>>> >

Re: Incomplete SVN dump files

2015-09-16 Thread Branko Čibej
t;> To: Eric Johnson >>> Cc: b...@qqmail.nl; users@subversion.apache.org >>> Subject: Re: Incomplete SVN dump files >>> >>> Hi, >>> >>> On Tue, Sep 15, 2015 at 05:26:38PM -0700, Eric Johnson wrote: >>>>I just checked, and there aren'

Re: Incomplete SVN dump files

2015-09-16 Thread Eric Johnson
Hi Bert, On Wed, Sep 16, 2015 at 2:33 AM, Bert Huijben wrote: > > > > -Original Message- > > From: Andreas Mohr [mailto:a...@lisas.de] > > Sent: woensdag 16 september 2015 07:48 > > To: Eric Johnson > > Cc: b...@qqmail.nl; users@subversion.apache

RE: Incomplete SVN dump files

2015-09-16 Thread Bert Huijben
> -Original Message- > From: Andreas Mohr [mailto:a...@lisas.de] > Sent: woensdag 16 september 2015 07:48 > To: Eric Johnson > Cc: b...@qqmail.nl; users@subversion.apache.org > Subject: Re: Incomplete SVN dump files > > Hi, > > On Tue, Sep 15, 2015 at

Re: Incomplete SVN dump files

2015-09-15 Thread Andreas Mohr
Hi, On Tue, Sep 15, 2015 at 05:26:38PM -0700, Eric Johnson wrote: >I just checked, and there aren't any open bugs about this. >Interrupting svnrdump can result in a dump file with not all the files of >the last commit in the dump record. Accidentally use that dump file to >load int

Re: Incomplete SVN dump files

2015-09-15 Thread Eric Johnson
I just checked, and there aren't any open bugs about this. Interrupting svnrdump can result in a dump file with not all the files of the last commit in the dump record. Accidentally use that dump file to load into a new repository, and the resulting repository will not be a copy of the original.

Re: Incomplete SVN dump files

2015-09-15 Thread Eric Johnson
Hi Bert, The files that made it into the dump file were complete. It is just that the last commit in the dump file didn't have all of the files it was supposed to have. This may be a deliberate design of the dump file format, but it does mean that svnrdump is badly broken. Svnrdump should not be

RE: Incomplete SVN dump files

2015-09-15 Thread bert
In what way was the dump file incomplete? Was it broken halfway through a file? (That should have been caught via the checksums in the file). If a whole node edit is missing it is still a complete dumpfile and there is no way the current dump doesn’t know when a revision is done. (This allows e