Re: Segfault in libsvn_client/conflicts.c

2021-08-09 Thread Joshua Kordani
t but the resolution doesn't cause the crash.  I'm not sure what else I can do at this point.  I'd love to know why svn can't detect that these deletions are the same in my work repo...  This kind of problem plagues us On 8/9/21 16:10, Stefan Sperling wrote: On Mon, Aug 09,

Crash in token.c after incomplete cherry pick merges in 1.15

2021-08-09 Thread Joshua Kordani
Attached is a script to reproduce the error. I also have a packed rr debugger session that I can provide (I highly recommend the rr reversible debugger).  Its ~30meg -- Joshua Kordani Senior Engineer Robotic Research, LLC jkord...@roboticresearch.com CONFIDENTIALITY NOTICE: This

Re: Segfault in libsvn_client/conflicts.c

2021-08-09 Thread Joshua Kordani
ersion/libsvn_subr/token.c:40: (apr_err=SVN_ERR_ASSERTION_FAIL) svn: E235000: In file 'subversion/libsvn_subr/token.c' line 40: internal malfunction Aborted (core dumped) On 8/9/21 14:38, Joshua Kordani wrote: So unfortunately that simple case didn't reproduce the problem. So I need help

Re: Segfault in libsvn_client/conflicts.c

2021-08-09 Thread Joshua Kordani
So unfortunately that simple case didn't reproduce the problem. So I need help investigating the state of things... On 8/9/21 14:09, Joshua Kordani wrote: The shell script is easy.  I run resolve on my codebase :-).  The trick will be recreating the repo history that reproduces this pr

Re: Segfault in libsvn_client/conflicts.c

2021-08-09 Thread Joshua Kordani
o and I'll need help to do that On 8/8/21 16:38, Stefan Sperling wrote: On Sun, Aug 08, 2021 at 10:26:43AM +0200, Daniel Sahlberg wrote: On 2021-08-07 17:14, Joshua Kordani wrote: Yes it does appear to fix the issue.  Thank you! Hi Joshua (and list), I've been trying to reproduce you

Re: Segfault in libsvn_client/conflicts.c

2021-08-07 Thread Joshua Kordani
Yes it does appear to fix the issue.  Thank you! On 8/7/21 06:32, Joshua Kordani wrote: Thank you for explaining the convention, it makes sense now that you describe it like that. It was delightfully short work to hunt down with the rr debugger ;-) I'm having trouble testing it right no

Re: Segfault in libsvn_client/conflicts.c

2021-08-07 Thread Joshua Kordani
caller of find_related_node, and again In the few minutes of looking it wasn't obvious to me if that callsite also needed to correctly track  the first argument remaining NULL after the call?  Line 5148. On 8/7/21 04:48, Stefan Sperling wrote: On Fri, Aug 06, 2021 at 07:41:42PM -0400, Joshu

Segfault in libsvn_client/conflicts.c

2021-08-06 Thread Joshua Kordani
ginal value of related_repos_relpath is unimportant. I release all rights to this patch, or assign the rights to the project license as appropriate. -- Joshua Kordani Senior Engineer Robotic Research, LLC jkord...@roboticresearch.com CONFIDENTIALITY NOTICE: This communication may contain pr