Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Greg Troxel
"Kevin A. McGrail" writes: > #2 Work on the code so that short circuiting or at least the scoring > behaves as with 3.4.6. As penance for ranting I went back and re-read everything more carefully, but feel free to ignore me if I am being unhelpful. I don't think a -2 shortcircuit rule makes

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Kevin A. McGrail
Following up on my previous note I think we are working on #2.  I see that 8078 was reopened and there is some improvements / weighing in on a patch from Giovanni that might resolve the issue too! On 12/4/2022 3:02 PM, Kevin A. McGrail wrote: OK, so then we have really two Choices: #1 accept

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Shawn Iverson
As someone that is running a large distributed spamassassin installation, I depend on shortcircuit to handle large amounts of mail quickly that does not need scored further. The change in behavior has potential for negative impact that I will have to test carefully before moving to v4. On Sun, De

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Kevin A. McGrail
OK, so then we have really two Choices: #1 accept that no code changes are needed, we've fixed a rule(s) we know might trigger wrong around MISSING HEADERS and we just document the change in the UPGRADE that shortcircuit may continue to run more meta rules to finish them out which might not ha

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Greg Troxel
Bill Cole writes: > On 2022-12-04 at 09:57:09 UTC-0500 (Sun, 04 Dec 2022 09:57:09 -0500) > Greg Troxel > is rumored to have said: > >> Putting on my CS pedant hat, I guess the big question is if there is a >> violation of a previously published specification. > > If not, it would only be a con

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Bill Cole
On 2022-12-04 at 09:57:09 UTC-0500 (Sun, 04 Dec 2022 09:57:09 -0500) Greg Troxel is rumored to have said: > Putting on my CS pedant hat, I guess the big question is if there is a > violation of a previously published specification. If not, it would only be a consequence of no definitive clear s

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Greg Troxel
"Kevin A. McGrail" writes: > I think that will have to go to discussion since if the rules don't short > circuit the way they used to, other rules outside of the ones we control > are going to act oddly. The one that was reported was with validity for > example. > > What happens if I have a loca

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Henrik K
Feel free to reopen the bug if you want, I really have no time or desire to work on these right now. I didn't analyze if skipping do_meta_tests for shortcircuiting has any negative consequences, but if someone wants to prove it doesn't, go for it and I'll vote on it. It not enough to just post

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Kevin A. McGrail
I think that will have to go to discussion since if the rules don't short circuit the way they used to, other rules outside of the ones we control are going to act oddly. The one that was reported was with validity for example. What happens if I have a local rule that's high scoring and meta that

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Henrik K
Of course it does and processing doesn't need to stop into a brickwall when it activates. It simply finishes metas which is not that expensive and might provide some additional useful hits. No sense postponing 4.0.0 to try to tweak this further. On Sun, Dec 04, 2022 at 09:28:02AM -0500, Kevin

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Kevin A. McGrail
I have not checked but does the short circuiting actually work? The goal of it is to lower the resource usage of the tool. If it continues to run and generate longer than we have a problem still. On Sun, Dec 4, 2022, 08:50 Henrik K wrote: > > Fixed simply with some rule changes as described in t

Re: Mial hits MISSING rules despite presence of headers

2022-12-04 Thread Henrik K
Fixed simply with some rule changes as described in the bug. On Tue, Nov 29, 2022 at 05:28:00PM -0500, Kevin A. McGrail wrote: > https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8078 is now open on this > issue. > -- > Kevin A. McGrail > Member, Apache Software Foundation > Chair Emeritus Apa