Re: ToggleFullScreenAction fails on MacOS

2018-06-16 Thread Patrik Karlström
Thank you, it works perfectly! /Patrik Den tors 7 juni 2018 kl 07:42 skrev Emilian Bold : > What I see in ./applemenu/src/org/netbeans/modules/applemenu/layer.xml > is that the generic action is hidden on macOS: > > > > > name="org-netbeans-core-windows-actions-Toggle

Re: ToggleFullScreenAction fails on MacOS

2018-06-07 Thread Brett Ryan
Yeah, I realised later and thought it too embarrassing to say anything lol. > On 8 Jun 2018, at 05:32, Patrik Karlström wrote: > > Thanks for the hint but I'm trying to do this from a button in the toolbar of > a nb platform application. > > Den tors 7 juni 2018 kl 00:05 skrev Brett Ryan : >>

Re: ToggleFullScreenAction fails on MacOS

2018-06-07 Thread Patrik Karlström
Oh great, thanks for the info and code. I'll try it out during the weekend. I understand why one would like to hide the menu item and shortcut when on mac, but hiding the action looks like overkill to me, unless it was really necessary that is. /Patrik Den tors 7 juni 2018 kl 07:42 skrev Emilian

Re: ToggleFullScreenAction fails on MacOS

2018-06-07 Thread Patrik Karlström
Thanks for the hint but I'm trying to do this from a button in the toolbar of a nb platform application. Den tors 7 juni 2018 kl 00:05 skrev Brett Ryan : > I haven’t experienced this behaviour, however; as a workaround, if you are > ok with maximising NetBeans without going full screen, hold down

Re: ToggleFullScreenAction fails on MacOS

2018-06-06 Thread Emilian Bold
What I see in ./applemenu/src/org/netbeans/modules/applemenu/layer.xml is that the generic action is hidden on macOS: That's why you are getting a null. So, there is no API to call that action on macOS as far as I can tell. This workaround does the tr

Re: ToggleFullScreenAction fails on MacOS

2018-06-06 Thread Brett Ryan
I haven’t experienced this behaviour, however; as a workaround, if you are ok with maximising NetBeans without going full screen, hold down the option key when clicking the green button. > On 7 Jun 2018, at 00:44, Patrik Karlström wrote: > > Den ons 6 juni 2018 kl 14:36 skrev Emilian Bold : >>

Re: ToggleFullScreenAction fails on MacOS

2018-06-06 Thread Patrik Karlström
Den ons 6 juni 2018 kl 14:36 skrev Emilian Bold : > The actual NPE might help. Maybe you have to create a dummy even and not > send null to actionPerformed? > > If it's reproducible you should report it to the bugtracker > https://issues.apache.org/jira/projects/NETBEANS/summary > > --emi > >

Re: ToggleFullScreenAction fails on MacOS

2018-06-06 Thread Emilian Bold
The actual NPE might help. Maybe you have to create a dummy even and not send null to actionPerformed? If it's reproducible you should report it to the bugtracker https://issues.apache.org/jira/projects/NETBEANS/summary --emi ‐‐‐ Original Message ‐‐‐ On 6 June 2018 2:36 PM, Patrik Kar

ToggleFullScreenAction fails on MacOS

2018-06-06 Thread Patrik Karlström
Hi, Actions.forID("Window", "org.netbeans.core.windows.actions.ToggleFullScreenAction").actionPerformed(null); I *think* that I have successfully run the code above on a mac a couple of years back, but that might have been before they changed their maximize/full screen handling. Today I noticed