Brian replied offlist; we resolved it. Committed in r17591. I'll
make a patch for the v1.2 branch in case we ever do v1.2.6.
On Feb 24, 2008, at 10:11 AM, Jeff Squyres wrote:
Actually, I take my comments back. Brian's initial patches did not
compiled for me; I had to make some more chang
Actually, I take my comments back. Brian's initial patches did not
compiled for me; I had to make some more changes to make it work for
me (see attached patch):
1. fixed a HAVE_LONG_LONG to be OMPI_HAVE_LONG_LONG
2. fixed a STDC_HEADERS to be OMPI_STDC_HEADERS
3. the AC_DEFINE's for the ne
I merged your two patches and will commit once I come within range of
being online. I'll also file a CMR for 1.2.6 in case that ever
happens (had to resolve a trivial patch reject for the 1.2 branch).
Thanks!
On Feb 22, 2008, at 9:40 AM, Brian W. Barrett wrote:
A second attempt, this tim
A second attempt, this time with less suck :).
Brian
On Fri, 22 Feb 2008, Brian W. Barrett wrote:
Oops.. forgot to test the C++ bindings, which of course broke. Let me
try again and I'll send a better patch.
brian
On Fri, 22 Feb 2008, Brian W. Barrett wrote:
On Thu, 21 Feb 2008, Jeff Squ
Oops.. forgot to test the C++ bindings, which of course broke. Let me
try again and I'll send a better patch.
brian
On Fri, 22 Feb 2008, Brian W. Barrett wrote:
On Thu, 21 Feb 2008, Jeff Squyres wrote:
While I agree that having AC actually define them to a value is a Good
Thing (better th
On Thu, 21 Feb 2008, Jeff Squyres wrote:
While I agree that having AC actually define them to a value is a Good
Thing (better than just defining it to be empty), I do see the pickle
that it has put us in. :-\ I don't see an obvious solution.
I do :). Try the attached patch. It sneaks in at
On Feb 20, 2008, at 9:45 AM, Ben Allan wrote:
Our assumption was that if some other package defined these values,
they
would either likely be coming from the same standard autoconf tests
or
use the same #define conventions as the autoconf tests. As such, the
values that they are #defined to
On Wed, Feb 20, 2008 at 06:15:27AM -0700, Jeff Squyres wrote:
> The #defines that are mpi.h are limited to the ones that we need for
> that file itself. More specifically: the majority of the #define's that
> are generated via OMPI's configure are not in mpi.h.
And that's much appreciated.
>
On Feb 19, 2008, at 12:52 PM, Ben Allan wrote:
Is there some subtle reason that ompi's mpi.h
leaves the following macros both
unguarded with an ifndef and un-prefixed with OMPI_ ?
Mainly because they come from standard autoconf/configure tests (e.g.,
AC_CHECK_SIZEOF), meaning that we (OMPI)
Thanks in advance if this is already fixed in a later release I've not caught
up to,
I'm at 1.2.3.
Is there some subtle reason that ompi's mpi.h
leaves the following macros both
unguarded with an ifndef and un-prefixed with OMPI_ ?
This produces considerable amounts of compiler whinage for oth
10 matches
Mail list logo
