Re: [OMPI users] [petsc-dev] potential bug with MPI_Win_fence() in openmpi-1.8.4

2015-04-30 Thread Satish Balay
Great! Thanks for checking. Satish On Thu, 30 Apr 2015, George Bosilca wrote: > I went over the code and in fact I think it is correct as is. The length is > for the local representation, which indeed uses pointers to datatype > structures. On the opposite, the total_pack_size represents the amo

Re: [OMPI users] [petsc-dev] potential bug with MPI_Win_fence() in openmpi-1.8.4

2015-04-30 Thread George Bosilca
I went over the code and in fact I think it is correct as is. The length is for the local representation, which indeed uses pointers to datatype structures. On the opposite, the total_pack_size represents the amount of space we would need to store the data in a format that can be sent to another pe

Re: [OMPI users] [petsc-dev] potential bug with MPI_Win_fence() in openmpi-1.8.4

2015-04-30 Thread George Bosilca
In the packed representation we store not MPI_Datatypes but a handcrafted id for each one. The 2 codes should have been in sync. I'm looking at another issue right now, and I'll come back to this one right after. Thanks for paying attention to the code. George. On Thu, Apr 30, 2015 at 3:13 PM,

Re: [OMPI users] [petsc-dev] potential bug with MPI_Win_fence() in openmpi-1.8.4

2015-04-30 Thread Jeff Squyres (jsquyres)
Oops -- that was a mistake from George when he committed the fix, and I just propagated that mistake into the v1.8 pull request. I'll fix it there, at least. But the master commit message is unfortunately going to have to stay wrong. :-( > On Apr 30, 2015, at 2:59 PM, Matthew Knepley wrote

Re: [OMPI users] [petsc-dev] potential bug with MPI_Win_fence() in openmpi-1.8.4

2015-04-30 Thread Satish Balay
Thanks for checking and getting a more appropriate fix in. I've just tried this out - and the PETSc test code runs fine with it. BTW: There is one inconsistancy in ompi/datatype/ompi_datatype_args.c [that I noticed] - that you might want to check. Perhaps the second line should be "(DC) * sizeof