Re: dm-crypt performance regression due to workqueue changes

2024-07-01 Thread Tejun Heo
Hello, On Mon, Jul 01, 2024 at 02:52:19PM +0100, Daniel P. Berrangé wrote: ... > None the less, I'd suggest that virt-manager should be a explicitly > asking for sockets=1,cores=N, as that has broader guest OS compatibility. +1. Multiple sockets is pretty uncommon and often comes with significant

Re: dm-crypt performance regression due to workqueue changes

2024-07-01 Thread Mikulas Patocka
On Mon, 1 Jul 2024, Daniel P. Berrangé wrote: > On Sun, Jun 30, 2024 at 08:49:48PM +0200, Mikulas Patocka wrote: > > > > > > On Sun, 30 Jun 2024, Tejun Heo wrote: > > > > > Do you happen to know why libvirt is doing that? There are many other > > > implications to configuring the system that

Re: dm-crypt performance regression due to workqueue changes

2024-07-01 Thread Daniel P . Berrangé
On Mon, Jul 01, 2024 at 03:42:29PM +0200, Mikulas Patocka wrote: > > > On Mon, 1 Jul 2024, Daniel P. Berrangé wrote: > > > On Sun, Jun 30, 2024 at 08:49:48PM +0200, Mikulas Patocka wrote: > > > > > > > > > On Sun, 30 Jun 2024, Tejun Heo wrote: > > > > > > > Do you happen to know why libvirt i

Re: dm-crypt performance regression due to workqueue changes

2024-07-01 Thread Mikulas Patocka
On Mon, 1 Jul 2024, Daniel P. Berrangé wrote: > On Mon, Jul 01, 2024 at 02:48:07PM +0200, Michal Prívozník wrote: > > On 6/30/24 20:49, Mikulas Patocka wrote: > > > > > > > > > On Sun, 30 Jun 2024, Tejun Heo wrote: > > >> > > >> Do you happen to know why libvirt is doing that? There are many o

Re: dm-crypt performance regression due to workqueue changes

2024-07-01 Thread Daniel P . Berrangé
On Mon, Jul 01, 2024 at 02:48:07PM +0200, Michal Prívozník wrote: > On 6/30/24 20:49, Mikulas Patocka wrote: > > > > > > On Sun, 30 Jun 2024, Tejun Heo wrote: > > > >> Hello, > >> > >> On Sat, Jun 29, 2024 at 08:15:56PM +0200, Mikulas Patocka wrote: > >> > >>> With 6.5, we get 3600MiB/s; with 6.

Re: dm-crypt performance regression due to workqueue changes

2024-07-01 Thread Daniel P . Berrangé
On Sun, Jun 30, 2024 at 08:49:48PM +0200, Mikulas Patocka wrote: > > > On Sun, 30 Jun 2024, Tejun Heo wrote: > > > Hello, > > > > On Sat, Jun 29, 2024 at 08:15:56PM +0200, Mikulas Patocka wrote: > > > > > With 6.5, we get 3600MiB/s; with 6.6 we get 1400MiB/s. > > > > > > The reason is that vi

Re: dm-crypt performance regression due to workqueue changes

2024-07-01 Thread Michal Prívozník
On 6/30/24 20:49, Mikulas Patocka wrote: > > > On Sun, 30 Jun 2024, Tejun Heo wrote: > >> Hello, >> >> On Sat, Jun 29, 2024 at 08:15:56PM +0200, Mikulas Patocka wrote: >> >>> With 6.5, we get 3600MiB/s; with 6.6 we get 1400MiB/s. >>> >>> The reason is that virt-manager by default sets up a topol

Re: dm-crypt performance regression due to workqueue changes

2024-07-01 Thread Mikulas Patocka
On Sun, 30 Jun 2024, Tejun Heo wrote: > Hello, > > On Sat, Jun 29, 2024 at 08:15:56PM +0200, Mikulas Patocka wrote: > > > With 6.5, we get 3600MiB/s; with 6.6 we get 1400MiB/s. > > > > The reason is that virt-manager by default sets up a topology where we > > have 16 sockets, 1 core per soc