Re: [VOTE] 2.5.0 RC1

2020-03-10 Thread Tom Bentley
Hi David, I verified signatures, built the tagged branch and ran unit and integration tests. I found some flaky tests, as follows: https://issues.apache.org/jira/browse/KAFKA-9691 (new) https://issues.apache.org/jira/browse/KAFKA-9692 (new) https://issues.apache.org/jira/browse/KAFKA-9283 (alread

Re: Passing states stores around

2020-03-10 Thread John Roesler
Hi all, I agree with Sachin. It makes sense to break out some logic into separate classes, but you need to be careful not to leak state from different threads or tasks into each other. The easiest way to do this is to just instantiate your utilities in the Processor init. Then, you’ll be sure

Re: [VOTE] 2.5.0 RC1

2020-03-10 Thread David Arthur
Thanks for the test failure reports, Tom. Tracking (and fixing) these is important and will make future release managers have an easier time :) -David On Tue, Mar 10, 2020 at 10:16 AM Tom Bentley wrote: > Hi David, > > I verified signatures, built the tagged branch and ran unit and integration