Re: batching related issue in 0.9.0 producer

2016-05-03 Thread Prabhu V
Hi Mayuresh, Staying on the BufferPool.java, could you tell me why we need the following piece of code if (this.availableMemory > 0 || !this.free.isEmpty()) { if (!this.waiters.isEmpty()) this.waiters.peekFirst().signal();

Re: batching related issue in 0.9.0 producer

2016-05-03 Thread Mayuresh Gharat
created a jira : https://issues.apache.org/jira/browse/KAFKA-3651 Thanks, Mayuresh On Tue, May 3, 2016 at 2:03 PM, Mayuresh Gharat wrote: > Nice catch. Do you have a jira for this? > I can submit a patch right away. This should be a small patch. > > Thanks, > > Mayuresh > > On Tue, May 3, 2016

Re: batching related issue in 0.9.0 producer

2016-05-03 Thread Mayuresh Gharat
Nice catch. Do you have a jira for this? I can submit a patch right away. This should be a small patch. Thanks, Mayuresh On Tue, May 3, 2016 at 1:56 PM, Prabhu V wrote: > Whenever the BufferPool throws a "Failed to allocate memory within the > configured max blocking time" excepion, it should

batching related issue in 0.9.0 producer

2016-05-03 Thread Prabhu V
Whenever the BufferPool throws a "Failed to allocate memory within the configured max blocking time" excepion, it should also remove the condition object from the waiters deque. Otherwise the condition object is stays forever in the deque. (i.e) "this.waiters.remove(moreMemory);" should happen bef