Re: Possible Error Code for Kafka API Calls

2016-01-20 Thread Guozhang Wang
Thanks Gwen! When I first wrote the possible error codes in code I was also thinking about auto-generate the table in docs if possible. But unfortunately cannot find a possible manner. When we add more error codes / change error codes for requests / responses we need to keep track on the wiki, whi

Re: Possible Error Code for Kafka API Calls

2016-01-19 Thread Muqtafi Akhmad
Thank you guys for filling the details in the wiki, it really helps On Tue, Jan 19, 2016 at 2:07 AM, Ismael Juma wrote: > That would be even better Gwen. > > Ismael > I'm wondering if the protocol docs can be auto-generated from our code to a > large extent. Or if we can enhance our protocol def

Re: Possible Error Code for Kafka API Calls

2016-01-18 Thread Ismael Juma
That would be even better Gwen. Ismael I'm wondering if the protocol docs can be auto-generated from our code to a large extent. Or if we can enhance our protocol definition classes a bit to make them self-documenting (the way we did for configuration). Regarding Dana's suggestion: I think you ne

Re: Possible Error Code for Kafka API Calls

2016-01-18 Thread Dana Powers
Awesome! Fwiw, my understanding of the possible produce errors is: LeaderNotAvailable NotLeaderForPartition UnknownTopicOrPartition InvalidMessage MessageSizeTooLarge RecordListTooLarge InvalidTopic NotEnoughReplicas NotEnoughReplicasAfterAppend InvalidRequiredAcks TopicAuthorizationFailed The o

Re: Possible Error Code for Kafka API Calls

2016-01-18 Thread Gwen Shapira
I added what I found in the code comments to the wiki. Note that there are some gaps. For example if anyone can fill in the producer error codes, it will be awesome :) On Mon, Jan 18, 2016 at 9:17 AM, Gwen Shapira wrote: > I'm wondering if the protocol docs can be auto-generated from our code to

Re: Possible Error Code for Kafka API Calls

2016-01-18 Thread Gwen Shapira
I'm wondering if the protocol docs can be auto-generated from our code to a large extent. Or if we can enhance our protocol definition classes a bit to make them self-documenting (the way we did for configuration). Regarding Dana's suggestion: I think you need special wiki-edit privileges. If you

Re: Possible Error Code for Kafka API Calls

2016-01-18 Thread Ismael Juma
In addition to this, it would be great to move the protocol docs to the docs folder of the git repo: https://github.com/apache/kafka/tree/trunk/docs This way, we can ensure that the protocol docs are updated at the same time as the protocol code. Ismael On Mon, Jan 18, 2016 at 3:36 PM, Dana Pow

Re: Possible Error Code for Kafka API Calls

2016-01-18 Thread Dana Powers
Not exactly - there is some documentation in the source code, but I agree that a wiki on this would be extremely useful. Can anyone create a wiki page? If so, I'm happy to get something started. It is really the missing piece for folks writing custom clients / anything at the api layer. -Dana On