Re: Re: Log.scala

2014-09-29 Thread Guozhang Wang
age -- > From: Guozhang Wang > Date: 26 Sep 2014 17:34 > Subject: Re: Log.scala > To: "users@kafka.apache.org" > Cc: > > Hi Manjunath, > > This check "!appendInfo.offsetsMonotonic" makes sure that there will be no > gaps. > > And th

RE: Re: Log.scala

2014-09-29 Thread Manjunath Shivakumar
g Date: 26 Sep 2014 17:34 Subject: Re: Log.scala To: "users@kafka.apache.org" Cc: Hi Manjunath, This check "!appendInfo.offsetsMonotonic" makes sure that there will be no gaps. And the other part "appendInfo.firstOffset < nextOffset.get" I agree that it seems redun

Re: Log.scala

2014-09-26 Thread Guozhang Wang
Hi Manjunath, This check "!appendInfo.offsetsMonotonic" makes sure that there will be no gaps. And the other part "appendInfo.firstOffset < nextOffset.get" I agree that it seems redundant. Guozhang On Fri, Sep 26, 2014 at 5:52 AM, Manjunath Shivakumar < manjunath.shivaku...@betfair.com> wrote:

RE: Log.scala

2014-09-26 Thread Manjunath Shivakumar
Also, would this check be redundant because of https://github.com/apache/kafka/blob/7847e9c703f3a0b70519666cdb8a6e4c8e37c3a7/core/src/main/scala/kafka/log/Log.scala#L243 From: Manjunath Shivakumar [manjunath.shivaku...@betfair.com] Sent: 26 September 2014