Re: Handling consumer rebalance when implementing synchronous auto-offset commit

2013-10-18 Thread Jason Rosenberg
awesome On Fri, Oct 18, 2013 at 1:10 AM, Joel Koshy wrote: > We should be able to get this in after 0.8.1 and probably before the client > rewrite. > > Thanks, > > Joel > > On Wednesday, October 16, 2013, Jason Rosenberg wrote: > > > This looks great. What is the time frame for this effort? >

Re: Handling consumer rebalance when implementing synchronous auto-offset commit

2013-10-17 Thread Joel Koshy
We should be able to get this in after 0.8.1 and probably before the client rewrite. Thanks, Joel On Wednesday, October 16, 2013, Jason Rosenberg wrote: > This looks great. What is the time frame for this effort? > > Jason > > > On Wed, Oct 16, 2013 at 2:19 PM, Joel Koshy wrote: > > > Btw, a

Re: Handling consumer rebalance when implementing synchronous auto-offset commit

2013-10-16 Thread Jason Rosenberg
This looks great. What is the time frame for this effort? Jason On Wed, Oct 16, 2013 at 2:19 PM, Joel Koshy wrote: > Btw, after we complete KAFKA-1000 (offset management in Kafka) it > should be reasonable to commit offsets on every message as long as the > optional metadata portion of the o

Re: Handling consumer rebalance when implementing synchronous auto-offset commit

2013-10-16 Thread Joel Koshy
Btw, after we complete KAFKA-1000 (offset management in Kafka) it should be reasonable to commit offsets on every message as long as the optional metadata portion of the offset commit request is small/empty. Thanks, Joel On Wed, Oct 16, 2013 at 10:35 AM, Jason Rosenberg wrote: > That would be

Re: Handling consumer rebalance when implementing synchronous auto-offset commit

2013-10-16 Thread Jason Rosenberg
That would be great. Additionally, in the new api, it would be awesome augment the default auto-commit functionality to allow client code to mark a message for commit only after processing a message successfully! On Wed, Oct 16, 2013 at 7:52 AM, Jun Rao wrote: > For manual offset commits, it w

Re: Handling consumer rebalance when implementing synchronous auto-offset commit

2013-10-16 Thread Jun Rao
For manual offset commits, it will be useful to have some kind of API that informs the client when a rebalance is going to happen. We can think about this when we do the client rewrite. Thanks, Jun On Tue, Oct 15, 2013 at 9:21 PM, Jason Rosenberg wrote: > Jun, > > Yes, sorry, I think that was

Re: Handling consumer rebalance when implementing synchronous auto-offset commit

2013-10-15 Thread Jason Rosenberg
Jun, Yes, sorry, I think that was the basis for my question. When auto commit is enabled, special care is taken to make sure things are auto-committed during a rebalance. This is needed because when a topic moves off of a consumer thread (since it is being rebalanced to another one), it's as if

Re: Handling consumer rebalance when implementing synchronous auto-offset commit

2013-10-15 Thread Jun Rao
If auto commit is disabled, the consumer connector won't call commitOffsets during rebalancing. Thanks, Jun On Tue, Oct 15, 2013 at 4:16 PM, Jason Rosenberg wrote: > I'm looking at implementing a synchronous auto offset commit solution. > People have discussed the need for this in previous >