Re: OffsetCheckpoint.write()

2015-03-02 Thread Xiao
e current > OffsetCheckpoint.write() does not look good to me. After the file rename, it > still needs to do a fsync. > > In addition, it should maintain a checksum for each check point. The checksum > corruption needs to be checked during the recovery. > > Ideally, it should

OffsetCheckpoint.write()

2015-03-02 Thread Xiao
Hi, all, I just started reading the source codes of Kafka. The current OffsetCheckpoint.write() does not look good to me. After the file rename, it still needs to do a fsync. In addition, it should maintain a checksum for each check point. The checksum corruption needs to be checked during