Erik,
It seems that we can customized the mbean names with Metrics 2.2.0. Any
other reasons that we need to downgrade to Metrics 2.1.5?
Thanks,
Jun
On Sun, Nov 2, 2014 at 12:10 PM, Erik van Oosten <
e.vanoos...@grons.nl.invalid> wrote:
> Hi Jun,
>
> The quotes are because of a regression in Me
Hi Jun,
The quotes are because of a regression in Metrics 2.2.0. IMHO Metrics
2.2.0 should not be used because of this. Just downgrade to Metrics
2.1.5 and you are good.
Of course, upgrading to Metrics 3 would do the trick also.
Kind regards,
Erik.
Jun Rao schreef op 17-10-14 om 20:54:
Note: https://issues.apache.org/jira/browse/KAFKA-1481 (not 1482, just so
there is no confusion)
Otis
--
Monitoring * Alerting * Anomaly Detection * Centralized Log Management
Solr & Elasticsearch Support * http://sematext.com/
On Fri, Oct 31, 2014 at 2:10 PM, Jun Rao wrote:
> Yes, all changes
Yes, all changes are related to metric names. Feel free to review the patch.
Thanks,
Jun
On Fri, Oct 31, 2014 at 10:48 AM, Joel Koshy wrote:
> That sounds good, although is that the only change (sorry I have not
> done a careful review of that patch and would like to before it gets
> checked i
That sounds good, although is that the only change (sorry I have not
done a careful review of that patch and would like to before it gets
checked in).
On Fri, Oct 31, 2014 at 10:42:13AM -0700, Jun Rao wrote:
> To circle back on this thread. The patch in kafka-1482 is almost ready. To
> make the mb
To circle back on this thread. The patch in kafka-1482 is almost ready. To
make the mbean names more meaningful and easier to parse, the patch will
use explicit key/value pairs in the mbean name for things like clientId and
topic, and will get rid of the quotes.
So, instead of
"kafka.server":ty
I'm pretty sure that the quotes are a side effect of using Metrics 2.x. When
part of an Mbean name has certain characters, then that part will be wrapped in
quotes. This is fixed in Metrics 3.
--
Daniel
> On 18/10/2014, at 10:03 am, Rajasekar Elango wrote:
>
> +1 on getting rid of quotes in
mailto:neha.narkh...@gmail.com]
> Sent: Friday, October 17, 2014 22:49
> To: users@kafka.apache.org
> Subject: Re: MBeans, dashes, underscores, and KAFKA-1481
>
> +1 on getting rid of the quotes.
>
> On Fri, Oct 17, 2014 at 12:31 PM, Magnus Spångdal <
> magnus.spang...
+1 on getting rid of quotes in jmx mbeans.
Thanks,
Raja.
On Fri, Oct 17, 2014 at 4:48 PM, Neha Narkhede
wrote:
> +1 on getting rid of the quotes.
>
> On Fri, Oct 17, 2014 at 12:31 PM, Magnus Spångdal <
> magnus.spang...@deltaprojects.com> wrote:
>
> > +1 to get rid of quotes, thanks!
> >
> >
>
22:49
To: users@kafka.apache.org
Subject: Re: MBeans, dashes, underscores, and KAFKA-1481
+1 on getting rid of the quotes.
On Fri, Oct 17, 2014 at 12:31 PM, Magnus Spångdal <
magnus.spang...@deltaprojects.com> wrote:
> +1 to get rid of quotes, thanks!
>
>
>
>
>
>
> —
+1 on getting rid of the quotes.
On Fri, Oct 17, 2014 at 12:31 PM, Magnus Spångdal <
magnus.spang...@deltaprojects.com> wrote:
> +1 to get rid of quotes, thanks!
>
>
>
>
>
>
> —
> Sent from Mailbox
>
> On Fri, Oct 17, 2014 at 8:54 PM, Jun Rao wrote:
>
> > Hi, everyone,
> > We are fixing the mbea
+1 to get rid of quotes, thanks!
—
Sent from Mailbox
On Fri, Oct 17, 2014 at 8:54 PM, Jun Rao wrote:
> Hi, everyone,
> We are fixing the mbean names in kafka-1482, by adding separate explicit
> tags in the name for things like clientId and topic. Another thing that
> some people have compl
Hi, everyone,
We are fixing the mbean names in kafka-1482, by adding separate explicit
tags in the name for things like clientId and topic. Another thing that
some people have complained before is that we use quotes in the jmx name.
Should we also just get rid of the quotes as part of kafka-1482?
I am going to vote for 1482 to be included in 0.8.2, if we have a patch
submitted in a week. I think we've had this JIRA opened for too long and we
held people back so it's only fair to release this.
On Wed, Oct 8, 2014 at 9:40 PM, Jun Rao wrote:
> Otis,
>
> Just have the patch ready asap. We ca
Otis,
Just have the patch ready asap. We can make a call then.
Thanks,
Jun
On Wed, Oct 8, 2014 at 6:13 AM, Otis Gospodnetic wrote:
> Hi Jun,
>
> Would by the end of next week be acceptable for 0.8.2?
>
> Thanks,
> Otis
> --
> Monitoring * Alerting * Anomaly Detection * Centralized Log Managem
Hi Jun,
Would by the end of next week be acceptable for 0.8.2?
Thanks,
Otis
--
Monitoring * Alerting * Anomaly Detection * Centralized Log Management
Solr & Elasticsearch Support * http://sematext.com/
On Tue, Oct 7, 2014 at 4:04 PM, Jun Rao wrote:
> Otis,
>
> Yes, if you guys can help provid
Otis,
Yes, if you guys can help provide a patch in a few days, we can probably
get it to the 0.8.2 release.
Thanks,
Jun
On Tue, Oct 7, 2014 at 12:10 PM, Otis Gospodnetic <
otis.gospodne...@gmail.com> wrote:
> Hi Jun,
>
> I think your MBean renaming approach will work. I see
> https://issues.a
Hi Jun,
I think your MBean renaming approach will work. I see
https://issues.apache.org/jira/browse/KAFKA-1481 has Fix Version 0.8.2, but
is not marked as a Blocker. We'd love to get the MBeans fixed so this
makes it in 0.8.2 release. Do you know if this is on anyone's plate (the
issue is curre
Otis,
In kafka-1481, we will have to change the mbean names (at least the ones
with clientid and topic) anyway. Using the name/value pair in the mbean
name allows us to do this in a cleaner way. Yes, "," is not allowed in
clientid or topic.
Bhavesh,
Yes, I was thinking of making changes in the n
Hi Jun,
On Wed, Sep 17, 2014 at 12:35 PM, Jun Rao wrote:
> Bhavesh,
>
> Yes, allowing dot in clientId and topic makes it a bit harder to define the
> JMX bean names. I see a couple of solutions here.
>
> 1. Disable dot in clientId and topic names. The issue is that dot may
> already be used in e
Sure we can do the option 2 for JMX beans. But same solution should be
applied to producer.metrics() method for new producer. Regardless of
metric is access (JMX or via producer), it has to be consistent naming
convention.
For example, I get following metric name when my topic is "topic.dot". S
Bhavesh,
Yes, allowing dot in clientId and topic makes it a bit harder to define the
JMX bean names. I see a couple of solutions here.
1. Disable dot in clientId and topic names. The issue is that dot may
already be used in existing deployment.
2. We can represent the JMX bean name differently i
HI Otis,
What is migration path ? If topic with special chars exists already(
".","-","|" etc) in previous version of producer/consumer of Kafka, what
happens after the upgrade new producer or consumer (kafka version) ? Also,
in new producer API (Kafka Trunk), does this enforce the rule about c
Hi,
So maybe I should I should have asked the Q explicitly:
Could we commit the patch from
https://issues.apache.org/jira/browse/KAFKA-1481 now that, I hope, it's
clear what problems the current MBean names can cause?
Thanks,
Otis
--
Monitoring * Alerting * Anomaly Detection * Centralized Log Man
Hi,
*Problem:*
Some Kafka 0.8.x MBeans have names composed of things like --. Note how dashes are used as delimiters.
When and don't contain the delimiter character
all is good if you want to extract parts of this MBean name by simply
splitting on the delimiter character. The problem is that
25 matches
Mail list logo
