Re: Fwd: Request to be added to kafka contributors list

2024-05-21 Thread Franck (Handfreezer - Ether)
Hello, 1/ for sure 2/ after rebasing my code change, I'll do the full test. To answer to the question I'm under Debian 12, OpenJDK 17.0.10 on my dev machine. Best regards Le 2024-05-21 16:46, Greg Harris a écrit : Hi Franck, Thank you for contributing to Apache Kafka! 1. Git is generally per

Re: Fwd: Request to be added to kafka contributors list

2024-05-21 Thread Greg Harris
Hi Franck, Thank you for contributing to Apache Kafka! 1. Git is generally permissive of this, as long as there are no merge conflicts. If you have merge conflicts with `trunk`, you will need to resolve them before a committer can merge your changes, so rebasing on trunk before opening the PR is

Re: Fwd: Request to be added to kafka contributors list

2024-05-21 Thread Franck
Hello, It works like a charm. Few questions: 1. Now, I'm asking my self, I did the job describe in JIRA 16707 in a fork/branch of the 3.7.0 of kafka, but reading the "Contributing Code Change", I feeI should have done it on a branch from trunk of my fork? (if so, I'll just do on my for

Re: Fwd: Request to be added to kafka contributors list

2024-05-20 Thread Matthias J. Sax
Done. You should be all set :) -Matthias On 5/20/24 10:10 AM, bou...@ulukai.net wrote: Dear Apache Kafka Team,     I hope to post in the right place: my name is Franck LEDAY, under Apache-Jira ID "handfreezer".     I opened an issue as Improvement KAFKA-16707 but I failed to assigned i

Fwd: Request to be added to kafka contributors list

2024-05-20 Thread boulot
Dear Apache Kafka Team,     I hope to post in the right place: my name is Franck LEDAY, under Apache-Jira ID "handfreezer".     I opened an issue as Improvement KAFKA-16707 but I failed to assigned it to me.     May I ask to be added to the contributors list for Apache Kafka? As I alread