Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-17 Thread Matthias J. Sax
Hi, I updated the KIP and added an `OutputVerifier` class. Looking forward to your feedback. I will start the Vote thread in parallel. -Matthias On 1/17/18 11:40 AM, Matthias J. Sax wrote: > Saïd, > > sorry for late reply. Avro records are basically supported. However, > there are no plans

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-17 Thread Matthias J. Sax
Saïd, sorry for late reply. Avro records are basically supported. However, there are no plans atm to integrate the test driver with a schema registry. Note, that Apache Kafka does not provide a schema registry by itself. If we integrate one RS, we need to integrate all of them -- that is something

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-17 Thread Saïd Bouras
Matthias, What about testing topology that use avro schema ? Have you read my previous response ? Thanks. On Wed, Jan 17, 2018 at 3:34 AM Matthias J. Sax wrote: > Colin, > > the TopologyTestDriver does not connect to any broker and simulates > processing of single-partitioned input topics pure

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-16 Thread Matthias J. Sax
Colin, the TopologyTestDriver does not connect to any broker and simulates processing of single-partitioned input topics purely in-memory (the driver is basically a mock for a StreamThread). This is sufficient to test basic business logic. For more complex topologies that are actually divided into

Fwd: Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-16 Thread Matthias J. Sax
Forgot dev-list... Forwarded Message Subject: Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams Date: Tue, 16 Jan 2018 13:56:38 -0800 From: Matthias J. Sax Organization: Confluent Inc To: users@kafka.apache.org Thanks a lot for the comments. @Guozhang: I updated

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-16 Thread Matthias J. Sax
Thanks a lot for the comments. @Guozhang: I updated the KIP accordingly. With regard to potential client test-utils, I agree, but not sure how to resolve it. I guess, we just need to move the class for this case later on. (One reason to annotate all classes with @Evolving) @Bill: The new artifact

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-16 Thread Jeff Klukas
>From what I can tell, global state stores are managed separately from other state stores and are accessed via different methods. Do the proposed methods on TopologyTestDriver (such as getStateStore) cover global stores? If not, can we add an interface for accessing and testing global stores in th

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-16 Thread Bill Bejeck
Thanks for the KIP! One meta question: Will users that are currently using the existing testing code with the "classifier:test" approach: 1) have access to the new testing utilities without updating the gradle.build file 2) can they continue to use the current testing code with the cl

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-16 Thread Colin McCabe
Thanks, Matthias, this looks great. It seems like these APIs could either be used against mock objects, or against real brokers running in the same process. Is there a way for the user to select which they want when using the API? Sorry if it's in the KIP and I missed it. cheers, Colin On

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-16 Thread Guozhang Wang
Thanks Matthias, I made a pass over the wiki and left some comments; I see you have addressed most of them. Here are a few more: 1. "TopologyTestDriver#process()": how about rename it to "pipeInput" or "sendInput"? 2. For "ConsumerRecordFactory" constructor where "startTimestampMs" is not specifi

Re: [DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-15 Thread Saïd Bouras
Hi Matthias, I read the KIP and it will be very helpful thanks to the changes, I don't see though a part that handle topologies that use avro schemas, is it in the scope of the KIP ? I open an issue two month ago in the schema-registry repo : https://github.com/confluentinc/schema-registry/issues

[DISCUSS] KIP-247: Add public test utils for Kafka Streams

2018-01-11 Thread Matthias J. Sax
Dear Kafka community, I want to propose KIP-247 to add public test utils to the Streams API. The goal is to simplify testing of Kafka Streams applications. Please find details in the wiki: https://cwiki.apache.org/confluence/display/KAFKA/KIP-247%3A+Add+public+test+utils+for+Kafka+Streams This i