ApiVersionsResponse writes apiKeys prepended with two bytes instead of one byte.

2024-11-02 Thread Chain Head
Hi, I am implementing broker as a hobby project. Here is the high level flow. 1. Set up a response header with correlation ID and header version (1). 2. Create an `ApiVersionCollection` and add APIs. For now, I have added only two - `PRODUCE` and `METADATA` with min, max versions and no tagged fie

Re: Kafka Tiered Storage Disablement Implement in ZK Mode Question

2024-11-02 Thread Kamal Chandraprakash
For shortcoming (2), looking at the code, as long as the partition is not offline during disablement (leader is available), then the remote-log deletion might proceed as expected. Note that the feature is not tested out in ZK mode, and the implementation details can change later. So, I'd suggest yo

Re: Kafka Tiered Storage Disablement Implement in ZK Mode Question

2024-11-02 Thread Kamal Chandraprakash
Hi Jianfeng, As Luke already mentioned, the feature was not tested in ZK mode. If you still want to enable it in the ZK mode, then: 1. Disable the LogConfig#validateNoInvalidRemoteStorageConfigsInZK