[users@httpd] Potential Bug in mpm_common.c

2012-06-14 Thread Ken Cheung
I observed a code clone in the following files. In the function ap_mpm_set_max_mem_free the variable "value" has to be multiplied by 1024 before exit while ap_mpm_set_thread_stacksize does not perform this operation. I wonder if this is necessary. Hope it helps. function : ap_mpm_set_max_mem_fr

[users@httpd] Potential Bug in mod_file_cache.c

2012-06-13 Thread Ken Cheung
I observed a code clone in the following files. The second and third functions type cast the object after allocation using "apr_palloc" while the first function does not. I wonder if this is necessary in the function "create_server_config". Hope it helps. function : create_server_config @ (file